Urgent Help need creating a NETSH login script

Looks like someone already needed that here:https://www.experts-exchange.com/questions/21326998/Netsh-script-to-check-DHCP-enabled.html

@leew
for /f "tokens=3" %%a in ('netsh interface ip show config ^| find /i "DHCP Enabled"') do set DHCP=%%a
If /i "%dhcp%" == "Yes" (
    netsh interface ip set dns "Local Area Connection" dhcp
) Else (
    netsh interface ip set dns "Local Area Connection" static 10.0.0.3
)

You could actually avoid the environment variable entirely with this:

for /f "tokens=3" %%a in ('netsh interface ip show config ^| find /i "DHCP Enabled"') do (
If /i "%%a" == "Yes" (
    netsh interface ip set dns "Local Area Connection" dhcp
) Else (
    netsh interface ip set dns "Local Area Connection" static 10.0.0.3
)
)

Or, more comprehensive,

netsh int ip dump | findstr "dns wins" | findstr source=static && (
  rem your netsh commands here
)

This is not quite what I was looking for...

I need this script to run ONLY on clients who have STATIC DNS & WINS enteries. please note some clients are set to DHCP for there TCP/IP settings but DNS is startic. I need this script to look for all static DNS & WINS and update these enteries only!!!!!!!!!!!!!!!!!!!!!!!

My script should work for exactly this situation. It's checking the DNS and WINS entries only for being static.

OK this is what my scritp looks like. Right now I just paused on screen and never changes my static DNS / WINS settings

netsh int ip dump | findstr "dns wins" | findstr source=static && (netsh interface ip set dns "Local Area Connection" static 1.2.3.4
netsh interface ip add dns "Local Area Connection" 1.2.3.4 index=2
netsh interface ip set wins "Local Area Connection" static 1.2.3.4
netsh interface ip add wins "Local Area Connection" 1.2.3.4index=2)

Just tried, and it works fine for me. Does it output the config lines found?

Whn I just run the first part of the script:

netsh int ip dump | findstr "dns wins" | findstr source=static
It works and list the connection information "IF" it has static DNS & WINS enteries which is what  want. The problem is this inforamtion is not beening replacement with the correct DNS & WINS information from my scrupt. Don't I need an if statement somewhere??????

No, the && is like an IF. If the previous command "succeeds", i.e. returns a errolevel of 0, the command after && is executed. You can try by using

netsh int ip dump | findstr "dns wins" | findstr source=static && echo --- It is STATIC ---


The complete command as you posted above should give the same output, plus the results of your netsh commands, which should be 4 times "OK!".

Do I need the ( ) ??? in this script?

Right now the script RUN and updates the DNS but it RUNS on my client who have DNS set by DHCP which is what I do not want

You need the () to build a single block executed only if the condition applies (findstr finding "source=static"). If you omit the parentheses, only the first command is executed conditional, the remainder always.

Still now working... the script is working but it is running no matter if the current DNS settings are DHCP or static... :-(

Your are doing something wrong. You confirmed that
is displaying the correct lines.
Should display the same lines, and the text "--- It is STATIC" if any of the entries contain source=static.
Is applied if at least one of DNS or WINS setting is static.

Do I need the ^ after the &&?

If you write the ( into the next line - yes. Instead you can use

netsh int ip dump | findstr "dns wins" | findstr source=static && (
)

if you like that more.

I noticed that when this script runs it updates both my Local Area Connection and Network Adapter Local but I do not see Network Adapter Connection listed any where

This worked perfectly....

Thanks Again