Solved

Macro to import multiple TXT files (without column headings) from a fixed directory into a single worksheet

Posted on 2009-07-15
2
567 Views
Last Modified: 2012-06-27
Please reference the original question in the "Related Solution" link (http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/Q_24032194.html)

RobSampson provided the attached code in an earlier question and it works great to import multiple .txt files into a single Excel workbook. However, It appears that this code expects column headings in the source files to work properly. The first file in the list is imported in its entirety but subsequent files have the first row omitted. How can I modify the code to work with source files without column headings.

Thanks for your help!
David

My data does not have column headings.

Private Declare Function SetCurrentDirectoryA Lib _

            "kernel32" (ByVal lpPathName As String) As Long

 

Public Function ChDirNet(szPath As String) As Boolean

'based on Rob Bovey's code

    Dim lReturn As Long

    lReturn = SetCurrentDirectoryA(szPath)

    ChDirNet = CBool(lReturn <> 0)

End Function

 

 

Sub Get_CSV_Files_To_One_WB()

'For Excel 2000 and higher

    Dim Fnum As Long

    Dim mybook As Workbook

    Dim basebook As Workbook

    Dim CSVFileNames As Variant

    Dim SaveDriveDir As String

    Dim ExistFolder As Boolean

 

    'Save the current dir

    SaveDriveDir = CurDir

 

    'You can change the start folder if you want for

    'GetOpenFilename,you can use a network or local folder.

    'For example ChDirNet("C:\Users\Ron\test")

    'It now use Excel's Default File Path

 

    ExistFolder = ChDirNet(Application.DefaultFilePath)

    If ExistFolder = False Then

        MsgBox "Error changing folder"

        Exit Sub

    End If

 

    ' Make sure all cells are "Text" format before import

    Cells.NumberFormat = "@"

    Range("A1").Select

    

    ' Get user to select the file(s)

    'CSVFileNames = Application.GetOpenFilename _

    '    (filefilter:="CSV Files (*.csv), *.csv", MultiSelect:=True)

    CSVFileNames = Application.GetOpenFilename _

        (filefilter:="TXT Files (*.txt), *.txt", MultiSelect:=True)

        

    If IsArray(CSVFileNames) Then

 

        On Error GoTo CleanUp

 

        With Application

            '.ScreenUpdating = False

            .EnableEvents = False

        End With

 

        'Add workbook with one sheet

        'Set basebook = Workbooks.Add(xlWBATWorksheet)

        Set basebook = ActiveWorkbook

        

        'Delete all sheets except the first sheet of basebook

        On Error Resume Next

        Application.DisplayAlerts = False

        While basebook.Sheets.Count > 1

            basebook.Worksheets(basebook.Worksheets.Count).Delete

        Wend

        Application.DisplayAlerts = True

        On Error GoTo 0

        

        'Loop through the array with csv files

        For Fnum = LBound(CSVFileNames) To UBound(CSVFileNames)

 

            'Set mybook = Workbooks.Open(CSVFileNames(Fnum))

            Workbooks.OpenText Filename:= _

               CSVFileNames(Fnum), Origin:=437, StartRow:= _

               1, DataType:=xlDelimited, TextQualifier:=xlDoubleQuote, _

               ConsecutiveDelimiter:=False, Tab:=False, Semicolon:=False, Comma:=True _

               , Space:=False, Other:=False, FieldInfo:=Array(Array(1, 2), Array(2, 2), _

               Array(3, 2), Array(4, 2), Array(5, 2), Array(6, 2), Array(7, 2), Array(8, 2), _

               Array(9, 2), Array(10, 2), Array(11, 2), Array(12, 2), Array(13, 2), Array(14, 2), _

               Array(15, 2)), TrailingMinusNumbers:=True

            

            Set mybook = ActiveWorkbook

 

            intLastRow = mybook.Worksheets(1).Cells(65536, 1).End(xlUp).Row

            intLastCol = mybook.Worksheets(1).Cells(1, 256).End(xlToLeft).Column

            intLastBaseRow = basebook.Sheets(1).Cells(65536, 1).End(xlUp).Row

            If intLastBaseRow > 1 Then

                intLastBaseRow = intLastBaseRow + 1

                intFirstRow = 2

            Else

                intFirstRow = 1

            End If

            mybook.Worksheets(1).Range(Cells(intFirstRow, 1).Address & ":" & Cells(intLastRow, intLastCol).Address).Copy _

                basebook.Sheets(1).Cells(intLastBaseRow, "A")

 

            mybook.Close savechanges:=False

 

        Next Fnum

  

        With Application

            .ScreenUpdating = True

            .EnableEvents = True

        End With

        

        basebook.Sheets(1).Select

        basebook.Sheets(1).Cells(1, "A").Select

        

        MsgBox "Please save this save the file."

 

CleanUp:

 

        ChDirNet SaveDriveDir

 

        With Application

            .ScreenUpdating = True

            .EnableEvents = True

        End With

    End If

End Sub

Open in new window

0
Comment
Question by:dking_wri
2 Comments
 
LVL 6

Accepted Solution

by:
Jaffa0 earned 500 total points
ID: 24861101
Change this bit
            If intLastBaseRow > 1 Then
                intLastBaseRow = intLastBaseRow + 1
                intFirstRow = 2
            Else
                intFirstRow = 1
            End If

to this:

            If intLastBaseRow > 1 Then
                intLastBaseRow = intLastBaseRow + 1
                intFirstRow = 1
            Else
                intFirstRow = 1
            End If
0
 

Author Closing Comment

by:dking_wri
ID: 31603800
Worked perfectly.  Thanks for your help!
David
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
macro for each dropdown 15 46
Auto populate in Cascade dropdown 3 27
Most Consistent Performer 4 21
How do i remove text in between commas in Excel? 14 19
Workbook link problems after copying tabs to a new workbook? David Miller (dlmille) Intro Have you either copied sheets to a new workbook, and after having saved and opened that workbook, you find that there are links back to the original sou…
Not long ago I saw a question in the VB Script forum that I thought would not take much time. You can read that question (Question ID  (http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/Q_28455246.html)28455246) Here (http…
Graphs within dashboards are meant to be dynamic, representing data from a period of time that will change each time the dashboard is updated with new data. Rather than update each graph to point to a different set within a static set of data, t…
This Micro Tutorial will demonstrate the scrolling table in Microsoft Excel using the INDEX function.

895 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now