Java program issue

public class Account {
    int bal;
    double Balance;
    public Account(){}
    public Account(double Balance) {
        Balance = bal;
    }
 
 
    
    public void setBalance(double bal) {
       Balance = bal;
    }
 
 
    public double getBalance() {
        return Balance;
    }
 
    public double credit(double credit) {
 
        return Balance += Balance + credit;
    }
 
    public boolean debit(double debitamt)
{
if(getBalance()-debitamt<0)
return false;
setBalance(getBalance()-debitamt);
return true;
}
 
 
 
}

Select allOpen in new window

public class SavingsAccount extends Account {
    double Interest;
    int IR;
     SavingsAccount(double Balance, double Interest) {
        Balance=bal;
        Interest=IR;
    }
 
 
public void setInterestRate(double IR) {
    Interest = IR;
}
public double getInterestRate() {
    return Interest;
}
double calculateInterest()
{
return getBalance()*getInterestRate();
}
 
 
}

Select allOpen in new window

public class CheckingAccount extends Account {
    double fee;
    public CheckingAccount(double newBal, double theFee) {
    setBalance(newBal);
    fee = theFee;
    }
 
public void setFee(double theFee) {
    fee = theFee;
}
 
public double getFee() {
    return fee;
}
 public boolean debit(double debitamt)
{
return super.debit(debitamt+getFee());
}
        
 
}

Select allOpen in new window

Can you post a zip file containing all the code pls??

There are a number of places, it would appear you are setting the values incorrectly like :

public Account(double Balance) {
        Balance = bal;
    }


SavingsAccount(double Balance, double Interest) {
        Balance=bal;
        Interest=IR;
    }


Check that you are properly setting the instance variables on construction and in mutator methods.

With an inherited class, I would also expect to see this code :

SavingsAccount(double Balance, double Interest) {
        Balance=bal;
        Interest=IR;
    }

More like this :

SavingsAccount(double Balance, double Interest) {
       super(Balance);
        this.Interest=Interest;
    }



Kevin

Also be careful with your syntax :

Balance += Balance + credit;


Note:
Balance += 1; // <<< this already means add 1 to current balance

Same as :
Balance = Balance + 1;


Therefore, if you have :
Balance += Balance + 1;

It is same as :
Balance = Balance + Balance + 1;

So long story short, you want :
Balance += credit;


As a side note, try to follow Java naming conventions and other best practices where possible.

variables should be camelCase, where as class names should be CamelCase. :)

double balance;
balance += credit;

Ah, thank you for the advice once again Kevin, your dual accounts have helped me once again ;)
Yes, I knew i would probably run into problems with the way i set values, i was confused as to where I should put them and when. Also, with your one tip of using this.Interest = Interest...If im understanding correctly could that same concept be used in my set functions instead of using a different variable?

for example,

public void setFee() {
    this.Fee = Fee;
}

Awesome, thanks! That works much better, any other tips as to whats wrong? Im only getting some of the right output, is it still my values being set incorrectly?

What does your new source look like (you can start with just the BankTest.java) and what you are getting as output and what you expect.  One thing I saw earlier was a copy and paste error so just checking to see if you have any others, although you may be able to spot them for yourself now that you know what to look for.

act.setBalance(12345.67);
     System.out.println("sav account balance is " + sav.getBalance() );

Notice here you are setting the act balance but then checking the sav balance.

I have actually not wrote the bankTest, I just needed to make my classes work with it. After redoing my set functions, my classes are as follows...multiple posts..

public class Account {
    double Balance;
    public Account(){}
    public Account(double Balance) {
        this.Balance = Balance;
    }
 
 
    
    public void setBalance(double Balance) {
       this.Balance=Balance;
    }
 
 
    public double getBalance() {
        return Balance;
    }
 
    public double credit(double credit) {
 
        return Balance += credit;
    }
 
    public boolean debit(double debitamt)
{
if(getBalance()-debitamt<0)
return false;
setBalance(getBalance()-debitamt);
return true;
}
 
 
 
}

Select allOpen in new window

public class SavingsAccount extends Account {
    double Interest;
     SavingsAccount(double Balance, double Interest) {
        super(Balance);
        this.Interest=Interest;
    }
 
 
public void setInterestRate(double Interest) {
    this.Interest=Interest;
}
public double getInterestRate() {
    return Interest;
}
double calculateInterest()
{
return getBalance()*getInterestRate();
}
 
 
}

Select allOpen in new window

public class CheckingAccount extends Account {
    double fee;
    public CheckingAccount(double fee) {
    this.fee = fee;
    }
 
public void setFee(double fee) {
    this.fee=fee;
}
 
public double getFee() {
    return fee;
}
 public boolean debit(double debitamt)
{
return super.debit(debitamt+getFee());
}
        

Select allOpen in new window

a few more changes were made between posts and I believe it is working, unless it is supposed to be resetting the balances throughout the program. It seems to be adding them together because of the += instead of resetting them. Seeing as the interest rate late in the program is 95..it leads me to believe it is supposed to keep resetting the values

If the program uses credit() method then yes it will be a running balance which is accurate.  If you are wanting to reset the balance, you need to use setBalance().

Oooh, I am understanding this more now after looking through it more thoroughly.. Everything looks to be in order, and if I find it isn't I should be able to take care of it from what I learned. Thank you once again Kevin.

Thanks again!

You are most welcome!
Best regards and happy coding,
Kevin