Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 862
  • Last Modified:

Cross threading error in VB.net

I get an error when trying to run my program:
Cross-thread operation not valid: Control 'lstFiles' accessed from a thread other than the thread it was created on.

Now I know i need to invoke somehow, but I am lost as to how to do this. How can I fix this cross threading issue in my software and how can I have file_name NOT include the entire path in it?
Imports System.IO

Public Class Form1
    Inherits System.Windows.Forms.Form
    Public Function ExecCommand(ByRef CommandLine As String, _
                            Optional ByRef Arguments As String = "", _
                            Optional ByRef Waitforexit As Boolean = True) As Integer
        Dim psi As New ProcessStartInfo()
        Dim p As Process

        With psi
            .FileName = CommandLine
            .Arguments = Arguments
            .WindowStyle = ProcessWindowStyle.Hidden 'This avoid a text window being opened
        End With
            p = Process.Start(psi) 'This line runs the command
            If Waitforexit Then p.WaitForExit() 'This wait until the command ends
            Return p.ExitCode
        Catch e As System.Exception
            'Catch errors here
        End Try
    End Function

#Region " Windows Form Designer generated code "

    Public Sub New()

        'This call is required by the Windows Form Designer.

        'Add any initialization after the InitializeComponent() call

    End Sub

    'Form overrides dispose to clean up the component list.
    Protected Overloads Overrides Sub Dispose(ByVal disposing As Boolean)
        If disposing Then
            If Not (components Is Nothing) Then
            End If
        End If
    End Sub

    'Required by the Windows Form Designer
    Private components As System.ComponentModel.IContainer

    'NOTE: The following procedure is required by the Windows Form Designer
    'It can be modified using the Windows Form Designer.  
    'Do not modify it using the code editor.
    Friend WithEvents lstFiles As System.Windows.Forms.ListBox
    <System.Diagnostics.DebuggerStepThrough()> Private Sub InitializeComponent()
        Me.lstFiles = New System.Windows.Forms.ListBox
        Me.lstFiles.Dock = System.Windows.Forms.DockStyle.Fill
        Me.lstFiles.Location = New System.Drawing.Point(0, 0)
        Me.lstFiles.Name = "lstFiles"
        Me.lstFiles.Size = New System.Drawing.Size(1025, 368)
        Me.lstFiles.TabIndex = 0
        Me.AutoScaleBaseSize = New System.Drawing.Size(5, 13)
        Me.ClientSize = New System.Drawing.Size(1025, 372)
        Me.Name = "Form1"
        Me.Text = "Form1"

    End Sub

#End Region

    Private m_WatchDirectory As String
    Private WithEvents m_FileSystemWatcher As FileSystemWatcher

    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        'lstFiles.Items.Add(Now.ToString() & " Starting")

        ' Get the path to the directory we will watch.
        'm_WatchDirectory = Application.StartupPath
        'm_WatchDirectory = m_WatchDirectory.Substring(0, m_WatchDirectory.LastIndexOf("\"))
        m_WatchDirectory &= "c:\docume~1\user\desktop\howtofolderwatcher\baton\bad"

        ' Make the FileSystemWatcher.
        m_FileSystemWatcher = New FileSystemWatcher(m_WatchDirectory, "*.mpg")
        m_FileSystemWatcher.NotifyFilter = 0
        m_FileSystemWatcher.NotifyFilter = m_FileSystemWatcher.NotifyFilter Or NotifyFilters.FileName
        m_FileSystemWatcher.EnableRaisingEvents = True

        ' Process any files that already exist.
    End Sub

    ' Process a new file.
    Private Sub m_FileSystemWatcher_Created(ByVal sender As Object, ByVal e As System.IO.FileSystemEventArgs) Handles m_FileSystemWatcher.Created
    End Sub

    ' Process existing files.
    'Private Sub ProcessExistingFiles(ByVal directory_name As String)
    'Dim dir_info As New DirectoryInfo(directory_name)
    'Dim file_infos As FileInfo() = dir_info.GetFiles()
    'For Each fi As FileInfo In file_infos
    'Next fi
    ' End Sub

    ' Process a file.
    Private Sub ProcessFile(ByVal file_name As String)
        lstFiles.Items.Add(Now.ToString() & " Processed " & file_name)
        ExecCommand("cmd", " /c " & "c:\docume~1\user\desktop\howtofolderwatcher\baton\bad\dtrmxutil.exe " & file_name & " nulls" & file_name & " 6000000", Waitforexit:=True)

    End Sub

End Class

Open in new window

1 Solution
Do it like this:

    'Create a delegate
    Private Delegate Sub mProcessFileDelegate(ByVal file_name As String)

    Private Sub ProcessFile(ByVal file_name As String)

        If lstFiles.InvokeRequired Then

            Dim d As New mProcessFileDelegate(AddressOf ProcessFile)
            lstFiles.Invoke(d, New Object() {file_name})


            lstFiles.Items.Add(Now.ToString() & " Processed " & file_name)

        End If

    End Sub

cpserviceAuthor Commented:

Featured Post

[Webinar On Demand] Database Backup and Recovery

Does your company store data on premises, off site, in the cloud, or a combination of these? If you answered “yes”, you need a data backup recovery plan that fits each and every platform. Watch now as as Percona teaches us how to build agile data backup recovery plan.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now