Close SQL connection

hi,

modify like,

objConnection.Open();
objCommand.ExecuteNonQuery();
objConnection.Close();

Try this... Close connection after execute.

internal static void uploadFile(Attachment aAttachment) 
    { 
 
      using (SqlConnection objConnection = new SqlConnection(_connectionstring)) 
      { 
        using (SqlCommand objCommand = CreateSqlCommand("Attachment", objConnection)) 
        { 
          objCommand.Parameters.Add("@FileName", SqlDbType.VarChar, 300).Value = aAttachment.FileName; 
          objConnection.Open(); 
          objCommand.ExecuteNonQuery(); 
          objConnection.Close(); 
        } 
      } 
    }

Select allOpen in new window

is it same for code like this

internal static DataSet getDocOwner(int admid)
    {

      using (SqlConnection objConnection = new SqlConnection(_connectionstring))
      {
        using (SqlCommand objCommand = CreateSqlCommand("Categories", objConnection))
        {
          objCommand.Parameters.Add("@AdminID", SqlDbType.Int).Value = admid;
          using (DataSet objDS = new DataSet())
          using (SqlDataAdapter objDataAdapter = new SqlDataAdapter(objCommand))
          {
            objDataAdapter.Fill(objDS);
            return objDS;
          }
        }
      }
    }

do I place

objConnection.Close();  
after return objDS;


so

return objDS;
objConnection.Close();  

Hi,

if you are using it like this,
  using (SqlConnection objConnection = new SqlConnection(_connectionstring))
      {
      }

you do not need to close it.

Thanks,
Krunal

A DataAdapter should take care of opening and closing the DB connection for you (when you call Fill()). Are you sure you are not manually opening a connection somewhere else?

i have this code too, dont know if this helps?

private static string _connectionstring = "connString";

static DALClass()
    {
      ConnectionStringSettings conString = ConfigurationManager.ConnectionStrings[_connectionstring];
      if (conString == null) throw new ConfigurationErrorsException(string.Format("You must have a {0} connection string in the config file", _connectionstring));
      _connectionstring = conString.ConnectionString;
    }

It's always advisable to close a connection inside finally as below..,

internal static void uploadFile(Attachment aAttachment)
    {

      using (SqlConnection objConnection = new SqlConnection(_connectionstring))
      {
        using (SqlCommand objCommand = CreateSqlCommand("Attachment", objConnection))
        {
          objCommand.Parameters.Add("@FileName", SqlDbType.VarChar, 300).Value = aAttachment.FileName;
          objConnection.Open();
          objCommand.ExecuteNonQuery();          
        }
      }
    }

finally
{
  objConnection.Close();
}

Select allOpen in new window

hi i would prefer this code

internal static void uploadFile(Attachment aAttachment)
    {
SqlConnection objConnection ;
     try
      {
    objConnection = new SqlConnection(_connectionstring)
         using (SqlCommand objCommand = CreateSqlCommand("Attachment", objConnection))
        {
          objCommand.Parameters.Add("@FileName", SqlDbType.VarChar, 300).Value = aAttachment.FileName;
          objConnection.Open();
          objCommand.ExecuteNonQuery();
        }
      }
        catch(Exception ex)
        {
        }
        finally
        {
        objConnection.Close();
          }
}

Select allOpen in new window

Yes zadeveloper, I looked at my code, and the problem was because of methods and variables set as static.

And kaufmed, you too were right, I shouldnt have to close it, because the using block should take care of it.

Thanks to all the people who helped me out

Take care

no problems ... good luck.

NP. Glad to help :)