Script for create linkedserver


I try to script the creation of linkserver, I have this error :
Msg 102, Level 15, State 1, Procedure transfer_schema2, Line 17
Incorrect syntax near '@rmtsrvname'.

Do you have a solution?
CREATE PROCEDURE [dbo].[transfer_schema2]
@Srvsource varchar (30),
@Dbsource varchar(30),
@Schsource varchar(30),
@DbDest varchar(30),
@SchDest varchar (30),
@Pwd varchar (30)


EXEC master.dbo.sp_addlinkedserver @server = @Srvsource, @srvproduct=N'SQL Server'
 /* For security reasons the linked server remote logins password is changed with ######## */

declare @sql1 nvarchar(max);
set @sql1 = 'EXEC master.dbo.sp_addlinkedsrvlogin '@rmtsrvname=N'@Srvsource',@useself=N''False'',@locallogin=NULL,@rmtuser=''sa'',@rmtpassword=''' +@Pwd + '''''
exec sp_executesql @sql1

Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Guy Hengel [angelIII / a3]Billing EngineerCommented:
you have to duplicate any single quote within the string:
set @sql1 = 'EXEC master.dbo.sp_addlinkedsrvlogin @rmtsrvname =N''' + @Srvsource + ''', @useself=N''False'',@locallogin=NULL,@rmtuser=''sa'',@rmtpassword=''' +@Pwd + ''' '
exec sp_executesql @sql1

Open in new window


Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
set @sql1 = 'EXEC master.dbo.sp_addlinkedsrvlogin '@rmtsrvname=N'@Srvsource',@useself=N''False'',@locallogin=NULL,@rmtuser=''sa'',@rmtpassword='''  +@Pwd + '''''

set @sql1 = 'EXEC master.dbo.sp_addlinkedsrvlogin @rmtsrvname=N'''+@Srvsource +',@useself=N''False'',@locallogin=NULL,@rmtuser=''sa'',@rmtpassword=''' +@Pwd + ''''

Open in new window

bibi92Author Commented:
Thanks a lot, perfect. Regards bibi
Disregard my answer, I had a typo and angelIII's looks to be correct.
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server

From novice to tech pro — start learning today.