SQL - INSERT data if no row in table

Hi Experts,

I have a stored proc that works. However, I believe it could be better structured. Basically, the sproc checks
 - if there is record in table1 insert records from table2 by using a SELECT statement, without a condition

- if there are record(s) in the table1, insert records from table2 by using a SELECT statement with a WHERE condition.

Simplified example code I wrote below:

DECLARE @maxDate datetime;
SELECT @maxDate = MAX(LastUpdated) FROM table1

IF NOT EXISTS(SELECT * FROM table1)
  INSERT INTO dbo.table1 ( TransactSourceID , Description, LastUpdated)
    SELECT  TransactSourceID , Description, LastUpdated
          FROM table 2
ELSE
  INSERT INTO dbo.table1 ( TransactSourceID , Description, LastUpdated)
    SELECT  TransactSourceID , Description, LastUpdated
      FROM table2 t2
    WHERE t2.LastUpdated > @maxDate

In reality, I have about 45 columns in both INSERT and SELECT column list, so it really looks hairy.

Please review and offer a better way to write this, hopefully without having to call the 45+ columns in each condiotion check. Thanks!!


 
godwineffiongAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Guy Hengel [angelIII / a3]Billing EngineerCommented:

DECLARE @maxDate datetime;
SELECT @maxDate = MAX(LastUpdated) FROM table1

  INSERT INTO dbo.table1 ( TransactSourceID , Description, LastUpdated)
    SELECT  TransactSourceID , Description, LastUpdated
      FROM table2 t2
    WHERE t2.LastUpdated > @maxDate
           OR @maxDate IS NULL
       
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
godwineffiongAuthor Commented:
Impressive! Beautiful Code !!

It works
Thanks
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server 2008

From novice to tech pro — start learning today.