Prevent users from editing other users articles

so i have restful_authentication, currently any logged in user can edit any users article by entering the correct url eg. /articles/18/edit, how do i allow only the user who created the article to edit and update it.
#articles_controller.rb
class ArticlesController < ApplicationController
	before_filter :login_required, :only =>[:new, :edit, :destroy, :create, :update]
	before_filter :tag_cloud
  

  def search
  	@search = params[:search]
  	if @search.blank?
  		redirect_to articles_url
  		else
  	@articles = Article.search params[:search], :page => params[:page], :per_page => 10
  	respond_to do |format|
  		format.html 
      format.xml  { render :xml => @articles }
  			end
  		end				
  end
  

  def index
    @page_title = "NDT Articles"
    @articles = Article.paginate :per_page => 20, :page => params[:page],
    				 :order => "created_at DESC"	 
       respond_to do |format|
      format.html
      format.rss 
    end
  end

  def show
    @page_title = "NDT Articles"
  	if params[:permalink]
    @article = Article.find_by_permalink(params[:permalink])
    raise ActiveRecord::RecordNotFound, "Page not found." if @article.nil?
    respond_to do |format|
      format.html # show.html.erb
      format.xml  { render :xml => @article }
    end
  else
    @article = Article.find(params[:id])
        respond_to do |format|
        format.html # show.html.erb
        format.xml { render :xml => @article }
        
      end
    end
  end 

  def new
    @article = Article.new
    1.upto(3) {@article.assets.build}
    respond_to do |format|
      format.html # new.html.erb
      format.xml  { render :xml => @article }
    end
  end

  def edit
    @article = Article.find(params[:id])
    if @article.assets.first.nil?
        1.upto(3) {@article.assets.build }
    end
  end  
    
    def tag_cloud 
  	    @tags = Article.tag_counts # returns all the tags used 
  	end
  
  def create
	@article = current_user.articles.build params[:article]
    respond_to do |format|
      if @article.save
        flash[:notice] = 'Article was successfully created.'
        format.html { redirect_to(@article) }
        format.xml  { render :xml => @article, :status => :created, :location => @article }
      else
        format.html { render :action => "new" }
        format.xml  { render :xml => @article.errors, :status => :unprocessable_entity }
      end
    end
  end

  def update
   params[:asset_ids] ||= []
    @article = Article.find(params[:id])
    unless params[:asset_ids].empty?
    Asset.destroy_pics(params[:id], params[:asset_ids])
  end

    respond_to do |format|
      if @article.update_attributes(params[:article])
        flash[:notice] = 'Article was successfully updated.'
        format.html { redirect_to(@article) }
        format.xml  { head :ok }
      else
        format.html { render :action => "edit" }
        format.xml  { render :xml => @article.errors, :status => :unprocessable_entity }
      end
    end
  end

  
  def destroy
    @article = Article.find(params[:id])
    @article.destroy

    respond_to do |format|
      format.html { redirect_to(articles_url) }
      format.xml  { head :ok }
    end
  end
end

Open in new window

depassionAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

cminearCommented:
First, Article needs to be associated with User, in order to represent which user is the owner of the article.  (You don't include the code from 'article.rb', so I don't know if you've done this already or not.)

If that's in place, simply add a check of the session's user_id value and compare it with the Article's owner.  See the examples below.  I've just added a redirection to the 'index' action; add the appropriate flash message.  And note that I added the check to both 'edit' and 'update'; you don't want anyone trying to skirt around the 'edit' page and directly updating an article, do you?

I don't see the page which presents the 'edit' links, but you could also add code to those templates to hide the 'edit' link to articles for which they are not the owner.

def edit
    @article = Article.find(params[:id])
    if session[:user_id] == @article.user_id
      if @article.assets.first.nil?
        1.upto(3) {@article.assets.build }
      end
    else
      redirect_to :action => 'index'
    end
  end  
    
...

  def update
   params[:asset_ids] ||= []
    @article = Article.find(params[:id])
    unless session[:user_id] == @article.user_id
      redirect_to :action => 'index'
      return
    end
    unless params[:asset_ids].empty?
    Asset.destroy_pics(params[:id], params[:asset_ids])
  end

    respond_to do |format|
      if @article.update_attributes(params[:article])
        flash[:notice] = 'Article was successfully updated.'
        format.html { redirect_to(@article) }
        format.xml  { head :ok }
      else
        format.html { render :action => "edit" }
        format.xml  { render :xml => @article.errors, :status => :unprocessable_entity }
      end
    end
  end

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
depassionAuthor Commented:
thanks, that works, i also added
 || current_user.has_role?('administrator')

to allow the admins ro still edit any article.


def edit
    @article = Article.find(params[:id])
    if session[:user_id] == @article.user_id || current_user.has_role?('administrator')
      if @article.assets.first.nil?
        1.upto(3) {@article.assets.build }
      end
    else
      redirect_to :action => 'index'
      flash[:error] = 'Your not authorized'
    end
  end  

def update
   params[:asset_ids] ||= []
    @article = Article.find(params[:id])
    unless session[:user_id] == @article.user_id || current_user.has_role?('administrator')
      redirect_to :action => 'index'
      flash[:error] = 'Your not authorized'
    end  
    unless params[:asset_ids].empty?
    Asset.destroy_pics(params[:id], params[:asset_ids])
  end

Open in new window

0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Ruby

From novice to tech pro — start learning today.