Solved

WCF OnCompleted Event not firing

Posted on 2010-08-14
5
994 Views
Last Modified: 2013-11-12
I have a class in a SL4 app that consumes the WCF data.

My problem is, that when I call this class from the Page code, the OnCompleted Event isn't firing before the collection is returned, so the returned collection is nul.

I'm using the code below to perform this operation.
PAGE CODE-------------------



ElecDayData = new GetData().GetDailyData ("12", sDate, "Electricity", "D");

ElecPrevDayData = new GetData().GetDailyData("12", sDate2, "Electricity", "D");







CLASS-------------------------



public ObservableCollection<DailyData> GetDailyData(string MeterInstance, string sDate, string Utility, string report)

        {



            Uri address = new Uri(Application.Current.Host.Source, "../Services/SilverlightService.svc");

            dbAccess = new SilverlightServiceClient("CustomBinding_SilverlightService", address.AbsoluteUri);

            dbAccess.getDailyDataCompleted += new EventHandler<getDailyDataCompletedEventArgs>(dbAccess_getDailyDataCompleted);

            dbAccess.getDailyDataAsync(sDate, MeterInstance, 0, false, false);

            return dailyData;

        }



        void dbAccess_getDailyDataCompleted(object sender, getDailyDataCompletedEventArgs e)

        {

            dailyData = new ObservableCollection<DailyData>();

            dailyData = e.Result;

        }

Open in new window

0
Comment
Question by:wint100
  • 2
  • 2
5 Comments
 
LVL 25

Expert Comment

by:apeter
Comment Utility
1. You can't return "dailyData" from ur method GetDailyData since it is an Async Call. Also enclose inside a try catch to catch any exception

2. was there any exception in the service call ? did you check in the service error log ?
0
 
LVL 1

Author Comment

by:wint100
Comment Utility
Hi,

There weren't any errors thrown, if I move everything into the page code, it all works.

I'm trying to keep things seperate though, so having a Data Access Layer for the service calls.
0
 
LVL 25

Expert Comment

by:apeter
Comment Utility
But why are the parameters for the method are different from page code and Async Call ?
0
 
LVL 5

Accepted Solution

by:
berXpert earned 500 total points
Comment Utility
Hello,

Your collection is empty because you are assigning it before the service asynch call and it is never assigned again.

What you need to do is to pass a function call back from your page code to the database service object, this way you can attach the asynch on complete event to the call back. When the event is fired it will execute the code in your page, instead of the void dbAccess_getDailyDataCompleted that is called in the database service.

See the modified code.

I hope this helps you.
PAGE CODE-------------------



	public ObservableCollection<DailyData> ElecDayData;



	...



        private void GetElecDayData()

        {

        	var dataService = new GetData().GetDailyData ("12", sDate, "Electricity", "D", OnDataRetrievedForElecDay);

        }







        void OnDataRetrievedForElecDay(ObservableCollection<DailyData> dataReturned)

        {

            ElecDayData.Clear();



            //Insert into collection to ensure property change is fired. 

            foreach( var item in dataReturned)

            {

            	ElecDayData.Add(item);

            }



            //Or You can try without the loop just assing ElecDayData = dataReturned;    sometimes it does not fire property change for me so I usually use the foreach loop

        }









CLASS-------------------------



public void GetDailyData(string MeterInstance, string sDate, string Utility, string report, Action<ObservableCollection<DailyData>> OnGetDataCompleteCallback )

        {



            Uri address = new Uri(Application.Current.Host.Source, "../Services/SilverlightService.svc");

            dbAccess = new SilverlightServiceClient("CustomBinding_SilverlightService", address.AbsoluteUri);



            // Link the asynchronous response to the caller, passing the results as arguments to the caller

            dbAccess.getDailyDataCompleted += (sender, e) => { OnGetDataCompleteCallback( e.Result ); } ;



            // Make the asynchronous call

            dbAccess.getDailyDataAsync(sDate, MeterInstance, 0, false, false);

        }

Open in new window

0
 
LVL 1

Author Comment

by:wint100
Comment Utility
I'm getting this error using he code above:


Error      70      Cannot assign void to an implicitly-typed local variable
0

Featured Post

Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

Join & Write a Comment

This article shows how to make a Windows 7 gadget that extends its U/I with a flyout panel -- a window that pops out next to the gadget.  The example gadget shows several additional techniques:  How to automatically resize a gadget or flyout panel t…
A theme is a collection of property settings that allow you to define the look of pages and controls, and then apply the look consistently across pages in an application. Themes can be made up of a set of elements: skins, style sheets, images, and o…
This is Part 3 in a 3-part series on Experts Exchange to discuss error handling in VBA code written for Excel. Part 1 of this series discussed basic error handling code using VBA. http://www.experts-exchange.com/videos/1478/Excel-Error-Handlin…
You have products, that come in variants and want to set different prices for them? Watch this micro tutorial that describes how to configure prices for Magento super attributes. Assigning simple products to configurable: We assigned simple products…

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now