Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1052
  • Last Modified:

WCF OnCompleted Event not firing

I have a class in a SL4 app that consumes the WCF data.

My problem is, that when I call this class from the Page code, the OnCompleted Event isn't firing before the collection is returned, so the returned collection is nul.

I'm using the code below to perform this operation.
PAGE CODE-------------------

ElecDayData = new GetData().GetDailyData ("12", sDate, "Electricity", "D");
ElecPrevDayData = new GetData().GetDailyData("12", sDate2, "Electricity", "D");



CLASS-------------------------

public ObservableCollection<DailyData> GetDailyData(string MeterInstance, string sDate, string Utility, string report)
        {

            Uri address = new Uri(Application.Current.Host.Source, "../Services/SilverlightService.svc");
            dbAccess = new SilverlightServiceClient("CustomBinding_SilverlightService", address.AbsoluteUri);
            dbAccess.getDailyDataCompleted += new EventHandler<getDailyDataCompletedEventArgs>(dbAccess_getDailyDataCompleted);
            dbAccess.getDailyDataAsync(sDate, MeterInstance, 0, false, false);
            return dailyData;
        }

        void dbAccess_getDailyDataCompleted(object sender, getDailyDataCompletedEventArgs e)
        {
            dailyData = new ObservableCollection<DailyData>();
            dailyData = e.Result;
        }

Open in new window

0
wint100
Asked:
wint100
  • 2
  • 2
1 Solution
 
apeterCommented:
1. You can't return "dailyData" from ur method GetDailyData since it is an Async Call. Also enclose inside a try catch to catch any exception

2. was there any exception in the service call ? did you check in the service error log ?
0
 
wint100Author Commented:
Hi,

There weren't any errors thrown, if I move everything into the page code, it all works.

I'm trying to keep things seperate though, so having a Data Access Layer for the service calls.
0
 
apeterCommented:
But why are the parameters for the method are different from page code and Async Call ?
0
 
berXpertCommented:
Hello,

Your collection is empty because you are assigning it before the service asynch call and it is never assigned again.

What you need to do is to pass a function call back from your page code to the database service object, this way you can attach the asynch on complete event to the call back. When the event is fired it will execute the code in your page, instead of the void dbAccess_getDailyDataCompleted that is called in the database service.

See the modified code.

I hope this helps you.
PAGE CODE-------------------

	public ObservableCollection<DailyData> ElecDayData;

	...

        private void GetElecDayData()
        {
        	var dataService = new GetData().GetDailyData ("12", sDate, "Electricity", "D", OnDataRetrievedForElecDay);
        }



        void OnDataRetrievedForElecDay(ObservableCollection<DailyData> dataReturned)
        {
            ElecDayData.Clear();

            //Insert into collection to ensure property change is fired. 
            foreach( var item in dataReturned)
            {
            	ElecDayData.Add(item);
            }

            //Or You can try without the loop just assing ElecDayData = dataReturned;    sometimes it does not fire property change for me so I usually use the foreach loop
        }




CLASS-------------------------

public void GetDailyData(string MeterInstance, string sDate, string Utility, string report, Action<ObservableCollection<DailyData>> OnGetDataCompleteCallback )
        {

            Uri address = new Uri(Application.Current.Host.Source, "../Services/SilverlightService.svc");
            dbAccess = new SilverlightServiceClient("CustomBinding_SilverlightService", address.AbsoluteUri);

            // Link the asynchronous response to the caller, passing the results as arguments to the caller
            dbAccess.getDailyDataCompleted += (sender, e) => { OnGetDataCompleteCallback( e.Result ); } ;

            // Make the asynchronous call
            dbAccess.getDailyDataAsync(sDate, MeterInstance, 0, false, false);
        }

Open in new window

0
 
wint100Author Commented:
I'm getting this error using he code above:


Error      70      Cannot assign void to an implicitly-typed local variable
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now