WCF OnCompleted Event not firing

I have a class in a SL4 app that consumes the WCF data.

My problem is, that when I call this class from the Page code, the OnCompleted Event isn't firing before the collection is returned, so the returned collection is nul.

I'm using the code below to perform this operation.
PAGE CODE-------------------

ElecDayData = new GetData().GetDailyData ("12", sDate, "Electricity", "D");
ElecPrevDayData = new GetData().GetDailyData("12", sDate2, "Electricity", "D");



CLASS-------------------------

public ObservableCollection<DailyData> GetDailyData(string MeterInstance, string sDate, string Utility, string report)
        {

            Uri address = new Uri(Application.Current.Host.Source, "../Services/SilverlightService.svc");
            dbAccess = new SilverlightServiceClient("CustomBinding_SilverlightService", address.AbsoluteUri);
            dbAccess.getDailyDataCompleted += new EventHandler<getDailyDataCompletedEventArgs>(dbAccess_getDailyDataCompleted);
            dbAccess.getDailyDataAsync(sDate, MeterInstance, 0, false, false);
            return dailyData;
        }

        void dbAccess_getDailyDataCompleted(object sender, getDailyDataCompletedEventArgs e)
        {
            dailyData = new ObservableCollection<DailyData>();
            dailyData = e.Result;
        }

Open in new window

LVL 1
wint100Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

apeterCommented:
1. You can't return "dailyData" from ur method GetDailyData since it is an Async Call. Also enclose inside a try catch to catch any exception

2. was there any exception in the service call ? did you check in the service error log ?
0
wint100Author Commented:
Hi,

There weren't any errors thrown, if I move everything into the page code, it all works.

I'm trying to keep things seperate though, so having a Data Access Layer for the service calls.
0
apeterCommented:
But why are the parameters for the method are different from page code and Async Call ?
0
berXpertCommented:
Hello,

Your collection is empty because you are assigning it before the service asynch call and it is never assigned again.

What you need to do is to pass a function call back from your page code to the database service object, this way you can attach the asynch on complete event to the call back. When the event is fired it will execute the code in your page, instead of the void dbAccess_getDailyDataCompleted that is called in the database service.

See the modified code.

I hope this helps you.
PAGE CODE-------------------

	public ObservableCollection<DailyData> ElecDayData;

	...

        private void GetElecDayData()
        {
        	var dataService = new GetData().GetDailyData ("12", sDate, "Electricity", "D", OnDataRetrievedForElecDay);
        }



        void OnDataRetrievedForElecDay(ObservableCollection<DailyData> dataReturned)
        {
            ElecDayData.Clear();

            //Insert into collection to ensure property change is fired. 
            foreach( var item in dataReturned)
            {
            	ElecDayData.Add(item);
            }

            //Or You can try without the loop just assing ElecDayData = dataReturned;    sometimes it does not fire property change for me so I usually use the foreach loop
        }




CLASS-------------------------

public void GetDailyData(string MeterInstance, string sDate, string Utility, string report, Action<ObservableCollection<DailyData>> OnGetDataCompleteCallback )
        {

            Uri address = new Uri(Application.Current.Host.Source, "../Services/SilverlightService.svc");
            dbAccess = new SilverlightServiceClient("CustomBinding_SilverlightService", address.AbsoluteUri);

            // Link the asynchronous response to the caller, passing the results as arguments to the caller
            dbAccess.getDailyDataCompleted += (sender, e) => { OnGetDataCompleteCallback( e.Result ); } ;

            // Make the asynchronous call
            dbAccess.getDailyDataAsync(sDate, MeterInstance, 0, false, false);
        }

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
wint100Author Commented:
I'm getting this error using he code above:


Error      70      Cannot assign void to an implicitly-typed local variable
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft Development

From novice to tech pro — start learning today.