Solved

Run Stored Update Query using VBA (from Word)

Posted on 2010-08-16
5
636 Views
Last Modified: 2012-05-10
Hi All

Please can someone tell me how to run a stored update query in an Access database from Word/VBA?  I have got so far but I am clearly missing something.  By the way, the query works correctly if I run it manually from Access.

Thank you for your help as ever.




Public Sub UpdateDetails()

Dim dbMAIN As New ADODB.Connection

Dim qQuery As New ADODB.Command



With dbMAIN

    .ConnectionString = "Provider=Microsoft.JET.OLEDB.4.0;" & _

                        "Persist Security Info = False;" & _

                        "Data Source = "C:\Source\Numbering.mdb"

    .Open

End With



With qQuery

    .ActiveConnection = dbMAIN

    .CommandType = adCmdStoredProc

    .CommandText = "qUpdateNumber"

    .Parameters.Append .CreateParameter("NewNumber", adChar, adParamInput, Len("MyNewNumber"), "MyNewNumber")

    .Parameters.Append .CreateParameter("OldNumber", adChar, adParamInput, Len("MyOldNumber"), "MyOldNumber")

    .Parameters.Append .CreateParameter("RecordDate", adChar, adParamInput, Len("MyNewDate"), "MyNewDate")

End With



qQuery.Execute



Set qQuery = Nothing

Set dbMAIN = Nothing

End Sub

Open in new window

0
Comment
Question by:MonteDelMar
  • 3
  • 2
5 Comments
 
LVL 44

Expert Comment

by:Leigh Purvis
ID: 33446085
Hi
What's the definition of qUpdateNumber?
Are you getting any specific error messages?
The one thing I notice right away is that it's astronomically likely that your parameters are operating upon fields of "Text" type in Access. Which is actually a Unicode VarChar.
So
    .Parameters.Append .CreateParameter("NewNumber", adChar, adParamInput, Len("MyNewNumber"), "MyNewNumber")
would be
    .Parameters.Append .CreateParameter("NewNumber", adWVarChar, adParamInput, Len("MyNewNumber"), "MyNewNumber")
and so forth...
Cheers.
0
 

Author Comment

by:MonteDelMar
ID: 33446276
Thank you for your response.

I have re-attached the code here to save confusion.  I had renamed some of the fields in the example I sent you as I (mistakenly) thought it would be easier.  

Do you mean the SQL for the Query?  That is

UPDATE ClientNumbers SET ClientNumbers.ArtClientNumber = [NewNumber], ClientNumbers.RenumberDate = [NewDate]
WHERE (((ClientNumbers.ArtClientNumber)=[OldNumber]));

I do not get an error message.  It appears to run but does not update the record.

I just tried changing the Type to adVarWChar but that has not made a difference.
Public Sub UpdateRecord()

Dim dbMAIN As New ADODB.Connection

Dim qQuery As New ADODB.Command



With dbMAIN

    .ConnectionString = "Provider=Microsoft.JET.OLEDB.4.0;" & _

                        "Persist Security Info = False;" & _

                        "Data Source =" & strDrive & strLocation & "Numbering.mdb"

    .Open

End With



With qQuery

    .ActiveConnection = dbMAIN

    .CommandType = adCmdStoredProc

    .CommandText = "UpdateClientDetails"

    .Parameters.Append .CreateParameter("NewNumber", adWChar, adParamInput, Len("MyNewClientNumber"), "MyNewClientNumber")

    .Parameters.Append .CreateParameter("OldNumber", adVarWChar, adParamInput, Len("BWC00002"), "BWC00002")

    .Parameters.Append .CreateParameter("RenumberDate", adVarWChar, adParamInput, Len("MyNewDate"), "MyNewDate")

End With



qQuery.Execute



Set qQuery = Nothing

Set dbMAIN = Nothing

End Sub

Open in new window

0
 
LVL 44

Accepted Solution

by:
Leigh Purvis earned 500 total points
ID: 33446640
Your parameters are in the wrong order.
Unless you've explicitly gone with named parameters in your code - then you need to be consistent with the order.
With qQuery
    .ActiveConnection = dbMAIN
    .CommandType = adCmdStoredProc
    .CommandText = "UpdateClientDetails"
    .Parameters.Append .CreateParameter("NewNumber", adVarWChar, adParamInput, Len("MyNewClientNumber"), "MyNewClientNumber")
    .Parameters.Append .CreateParameter("RenumberDate", adDate, adParamInput,  8, "MyNewDate")
    .Parameters.Append .CreateParameter("OldNumber", adVarWChar, adParamInput, Len("BWC00002"), "BWC00002")
    .Execute
End With

If you wanted to be more predictable then define your parameters in the query:

PARAMETERS  [NewNumber] Text(50), [NewDate] DateTime, [OldNumber] Text;
UPDATE ClientNumbers SET ClientNumbers.ArtClientNumber = [NewNumber], ClientNumbers.RenumberDate = [NewDate]
WHERE (((ClientNumbers.ArtClientNumber)=[OldNumber]));
That way you are being very clear about the order of parameters.
The alternative is to specify named parameters in your code.

With qQuery
    .ActiveConnection = dbMAIN
    .CommandType = adCmdStoredProc
    .CommandText = "UpdateClientDetails"
    .NamedParameters = True
    .Parameters.Append .CreateParameter("NewNumber", adVarWChar, adParamInput, 50, "MyNewClientNumber")
    .Parameters.Append .CreateParameter("NewDate", adDate, adParamInput,  8, "MyNewDate")
    .Parameters.Append .CreateParameter("OldNumber", adVarWChar, adParamInput, Len("BWC00002"), "BWC00002")
    .Execute
End With


When you can create them in any order you like.
Note that you need ADO 2.6 or newer referenced to support that.
Note that you parameter named now have to match exactly. (They didn't all do so before, but that didn't matter).
Cheers.
0
 

Author Closing Comment

by:MonteDelMar
ID: 33448270
Brilliant.  Thank you so much.
0
 
LVL 44

Expert Comment

by:Leigh Purvis
ID: 33448339
No problemo
0

Featured Post

Ransomware-A Revenue Bonanza for Service Providers

Ransomware – malware that gets on your customers’ computers, encrypts their data, and extorts a hefty ransom for the decryption keys – is a surging new threat.  The purpose of this eBook is to educate the reader about ransomware attacks.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Microsoft Word is a program we have all encountered at some point, but very few of us have dug deep into its full scope of features, let alone customized it to suit our needs. Luckily making the ribbon (aka toolbar, first introduced in Word 2007) wo…
This article describes how to use the Send to Mail Recipient command. The instructions apply generally to Office 2007 and later versions, but Microsoft® Word 2013 was used for the specific steps and figures.  What is Send to Mail Recipient? Send…
What’s inside an Access Desktop Database. Will look at the basic interface, Navigation Pane (Database Container), Tables, Queries, Forms, Report, Macro’s, and VBA code.
In Microsoft Access, learn the trick to repeating sub-report headings at the top of each page. The problem with sub-reports and headings: Add a dummy group to the sub report using the expression =1: Set the “Repeat Section” property of the dummy…

895 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now