UpdateModel will not update

Posted on 2010-08-19
Last Modified: 2013-11-08
The UpdateModel command does not update my object. The code is executed with no changes. Can you see why?
I think the problem is the name of the prefix. I have tried changing it; "Contract", "Contracts" and "contract".

The controller;

        [Authorize(Roles = "Inputter")]


        public ActionResult Edit(int contractId, FormCollection formValues)


            if (ModelState.IsValid)


                using (var db = new ITOCEntities())


                    var contract = db.Contracts.Single(x => x.ContractId == contractId);

                    string letter = contract.ContractNo_Letter;

                    UpdateModel(contract, "Contracts", formValues);

                    if (contract.ContractNo_Letter != letter)

                        contract.ContractNo_Number = Contract.AutogenerateContractNumber(contract.ContractNo_Letter);

                    var clientContact = db.Contacts.Single(x => x.ContactId == contract.ClientContactId);

                    UpdateModel(clientContact, "Contact", formValues);

                    var contractAdministrationContact = 

                        db.Contacts.Single(x => x.ContactId == contract.ContractAdministratorContactId);

                    UpdateModel(contractAdministrationContact, "Contact", formValues);



                return RedirectToAction("List");


            return View();



The ViewModel

    public class ContractViewModel


        //private ITOCEntities db = new ITOCEntities();

        public Contract contract { get; set; }

        public IList<ContractType> contractTypes { get; set; }

        public IEnumerable<SelectListItem> contractTypesSelectList




                return this.contractTypes.Select(item => new SelectListItem


                    Text = item.ContractType1,

                    Value = item.ContractTypeId.ToString()





        public Contact clientContact { get; set; }

        public Contact contractAdministratorContact { get; set; }

        public ContractViewModel()


            using (var db = new ITOCEntities())


                this.contractTypes = db.ContractTypes.ToList();

                this.clientContact = new Contact();

                this.contractAdministratorContact = new Contact();

                this.clientContact.ContactTypeId =

                    db.ContactTypes.Where(x => x.ContactType1 == "Client").SingleOrDefault().ContactTypeId;

                this.contractAdministratorContact.ContactTypeId =

                    db.ContactTypes.Where(x => x.ContactType1 == "CA").SingleOrDefault().ContactTypeId;



        public ContractViewModel(int contractId)


            using (var db = new ITOCEntities())


                this.contractTypes = db.ContractTypes.ToList();

                this.contract = db.Contracts.Where(x => x.ContractId == contractId).SingleOrDefault();

                this.clientContact = 

                    db.Contacts.Where(x => x.ContactId == this.contract.ClientContactId).SingleOrDefault();

                this.contractAdministratorContact =

                    db.Contacts.Where(x => x.ContactId == this.contract.ContractAdministratorContactId).SingleOrDefault(); 





The ViewModel reference in the view;

<%@ Page Title="" Language="C#" MasterPageFile="~/Views/Shared/Site.Master" 

    Inherits="System.Web.Mvc.ViewPage<ITOC.WebUI.Models.ContractViewModel>" %>

Open in new window

Question by:hijiki7777

Accepted Solution

thaytu888888 earned 500 total points
ID: 33477138
- UpdateModel usually doesn't working properly, may be you HTML form contains check box, combo box...etc, it only work well when the form controls are all text box, better don't use UpdateModel, try to set contract data manually

Author Closing Comment

ID: 33486491
I can't say I am happy with this solution, but as far as I can tell you are right and as a result I took your advice and got it working.

Featured Post

What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

Join & Write a Comment

In an ASP.NET application, I faced some technical problems. In this article, I list them out and show the solutions that I found.  I hope it will be useful. Problem: After closing a pop-up window, the parent page should be refreshed automaticall…
It was really hard time for me to get the understanding of Delegates in C#. I went through many websites and articles but I found them very clumsy. After going through those sites, I noted down the points in a easy way so here I am sharing that unde…
The purpose of this video is to demonstrate how to set up the WordPress backend so that each page automatically generates a Mailchimp signup form in the sidebar. This will be demonstrated using a Windows 8 PC. Tools Used are Photoshop, Awesome…
Internet Business Fax to Email Made Easy - With eFax Corporate (, you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…

747 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now