• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 615
  • Last Modified:

UpdateModel will not update

The UpdateModel command does not update my object. The code is executed with no changes. Can you see why?
I think the problem is the name of the prefix. I have tried changing it; "Contract", "Contracts" and "contract".

The controller;
        [Authorize(Roles = "Inputter")]
        public ActionResult Edit(int contractId, FormCollection formValues)
            if (ModelState.IsValid)
                using (var db = new ITOCEntities())
                    var contract = db.Contracts.Single(x => x.ContractId == contractId);
                    string letter = contract.ContractNo_Letter;

                    UpdateModel(contract, "Contracts", formValues);
                    if (contract.ContractNo_Letter != letter)
                        contract.ContractNo_Number = Contract.AutogenerateContractNumber(contract.ContractNo_Letter);

                    var clientContact = db.Contacts.Single(x => x.ContactId == contract.ClientContactId);
                    UpdateModel(clientContact, "Contact", formValues);
                    var contractAdministrationContact = 
                        db.Contacts.Single(x => x.ContactId == contract.ContractAdministratorContactId);
                    UpdateModel(contractAdministrationContact, "Contact", formValues);

                return RedirectToAction("List");
            return View();
The ViewModel

    public class ContractViewModel
        //private ITOCEntities db = new ITOCEntities();
        public Contract contract { get; set; }
        public IList<ContractType> contractTypes { get; set; }
        public IEnumerable<SelectListItem> contractTypesSelectList
                return this.contractTypes.Select(item => new SelectListItem
                    Text = item.ContractType1,
                    Value = item.ContractTypeId.ToString()

        public Contact clientContact { get; set; }
        public Contact contractAdministratorContact { get; set; }

        public ContractViewModel()
            using (var db = new ITOCEntities())
                this.contractTypes = db.ContractTypes.ToList();

                this.clientContact = new Contact();
                this.contractAdministratorContact = new Contact();
                this.clientContact.ContactTypeId =
                    db.ContactTypes.Where(x => x.ContactType1 == "Client").SingleOrDefault().ContactTypeId;
                this.contractAdministratorContact.ContactTypeId =
                    db.ContactTypes.Where(x => x.ContactType1 == "CA").SingleOrDefault().ContactTypeId;
        public ContractViewModel(int contractId)
            using (var db = new ITOCEntities())
                this.contractTypes = db.ContractTypes.ToList();
                this.contract = db.Contracts.Where(x => x.ContractId == contractId).SingleOrDefault();
                this.clientContact = 
                    db.Contacts.Where(x => x.ContactId == this.contract.ClientContactId).SingleOrDefault();
                this.contractAdministratorContact =
                    db.Contacts.Where(x => x.ContactId == this.contract.ContractAdministratorContactId).SingleOrDefault(); 
The ViewModel reference in the view;

<%@ Page Title="" Language="C#" MasterPageFile="~/Views/Shared/Site.Master" 
    Inherits="System.Web.Mvc.ViewPage<ITOC.WebUI.Models.ContractViewModel>" %>

Open in new window

1 Solution
- UpdateModel usually doesn't working properly, may be you HTML form contains check box, combo box...etc, it only work well when the form controls are all text box, better don't use UpdateModel, try to set contract data manually
hijiki7777Author Commented:
I can't say I am happy with this solution, but as far as I can tell you are right and as a result I took your advice and got it working.
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now