Executing a stored procedure while in a cursor loop

Posted on 2010-08-20
Medium Priority
Last Modified: 2012-05-10
I created a cursor to store script so that I could loop through all of the databases and list all of their tables. The looping script creation worked but I hit the 8,000 character limit barrier in SqlServer.

So rather than accumulate the entire script, I decided to execute a portion of the script while it was being generated. It did not work

Yet when I copy and paste the generated script and run it in a query panel, it works like a charm.

Attached is the code
CREATE TABLE #TableStructures(
	  [ApplicationCode] [varchar](50) NULL,
	  [RootFile] [varchar](255) NULL,
	  [DestinationTable] [varchar](255) NULL,
	  [Column Name] [varchar](128) NULL    
    SET @strSQL =''
    DECLARE curDBName CURSOR  FOR SELECT name FROM sys.databases WHERE name NOT IN('CommonPrograms','ExtractorControl','master','model','msdb','tempdb')

    OPEN curDBName
	      SET @strSQL = @strSQL + 
        'INSERT INTO #TableStructures (ApplicationCode, RootFile, DestinationTable, [Column Name])
         SELECT ExtractorControl..FilesToProcess.ApplicationCode, ExtractorControl..FilesToProcess.RootFile, ExtractorControl..FilesToProcess.DestinationTable, '+ @DBName +'..syscolumns.name AS ''Column Name'' 
         FROM (ExtractorControl..FilesToProcess INNER JOIN '+ @DBName +'..sysobjects ON ExtractorControl..FilesToProcess.DestinationTable = '+ @DBName +'..sysobjects.name) INNER JOIN '+ @DBName +'..syscolumns ON '+ @DBName +'..sysobjects.id = '+ @DBName +'..syscolumns.id
         GROUP BY ExtractorControl..FilesToProcess.ApplicationCode, ExtractorControl..FilesToProcess.RootFile, ExtractorControl..FilesToProcess.DestinationTable, '+ @DBName +'..syscolumns.name, '+ @DBName +'..sysobjects.xtype
         HAVING ('+ @DBName +'..sysobjects.xtype)= ''U''' + CHAR(10)
        EXEC @STRSQL  
        PRINT @STRSQL    
        SET @strSQL =''    
        FETCH curDBName INTO @DBName

    CLOSE curDBName
    DEALLOCATE curDBName   
    SELECT * FROM #TableStructures
    DROP TABLE #TableStructures

Open in new window

Question by:LennyGray
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 33488669
LVL 12

Accepted Solution

mcv22 earned 1000 total points
ID: 33488696
Why not try something like this:

EXEC sp_msforeachdb
	USE [?]
	IF (''?'' NOT IN (''CommonPrograms'',''ExtractorControl'',''master'',''model'',''msdb'',''tempdb'')
		INSERT #TableStructures (..)
		SELECT ...

Open in new window

LVL 69

Assisted Solution

by:Scott Pletcher
Scott Pletcher earned 1000 total points
ID: 33488817
More specifically (and hopefully more helpfully :-) ):

EXEC sp_MSforeachdb '
IF ''?'' IN (''CommonPrograms'',''ExtractorControl'',''master'',''model'',''msdb'',''tempdb'')
INSERT INTO #TableStructures (ApplicationCode, RootFile, DestinationTable, [Column Name])
SELECT ftp.ApplicationCode, ftp.RootFile, ftp.DestinationTable, sc.name AS ''Column Name''
FROM ExtractorControl..FilesToProcess ftp
INNER JOIN [?]..sysobjects so ON ftp.DestinationTable = so.name
INNER JOIN [?]..syscolumns sc ON so.id = sc.id
WHERE so.xtype = ''U''
GROUP BY ftp.ApplicationCode, ftp.RootFile, ftp.DestinationTable, sc.name
ORDER BY ftp.ApplicationCode, ftp.RootFile, ftp.DestinationTable, sc.name

Table aliases -- such as ftp, sc and so -- make code much easier to write, read and maintain.
The Eight Noble Truths of Backup and Recovery

How can IT departments tackle the challenges of a Big Data world? This white paper provides a roadmap to success and helps companies ensure that all their data is safe and secure, no matter if it resides on-premise with physical or virtual machines or in the cloud.

LVL 10

Author Closing Comment

ID: 33500381
Masterful solution, Scott!

LVL 10

Author Comment

ID: 33500512
MCV22 - I apologize for awarding you the points in error.

ScottPletcher - I also apologize to you.

I have contacted EE for assistance in order to correct this error. You both are valuable assets to EE and to me. Thank you for the unselfish sharing of your time and experience.

It is a pleasure to know that the world has people like you and that you are generous-enough to share with people like me.

You are making a difference!

Lenny Gray
LVL 10

Author Closing Comment

ID: 33500627
The two of you created an elegant solution. Thanks, again!

Featured Post

Get your Conversational Ransomware Defense e‑book

This e-book gives you an insight into the ransomware threat and reviews the fundamentals of top-notch ransomware preparedness and recovery. To help you protect yourself and your organization. The initial infection may be inevitable, so the best protection is to be fully prepared.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Everyone has problem when going to load data into Data warehouse (EDW). They all need to confirm that data quality is good but they don't no how to proceed. Microsoft has provided new task within SSIS 2008 called "Data Profiler Task". It solve th…
What if you have to shut down the entire Citrix infrastructure for hardware maintenance, software upgrades or "the unknown"? I developed this plan for "the unknown" and hope that it helps you as well. This article explains how to properly shut down …
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Viewers will learn how to use the SELECT statement in SQL and will be exposed to the many uses the SELECT statement has.
Suggested Courses

770 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question