Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Executing a stored procedure while in a cursor loop

Posted on 2010-08-20
7
692 Views
Last Modified: 2012-05-10
I created a cursor to store script so that I could loop through all of the databases and list all of their tables. The looping script creation worked but I hit the 8,000 character limit barrier in SqlServer.

So rather than accumulate the entire script, I decided to execute a portion of the script while it was being generated. It did not work

Yet when I copy and paste the generated script and run it in a query panel, it works like a charm.

Attached is the code
CREATE TABLE #TableStructures(
	  [ApplicationCode] [varchar](50) NULL,
	  [RootFile] [varchar](255) NULL,
	  [DestinationTable] [varchar](255) NULL,
	  [Column Name] [varchar](128) NULL    
    )
    
    DECLARE @DBName VARCHAR(50)
    DECLARE @STRSQL VARCHAR(8000) 
    SET @strSQL =''
    DECLARE curDBName CURSOR  FOR SELECT name FROM sys.databases WHERE name NOT IN('CommonPrograms','ExtractorControl','master','model','msdb','tempdb')

    OPEN curDBName
    FETCH NEXT FROM curDBName INTO @DBName
    WHILE @@FETCH_STATUS=0
      BEGIN
	      SET @strSQL = @strSQL + 
        'INSERT INTO #TableStructures (ApplicationCode, RootFile, DestinationTable, [Column Name])
         SELECT ExtractorControl..FilesToProcess.ApplicationCode, ExtractorControl..FilesToProcess.RootFile, ExtractorControl..FilesToProcess.DestinationTable, '+ @DBName +'..syscolumns.name AS ''Column Name'' 
         FROM (ExtractorControl..FilesToProcess INNER JOIN '+ @DBName +'..sysobjects ON ExtractorControl..FilesToProcess.DestinationTable = '+ @DBName +'..sysobjects.name) INNER JOIN '+ @DBName +'..syscolumns ON '+ @DBName +'..sysobjects.id = '+ @DBName +'..syscolumns.id
         GROUP BY ExtractorControl..FilesToProcess.ApplicationCode, ExtractorControl..FilesToProcess.RootFile, ExtractorControl..FilesToProcess.DestinationTable, '+ @DBName +'..syscolumns.name, '+ @DBName +'..sysobjects.xtype
         HAVING ('+ @DBName +'..sysobjects.xtype)= ''U''' + CHAR(10)
        EXEC @STRSQL  
        PRINT @STRSQL    
        SET @strSQL =''    
        FETCH curDBName INTO @DBName
      END

    CLOSE curDBName
    DEALLOCATE curDBName   
    
    SELECT * FROM #TableStructures
    DROP TABLE #TableStructures

Open in new window

0
Comment
Question by:LennyGray
7 Comments
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 33488669
EXEC @STRSQL  must be:EXEC (@STRSQL)
0
 
LVL 12

Accepted Solution

by:
mcv22 earned 250 total points
ID: 33488696
Why not try something like this:


EXEC sp_msforeachdb
'
	USE [?]
	IF (''?'' NOT IN (''CommonPrograms'',''ExtractorControl'',''master'',''model'',''msdb'',''tempdb'')
	BEGIN
		INSERT #TableStructures (..)
		SELECT ...
	END
'

Open in new window

0
 
LVL 69

Assisted Solution

by:Scott Pletcher
Scott Pletcher earned 250 total points
ID: 33488817
More specifically (and hopefully more helpfully :-) ):

EXEC sp_MSforeachdb '
IF ''?'' IN (''CommonPrograms'',''ExtractorControl'',''master'',''model'',''msdb'',''tempdb'')
    RETURN
INSERT INTO #TableStructures (ApplicationCode, RootFile, DestinationTable, [Column Name])
SELECT ftp.ApplicationCode, ftp.RootFile, ftp.DestinationTable, sc.name AS ''Column Name''
FROM ExtractorControl..FilesToProcess ftp
INNER JOIN [?]..sysobjects so ON ftp.DestinationTable = so.name
INNER JOIN [?]..syscolumns sc ON so.id = sc.id
WHERE so.xtype = ''U''
GROUP BY ftp.ApplicationCode, ftp.RootFile, ftp.DestinationTable, sc.name
ORDER BY ftp.ApplicationCode, ftp.RootFile, ftp.DestinationTable, sc.name
'

Table aliases -- such as ftp, sc and so -- make code much easier to write, read and maintain.
0
Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

 
LVL 10

Author Closing Comment

by:LennyGray
ID: 33500381
Masterful solution, Scott!

Thanks!
0
 
LVL 10

Author Comment

by:LennyGray
ID: 33500512
MCV22 - I apologize for awarding you the points in error.

ScottPletcher - I also apologize to you.

I have contacted EE for assistance in order to correct this error. You both are valuable assets to EE and to me. Thank you for the unselfish sharing of your time and experience.

It is a pleasure to know that the world has people like you and that you are generous-enough to share with people like me.

You are making a difference!

Lenny Gray
0
 
LVL 10

Author Closing Comment

by:LennyGray
ID: 33500627
The two of you created an elegant solution. Thanks, again!
0

Featured Post

Comprehensive Backup Solutions for Microsoft

Acronis protects the complete Microsoft technology stack: Windows Server, Windows PC, laptop and Surface data; Microsoft business applications; Microsoft Hyper-V; Azure VMs; Microsoft Windows Server 2016; Microsoft Exchange 2016 and SQL Server 2016.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

International Data Corporation (IDC) prognosticates that before the current the year gets over disbursing on IT framework products to be sent in cloud environs will be $37.1B.
The Delta outage: 650 cancelled flights, more than 1200 delayed flights, thousands of frustrated customers, tens of millions of dollars in damages – plus untold reputational damage to one of the world’s most trusted airlines. All due to a catastroph…
Familiarize people with the process of retrieving data from SQL Server using an Access pass-thru query. Microsoft Access is a very powerful client/server development tool. One of the ways that you can retrieve data from a SQL Server is by using a pa…
Using examples as well as descriptions, and references to Books Online, show the different Recovery Models available in SQL Server and explain, as well as show how full, differential and transaction log backups are performed

840 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question