Linq update in for each loop odd behaviour

Posted on 2010-08-20
Medium Priority
Last Modified: 2012-05-10
In the attached code snippet I have a for each loop on a linq result set.

Each loop updates a LocalPrice field and then calls CalculateRowTotals which is a routine in the partial class of the order details linq entity.

CalculateRowTotal simply updates the totals in the row based on the new LocalPrice.

For some reason CalculateRowTotals does not write the totals back to the database... the LocalPrice is changed without issue... whats going on?
'Do we have a current order
        Dim ordHead = (From p In db.bb_order_headers
                 Where p.AccountNo_FK = c.AccountNo And p.OrderStatus = "N").SingleOrDefault

        If Not (ordHead Is Nothing) Then
            Dim ordDetails = From p In db.bb_order_details
                     Where p.OrderHeaderId_FK = ordHead.OrderHeaderId
                     Select p
            For Each rec As bb_order_detail In ordDetails
                'For some reason 
                rec.LocalPriceDB = c.GetLocalCurrencyPrice(rec.Price)
        End If

Open in new window

Question by:WingYip
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
LVL 19

Expert Comment

by:Adam Menkes
ID: 33489890
might need to be
rec.somefield = rec.CalculateRowTotals()

Author Comment

ID: 33489916
No that wouldnt work - CalculateTotal changes a number of other fields in the row - it does not return anything - its defined in the bb_order_details partial class and therefore has access to all other values in that row instance.

Thanks anway

LVL 19

Accepted Solution

Adam Menkes earned 2000 total points
ID: 33489941
Are the changes you are making on the same objectContext?

will submit changes on the context defined by db. You might be making changes on a different context other than db
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.


Author Comment

ID: 33490964
In the code, you can see that before 'rec.LocalPriceDB' is set before 'rec.CalculateRowTotals()' is called.  The db.SubmitChanges() after the loop seems to update 'rec.LocalPriceDB' without issue.  Why would 'rec.LocalPriceDB' work and CalculateRowTotals not work when they are referecing the same object.

CalculateRowTotalsis called several times elsewhere in the app and has no probllems. However thsi is the only time a for each is used to loop through records.

LVL 19

Expert Comment

by:Adam Menkes
ID: 33491481
Did you set it breakpoint and step through it to see if it is fact updating the order details record or just variables stored at that moment in time?
LVL 16

Expert Comment

ID: 33544736
Could it be that even though your order_headers table has a primary key set your CalculateRowTotals class is missing one? According to this article LINQ ignores the update in that case (even if it has a pk you may try deleting it and re-adding it?):

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Creating an analog clock UserControl seems fairly straight forward.  It is, after all, essentially just a circle with several lines in it!  Two common approaches for rendering an analog clock typically involve either manually calculating points with…
Calculating holidays and working days is a function that is often needed yet it is not one found within the Framework. This article presents one approach to building a working-day calculator for use in .NET.
Michael from AdRem Software explains how to view the most utilized and worst performing nodes in your network, by accessing the Top Charts view in NetCrunch network monitor (https://www.adremsoft.com/). Top Charts is a view in which you can set seve…
This is my first video review of Microsoft Bookings, I will be doing a part two with a bit more information, but wanted to get this out to you folks.
Suggested Courses

765 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question