Solved

Loop to insert data into mysql table

Posted on 2010-08-22
20
299 Views
Last Modified: 2013-12-13
I have some values in post like:

$ob1=$_POST['ob1'];
$ob2=$_POST['ob2'];
$ob3=$_POST['ob3'];
----------------------upto 30-----------
$ob50=$_POST['ob50'];

first i want to add loop to make code short.

now i use code to insert these value to table:


$query1= mysql_query("INSERT INTO squestions(obno, ucode)
VALUES
('$ob1','$testcode')");


$query2= mysql_query("INSERT INTO squestions(obno, ucode)
VALUES
('$ob2','$testcode')");


$query3= mysql_query("INSERT INTO squestions(obno, ucode)
VALUES
('$ob3','$testcode')");


-------------upto 50 queries----------------


$query50= mysql_query("INSERT INTO squestions(obno, ucode)
VALUES
('$ob50','$testcode')");


Please help me ,
how to add loop for this?





0
Comment
Question by:savsoft
  • 8
  • 6
  • 3
  • +2
20 Comments
 
LVL 9

Expert Comment

by:Snarfles
ID: 33497990

for ( $counter = 1; $counter <= 50; $counter++) {
$ob=$_POST['ob$counter'];
mysql_query("INSERT INTO squestions(obno, ucode)
VALUES
('$ob','$testcode')");

}

Open in new window

0
 
LVL 9

Expert Comment

by:Snarfles
ID: 33497993
Oh hang on... 'up to 50'... means a little change to check

Also I'm making the assumption $testcode is declared further up and is always the same?
for ( $counter = 1; $counter <= 50; $counter++) {
if (isset($_POST['ob$counter'])){
$ob=$_POST['ob$counter'];
mysql_query("INSERT INTO squestions(obno, ucode)
VALUES
('$ob','$testcode')");
}
}

Open in new window

0
 
LVL 9

Expert Comment

by:Snarfles
ID: 33497997
Actually to be honest 50 post variables is a lot... you would probably be better off passing a string which you can then explode into an array... not sure if thats going to work for your code or not... but something to think about.
0
DevOps Toolchain Recommendations

Read this Gartner Research Note and discover how your IT organization can automate and optimize DevOps processes using a toolchain architecture.

 
LVL 58

Expert Comment

by:cyberkiwi
ID: 33498012
Snarfies, borrowing your code..

I tend to use the below. isset only tests if the var is set, as long as the POST var is in the form, and it is an empty string, isset still returns true.
for ( $counter = 1; $counter <= 50; $counter++)
{
  if ($_POST['ob$counter']>'')
  {
    $ob=$_POST['ob$counter'];
    mysql_query("INSERT INTO squestions(obno, ucode)
      VALUES ('$ob','$testcode')");
  }
}

Open in new window

0
 

Author Comment

by:savsoft
ID: 33498013
can you help me to make this code by using array?
0
 

Author Comment

by:savsoft
ID: 33498044
i have try above codes but it doesn't insert data...
0
 
LVL 8

Expert Comment

by:kumaranmca
ID: 33498047
I found the good solution of Mysql query...

Try my the below code...to solve your needs...


for($i=0;$i<=50;$i++){
      $values.="('".$ob.$i."','".$testcode."')";
}
echo $values;
INSERT INTO squestions(obno, ucode) VALUES $values
0
 
LVL 8

Expert Comment

by:kumaranmca
ID: 33498053
   mysql_query("INSERT INTO squestions(obno, ucode) VALUES ".$values.");
0
 
LVL 9

Expert Comment

by:Snarfles
ID: 33498059
savsoft do this

echo $query = "INSERT INTO squestions(obno, ucode)
      VALUES ('$ob','$testcode')";
echo "<br />";
mysql_query($query);

and tell me if it spits out the correct queries.
0
 
LVL 9

Expert Comment

by:Snarfles
ID: 33498061
The above 3 lines replaces the single line

mysql_query("INSERT INTO squestions(obno, ucode)
      VALUES ('$ob','$testcode')");
0
 

Author Comment

by:savsoft
ID: 33498073
yes it insert value of $testcode but leave empty value of $ob
0
 
LVL 8

Expert Comment

by:kumaranmca
ID: 33498127
to assign the value first

$ob='1';
$ob1='2';
$ob2='3';
....
$ob50='50';

then execute my code...its work
0
 

Author Comment

by:savsoft
ID: 33498143
sorry kumaranmca,

i have also tried your code its not work
0
 
LVL 9

Accepted Solution

by:
Snarfles earned 500 total points
ID: 33498172
Sorry I've given you a bit of a bum steer.

'ob'.$counter not 'ob$counter'
for ( $counter = 1; $counter <= 50; $counter++)
{
  if ($_POST['ob'.$counter]>'')
  {
    $ob=$_POST['ob'.$counter];
    mysql_query("INSERT INTO squestions(obno, ucode)
      VALUES ('$ob','$testcode')");
  }
}

Open in new window

0
 
LVL 83

Expert Comment

by:Dave Baldwin
ID: 33498183
Is the number of $_POST['ob_'] variables the same each time or different?  Do you already have the code to connect to the server and select the database?  How are you testing whether it works or not?
0
 

Author Comment

by:savsoft
ID: 33498205
yes, Snarfles
its work,
Thank you for your great help.
can you help me litle more?

if i changed above code to:

$nob=$_POST['nob'];

for ( $counter = 1; $counter <= $nob; $counter++)
{
  if ($_POST['ob'.$counter]>'')
  {
    $ob=$_POST['ob'.$counter];
    mysql_query("INSERT INTO squestions(obno, ucode)
      VALUES ('$ob','$testcode')");
  }
}

its not work if i replaced 50 $nob or '$nob'
0
 
LVL 9

Expert Comment

by:Snarfles
ID: 33498228
Hmm that should work...

Your previous page might not be passing nob correctly.
0
 
LVL 9

Expert Comment

by:Snarfles
ID: 33498233
echo $nob=$_POST['nob']; just to make sure it returns a number.
0
 
LVL 58

Expert Comment

by:cyberkiwi
ID: 33498253
$nob=(int)$_POST['nob'];
0
 

Author Closing Comment

by:savsoft
ID: 33498352
its work 100%
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

These days socially coordinated efforts have turned into a critical requirement for enterprises.
Password hashing is better than message digests or encryption, and you should be using it instead of message digests or encryption.  Find out why and how in this article, which supplements the original article on PHP Client Registration, Login, Logo…
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

840 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question