Solved

Arguments are of the wrong type SQL error

Posted on 2010-08-23
17
244 Views
Last Modified: 2012-05-10
It appears that I am going to struggle to get every SQL statement I ever write to work 1st time!  At present I have the code below but seem to get a 3001 error - "Arguments are of the wrong type, are out of acceptable range or are in conflict with another".

txtUsername variable value is "simonwait"


Dim rsPubs As ADODB.Recordset
Set rsPubs = New ADODB.Recordset
Dim enPubs As ADODB.Connection
Set enPubs = New ADODB.Connection

If txtUsername = "" Then
MsgBox ("No user selected")
Exit Sub
End If
'Now open the connection.
enPubs.Open strConn
With rsPubs
    ' Assign the Connection object.
    .ActiveConnection = enPubs
    ' Update the required records.
.Update "Users SET Removed=1 WHERE Username='" & txtUsername & "'"
 .Close
End With

dnPubs.Close
Set rsPubs = Nothing
Set enPubs = Nothing

Open in new window

0
Comment
Question by:simonwait
  • 5
  • 5
  • 4
  • +1
17 Comments
 
LVL 17

Expert Comment

by:Zhaolai
ID: 33503679
Try this:

.Update "Update Users SET Removed=1 WHERE Username='" & txtUsername & "'"

0
 
LVL 65

Expert Comment

by:rockiroads
ID: 33503728
why dont you query the record to return the one item in your recordset then edit it?

rsPubs.open("select * from users WHERE Username='" & txtUsername & "'")
rsPubs.edit
rsPubs!Removed =1
rsPubs.update

obviously the code above is simple, no validation checks etc
0
 
LVL 65

Expert Comment

by:rockiroads
ID: 33503745
validation check is simple, I shud of put it in

rsPubs.open "select * from users WHERE Username='" & txtUsername & "'"
if rsPubs.eof = false then
    rsPubs.edit
    rsPubs!Removed =1
    rsPubs.update
end if
0
 
LVL 8

Expert Comment

by:Mohit Vijay
ID: 33504171
REason of Error:
Update method will not accept string parameter as input.
0
 
LVL 1

Author Comment

by:simonwait
ID: 33504198
Zhaolai - your suggestion gives the same error.

rockiroads - your suggestion (the 2nd one) throws an error with the .edit ("Method or data member not found")
0
 
LVL 1

Author Comment

by:simonwait
ID: 33504226
VjSoft.  But the condition to be meat is a string.  Surely there is a way to handle this?
0
 
LVL 1

Author Comment

by:simonwait
ID: 33504241
Have noticed a typo.  dnPub.close on line 20 should read enPub.close
0
 
LVL 65

Expert Comment

by:rockiroads
ID: 33504263
sorry, required for dao, doh! remove that line and try again
0
Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

 
LVL 8

Expert Comment

by:Mohit Vijay
ID: 33504291
It will not accept string as input. Its expecting Fields and values, and both are optional.
0
 
LVL 8

Expert Comment

by:Mohit Vijay
ID: 33504321
0
 
LVL 17

Expert Comment

by:Zhaolai
ID: 33504793
Complete code:


Dim rsPubs As ADODB.Recordset

Set rsPubs = New ADODB.Recordset

Dim enPubs As ADODB.Connection

Set enPubs = New ADODB.Connection



If txtUsername = "" Then

MsgBox ("No user selected")

Exit Sub

End If

'Now open the connection.

enPubs.Open strConn

With rsPubs

    ' Assign the Connection object.

    .ActiveConnection = enPubs

    .CursorType = adOpenKeyset

    .LockType = adLockOptimistic

    .CursorLocation = adUseServer

    .Open "select * from users WHERE Username='" & txtUsername & "'"

    ' Update the required records.

    !Removed = 1

    .Update

    .Close

End With



dnPubs.Close

Set rsPubs = Nothing

Set enPubs = Nothing

Open in new window

0
 
LVL 17

Expert Comment

by:Zhaolai
ID: 33504820
Ah, of cause you will need validation. Just replace lines 20 and 21 with the following code:


    If Not (.EOF Or .BOF) Then

        !Removed = 1

        .Update

    End If

Open in new window

0
 
LVL 1

Author Comment

by:simonwait
ID: 33504839
rockiroads - deleted that line and now get
ERROR:
Run-time error '3251':
Current Recordset does not support updating. This may be a
limitation of the provider, or of the selected locktype.
0
 
LVL 17

Expert Comment

by:Zhaolai
ID: 33504945
That's resolved in my earlier posted code.
Just a typo in the code: dnPubs.Close should be enPubs.Close.
0
 
LVL 65

Expert Comment

by:rockiroads
ID: 33505111
try opening your recordset like this

    rsPubs.open "select * from users WHERE Username='" & txtUsername & "'", connectionObjectGoesHere, adOpenDynamic, adLockPessimistic
0
 
LVL 17

Accepted Solution

by:
Zhaolai earned 250 total points
ID: 33505123
Here is the final code (tested and worked for me):

Dim rsPubs As ADODB.Recordset

Set rsPubs = New ADODB.Recordset

Dim enPubs As ADODB.Connection

Set enPubs = New ADODB.Connection



If txtUsername = "" Then

MsgBox ("No user selected")

Exit Sub

End If

'Now open the connection.

enPubs.Open strConn

With rsPubs

    ' Assign the Connection object.

    .ActiveConnection = enPubs

    .CursorType = adOpenKeyset

    .LockType = adLockOptimistic

    .CursorLocation = adUseServer

    .Open "select * from users WHERE Username='" & txtUsername & "'"

    ' Update the required records.

    If Not (.EOF Or .BOF) Then

        !Removed = 1

        .Update

    Else

        MsgBox "Username does not exist: " & txtUsername

    End If

    .Close

End With



enPubs.Close

Set rsPubs = Nothing

Set enPubs = Nothing

Open in new window

0
 
LVL 65

Expert Comment

by:rockiroads
ID: 33505133
the default cursor is probably what is preventing you from updating the recordset. Its most likely adForwardOnly.
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Suggested Solutions

Background What I'm presenting in this article is the result of 2 conditions in my work area: We have a SQL Server production environment but no development or test environment; andWe have an MS Access front end using tables in SQL Server but we a…
JSON is being used more and more, besides XML, and you surely wanted to parse the data out into SQL instead of doing it in some Javascript. The below function in SQL Server can do the job for you, returning a quick table with the parsed data.
Using examples as well as descriptions, and references to Books Online, show the documentation available for date manipulation functions and by using a select few of these functions, show how date based data can be manipulated with these functions.
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties

757 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now