Solved

SSL vs MD5??

Posted on 2010-08-25
10
440 Views
Last Modified: 2013-12-13
I have developed a user login for a customer portal on my website (code below). I believe I have it md5 encrypted… (please correct me if I am wrong) – passwords on the database are still plain text… Is this secure?

Also – if this is so far the only security on my site do I also need an SSL certificate? What is the difference? Any help would be great. Thanks!

<?php
$username = $_POST['username'];
$password = md5($_POST['password']);

if ($username&&$password)
{
	
	$connect = mysql_connect("xxxx", "xxxx", "xxxx") or die("Connection Error!");
	mysql_select_db("xxxx") or die("Couldn't find db");
	
	$query = mysql_query("SELECT * FROM users WHERE username='$username'");
	
	$numrows = mysql_num_rows($query);
	
	if ($numrows!=0)
	{
		while ($row = mysql_fetch_assoc($query))
{
	$dbusername = $row['username'];
	$dbpassword = $row['password'];
}

if($username==$dbusername&&$password==md5($dbpassword))
{
	echo "Success!";
	
}
else
echo "Incorrect password!";

	}
	
	else
	die ("That user doesnt exist.");
	
}
else
die("Please enter username and password.");

?>

Open in new window

0
Comment
Question by:brettsky07
10 Comments
 
LVL 6

Expert Comment

by:Patrick Tallarico
Comment Utility
This may protect your password from being sniffed on a network, but it doesn't protect the username, or any data that is transmitted after authentication.
If your clients will be handling sensitive data while on this web site, I would strongly suggest SSL.
0
 
LVL 4

Expert Comment

by:darkyin87
Comment Utility
what you have you can do is. md5 your password and then save it into your database rather than saving it as plain text. In which the password in your database will be encrypted and even if people get access to the database they wont be able to crack it.

 I would recommend you to get an SSL atleast a shared SSL.
0
 

Author Comment

by:brettsky07
Comment Utility
So is that all i need for md5 encryption? or is there something i need to do to the actual database as well?
0
 
LVL 4

Expert Comment

by:darkyin87
Comment Utility
Yeas that is all you need. You can do the same thing in MYSQL side too. MYSQL also supports a variety of encrytion. refer this page:
http://dev.mysql.com/doc/refman/5.1/en/encryption-functions.html
0
 

Author Comment

by:brettsky07
Comment Utility
is it necessary to do mysql encryption as well if i get a ssl certificate? Would the certificate protect the database?
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 4

Expert Comment

by:darkyin87
Comment Utility
Security is needed in 3 areas

1) Client Side: Using Javascript

2) On the network: Done by sending encrypted data and sending data using SSL

3) Server Side: Using encrytion like md5
0
 

Author Comment

by:brettsky07
Comment Utility
Ok. Thanks for all your help!
0
 
LVL 27

Accepted Solution

by:
Tolomir earned 250 total points
Comment Utility
md5 is no encryption it is a hash function.

There is no way to get the original value from a hash value without brute force hashing all values into a hash value.

For details see: http://en.wikipedia.org/wiki/MD5

So: If you use a http connection the user sends his password unencrypted over the internet (or local lan) on the server the password is md5 hashed and compared to the md5 hash value stored in database.
Someone sniffing the network can easily extract the usename + password.

so if you send passwords over the internet ALWAYS use SSL (https://) Connections.

Tolomir
0
 
LVL 27

Assisted Solution

by:Lukasz Chmielewski
Lukasz Chmielewski earned 250 total points
Comment Utility
For what it seems you are not storing your passwords as a plain text - you are checking if the hash is equal to the hash soterd in the database...
0
 

Author Comment

by:brettsky07
Comment Utility
Thanks so much for everyone's help! I will for sure get an SSL cert.
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

SSL stands for “Secure Sockets Layer” and an SSL certificate is a critical component to keeping your website safe, secured, and compliant. Any ecommerce website must have an SSL certificate to ensure the safe handling of sensitive information like…
This article discusses how to create an extensible mechanism for linked drop downs.
The viewer will learn how to count occurrences of each item in an array.
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now