Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 425
  • Last Modified:

DOS DIR returns just one file

Hi I ma trying to create a little change control update using a dos batch file.

I copy a file from a remote location to a local location if it is newer than the local version.
I then want to run that program using Access.

All works fine except if there is more than 1 file that matches my mask character in the DIR command.

What I would like the DIR to do is to stop looking when it finds the first file.
I have sorted the files so that the newest is at the top

Any ideas. Here's my script. My variable %concat% currently has 2 files in it which caused the start command to obviously fail


....................................
set copycmd=/y
xcopy "Q:\Quality System Software Client\*.mdb" "C:\Selection Software\" /d


for /f "delims=" %%a in ('dir "C:\Selection Software\BW Quality*" /b /s' /o-D) do (
       call set concat=%%concat%%%%a
                        )

Start "C:\Program Files\Microsoft Office\OFFICE11 \MSACCESS.EXE" "%concat%"
............................................................

0
EWHTLC
Asked:
EWHTLC
  • 4
  • 2
  • 2
2 Solutions
 
Bill PrewCommented:
This should work, it will exit the FOR loop after the first file name is assigned to concat:

set copycmd=/y
xcopy "Q:\Quality System Software Client\*.mdb" "C:\Selection Software\" /d
for /f "delims=" %%a in ('dir "C:\Selection Software\BW Quality*" /b /s' /o-D) do (
  set concat=%%a
  goto :ExitFor
)
:ExitFor
Start "C:\Program Files\Microsoft Office\OFFICE11 \MSACCESS.EXE" "%concat%"

~bp
0
 
Ben Personick (Previously QCubed)Lead Network EngineerCommented:
if it doesn't work, try this code instead (BP I assume you say 'should because you didn't test and are not 100%),

SET "copycmd=/y"
XCopy "Q:\Quality System Software Client\*.mdb" "C:\Selection Software\" /d
FOR /F "delims=" %%a in ('DIR "C:\Selection Software\BW Quality*" /B /S /A:-D /O:D) DO SET "concat=%%a"
START "C:\Program Files\Microsoft Office\OFFICE11 \MSACCESS.EXE" "C:\Selection Software\%concat%"

Open in new window

0
 
Bill PrewCommented:
Hello Q,

For the original poster, just to clarify, there is a subtle difference between the two approaches that is important to understand.  Either should work, but since the code difference if fairly small, I wanted to point it out.

In the first solution that I posted, I stuck with the sort order you were using, and as a result we want to get just the FIRST file and process that in Access.  As a result, on the first time through the FOR loop, we save the filename to a variable, and then exit the FOR loop.

In the second solution, rather than exit the FOR loop on the first file, we actually let ALL files loop through the FOR, and since we re assign the concat variable for each file name, it will have the value of the LAST file processed by the for loop.  As a result, Q reversed the sort order so that the file you wanted is now the last file in the list, not the first.

Either approach is valid, and you'll see both approaches used.  The first approach is a bit more efficient if you have a large number of files that you loop over, since it only processes the first one.  But it does use a goto, not highly desirable in most languages, and it jumps out of a FOR loop, again not best practice but acceptable.  Unfortunately there is no other way to gracefully exit the FOR loop before it cycles through all files.  In the second approach the code is a bit simpler, but you do the SET for each file processed until you get to the last one, so that consumes a bit of extra processing.

Hope that helps you understand the options better, let us know your questions.

~bp
0
Get your problem seen by more experts

Be seen. Boost your question’s priority for more expert views and faster solutions

 
Ben Personick (Previously QCubed)Lead Network EngineerCommented:
Great Summarization of the two Techniques Bill!  =)
0
 
EWHTLCAuthor Commented:
A slight tweak to the first one.
Works an absolute treat.
I will save both versions in my tips folder.
Really useful
0
 
Ben Personick (Previously QCubed)Lead Network EngineerCommented:
Great!  Glad we could be of help!

~Q
0
 
EWHTLCAuthor Commented:
Thanks guys.
Extremely useful
0
 
Ben Personick (Previously QCubed)Lead Network EngineerCommented:
thanks vMuch for the points & the praise =)
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 4
  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now