DOS DIR returns just one file

Posted on 2010-08-26
Last Modified: 2013-11-09
Hi I ma trying to create a little change control update using a dos batch file.

I copy a file from a remote location to a local location if it is newer than the local version.
I then want to run that program using Access.

All works fine except if there is more than 1 file that matches my mask character in the DIR command.

What I would like the DIR to do is to stop looking when it finds the first file.
I have sorted the files so that the newest is at the top

Any ideas. Here's my script. My variable %concat% currently has 2 files in it which caused the start command to obviously fail

set copycmd=/y
xcopy "Q:\Quality System Software Client\*.mdb" "C:\Selection Software\" /d

for /f "delims=" %%a in ('dir "C:\Selection Software\BW Quality*" /b /s' /o-D) do (
       call set concat=%%concat%%%%a

Start "C:\Program Files\Microsoft Office\OFFICE11 \MSACCESS.EXE" "%concat%"

Question by:EWHTLC
  • 4
  • 2
  • 2
LVL 54

Accepted Solution

Bill Prew earned 350 total points
ID: 33533667
This should work, it will exit the FOR loop after the first file name is assigned to concat:

set copycmd=/y
xcopy "Q:\Quality System Software Client\*.mdb" "C:\Selection Software\" /d
for /f "delims=" %%a in ('dir "C:\Selection Software\BW Quality*" /b /s' /o-D) do (
  set concat=%%a
  goto :ExitFor
Start "C:\Program Files\Microsoft Office\OFFICE11 \MSACCESS.EXE" "%concat%"

LVL 11

Assisted Solution

by:Ben Personick (Previously QCubed)
Ben Personick (Previously QCubed) earned 150 total points
ID: 33534253
if it doesn't work, try this code instead (BP I assume you say 'should because you didn't test and are not 100%),

SET "copycmd=/y"
XCopy "Q:\Quality System Software Client\*.mdb" "C:\Selection Software\" /d
FOR /F "delims=" %%a in ('DIR "C:\Selection Software\BW Quality*" /B /S /A:-D /O:D) DO SET "concat=%%a"
START "C:\Program Files\Microsoft Office\OFFICE11 \MSACCESS.EXE" "C:\Selection Software\%concat%"

Open in new window

LVL 54

Expert Comment

by:Bill Prew
ID: 33534814
Hello Q,

For the original poster, just to clarify, there is a subtle difference between the two approaches that is important to understand.  Either should work, but since the code difference if fairly small, I wanted to point it out.

In the first solution that I posted, I stuck with the sort order you were using, and as a result we want to get just the FIRST file and process that in Access.  As a result, on the first time through the FOR loop, we save the filename to a variable, and then exit the FOR loop.

In the second solution, rather than exit the FOR loop on the first file, we actually let ALL files loop through the FOR, and since we re assign the concat variable for each file name, it will have the value of the LAST file processed by the for loop.  As a result, Q reversed the sort order so that the file you wanted is now the last file in the list, not the first.

Either approach is valid, and you'll see both approaches used.  The first approach is a bit more efficient if you have a large number of files that you loop over, since it only processes the first one.  But it does use a goto, not highly desirable in most languages, and it jumps out of a FOR loop, again not best practice but acceptable.  Unfortunately there is no other way to gracefully exit the FOR loop before it cycles through all files.  In the second approach the code is a bit simpler, but you do the SET for each file processed until you get to the last one, so that consumes a bit of extra processing.

Hope that helps you understand the options better, let us know your questions.

Forrester Webinar: xMatters Delivers 261% ROI

Guest speaker Dean Davison, Forrester Principal Consultant, explains how a Fortune 500 communication company using xMatters found these results: Achieved a 261% ROI, Experienced $753,280 in net present value benefits over 3 years and Reduced MTTR by 91% for tier 1 incidents.

LVL 11
ID: 33534900
Great Summarization of the two Techniques Bill!  =)

Author Comment

ID: 33539593
A slight tweak to the first one.
Works an absolute treat.
I will save both versions in my tips folder.
Really useful
LVL 11
ID: 33541435
Great!  Glad we could be of help!


Author Closing Comment

ID: 33562772
Thanks guys.
Extremely useful
LVL 11
ID: 33562836
thanks vMuch for the points & the praise =)

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction This tutorial will give you a fast look what you can do with WhizBase. I expect you already know how to work with HTML at least, and that you understand the basics of the internet and how the internet works. WhizBase is a server-s…
Recently I have been answering a lot of questions like this in IT forums that I frequent. The question posed is usually something along the lines of "We have software X installed and need to uninstall it for reason Y" or some other variant of the sa…
Learn the basics of strings in Python: declaration, operations, indices, and slicing. Strings are declared with quotations; for example: s = "string": Strings are immutable.: Strings may be concatenated or multiplied using the addition and multiplic…
Learn the basics of if, else, and elif statements in Python 2.7. Use "if" statements to test a specified condition.: The structure of an if statement is as follows: (CODE) Use "else" statements to allow the execution of an alternative, if the …

730 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question