clone of an inherited generic list

I have a class "NavigationElement", where I implemented a clone method.

Then I have a generic List that inherits from a list of this objects (NavigationElement)

public class NavigationElementsList<NavigationElement> : List<NavigationElement>, ICloneable
...
in this list I also implemented the
   public Object Clone()
        {
            return this.MemberwiseClone();
        }

now I need to call the FindAll method in an istance of this NavigationElementsList<NavigationElement>, but this is not possible because the returned type is not the same as the generic List<T>.
I need to have a deep copy of the list because I'm going to change the values of the properties and this will cause a change in the referenced items in  the original list<T> that I want to avoid.

This also won't work:
 public NavigationElementsList<T> FindAll(Predicate<T> match)
        {
            return base.FindAll(match);
        }

Any suggestions?
LorenzoBAsked:
Who is Participating?
 
Gururaj BadamCommented:
In the first place why do you want to inherit from List<T>. I suggest you to write an extension method instead to add your clone method

say like

public T Clone<T>(this List<T> _list)
        {
            return _list.MemberwiseClone(); // Or something like this
        }
0
 
LorenzoBAuthor Commented:
Actually resolved in this way (maybe useful for some other).
 public NavigationElementsList<NavigationElement> FindAll(Predicate<NavigationElement> match)
        {
            NavigationElementsList<NavigationElement> navCopyOfList = new NavigationElementsList<NavigationElement>();
            navCopyOfList.AddRange(base.FindAll(match));
            return navCopyOfList;
        }
0
 
LorenzoBAuthor Commented:
The problem is in the FindAll method and the type that it returns.
Thank you anyway
0
 
LorenzoBAuthor Commented:
To answer to your question, I needed to Inherit from a List<T> because I want to have the FindAll and the Clone (DeepCopy not Shallow).

Your suggestion was indeed helpful.

MemberwiseClone() cannot be called by an extension method of a generics list because it is a private member.
So I did a sort of implementation of the MemberwiseClone.
In the following extract of code are the Extension methods. Maybe could be better written...
The class NavigationElement inherits from ICloneable and implements the Clone() method.

In this way I avoid to create a new Class that inherits from List<NavigationElement>, because the implementation of the Extension Methods.

Thank You
 public static class ListExtensions
        {
            public static object Clone<T>(this List<NavigationElement> list)
            {
                return list.MemberwiseClone<T>();               
            }

            public static List<NavigationElement> MemberwiseClone<T>(this List<NavigationElement> list)
            {
                List<NavigationElement> newList = new List<NavigationElement>();
                foreach (NavigationElement navElem in list)
                {
                    newList.Add((NavigationElement)navElem.Clone());
                }
                return newList; 
            }
        }

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.