• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 629
  • Last Modified:

Using COALESCE in stored procedure for searching DB records.

I have an application that creates a query string that I use to search a SQL SERVER 2008 EXPRESS database.  Most of the code is to create the WHERE clause of the query.

With much help from some of the experts here I have created a stored procedure that takes the string of the WHERE clause as an input and returns the desired results.  While doing this I stumbled across the function COALESCE.

From my understanding I should be able to produce a SP (using COALESCE or ISNULL) that will create the entire search query for me with relatively little code.  Removing the need for most of the code that I am currently using in my app.

Below is the SQL code using COALESCE that I am trying to get to work.  My test results for this code along with the errors are attached (testresults.xls).

Basically I am trying to create a stored procedure that will take the text entered in text and or listboxes and return the records based on that search.  Much like the advance search of EE.

Thank you for any and all help.


USE [Data]
GO
/****** Object:  StoredProcedure [dbo].[usp_SearchResults2]    Script Date: 09/01/2010 22:40:27 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO

-- =============================================
-- Author:		
-- Create date: 8/29/2010
-- Description:	
-- =============================================
ALTER PROCEDURE [dbo].[usp_SearchResults2] 
	-- Add the parameters for the stored procedure here
	@Item nvarchar(19),
	@ProdLine nvarchar(50),
	@Document_Type nvarchar(50)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;

    --Insert statements for procedure here
    IF (RIGHT(@Item,2)='xx') 
		BEGIN
			SET @Item = SUBSTRING(@Item,0,6)
		END

	SELECT Item_Number,
		   ProdLine,
		   Document_Type
	FROM   tblItem
	WHERE		   
		   Item_Number LIKE '%' + COALESCE(@Item,Item_Number) + '%'  AND
		   ProdLine LIKE '%' + COALESCE(@ProdLine,ProdLine) + '%' AND
		   Document_Type = COALESCE(@Document_Type,Document_Type)
END

Open in new window

testresults.xls
0
NevSoFly
Asked:
NevSoFly
2 Solutions
 
patriktCommented:
I dont't know what your expected results are but I can describe COALESCE function.

It will return first not null argument. But you are not allowing @Item to be optional so your procedure must be called wth this parameter. If you want @Item or other parameter to be optional add default value:
PROCEDURE [dbo].[usp_SearchResults2]
      -- Add the parameters for the stored procedure here
      @Item nvarchar(19)=NULL,
      @ProdLine nvarchar(50),
      @Document_Type nvarchar(50)

In this case if you will not pass @Item it will be assigned NULL and
COALESCE(@Item,Item_Number) will be evaluated as Item_Number.

0
 
pivarCommented:
Hi,

Is it this you're looking for?

      SELECT Item_Number,
               ProdLine,
               Document_Type
      FROM   tblItem
      WHERE (@Item IS NULL OR Item_Number LIKE '%' + @Item + '%')  
             AND (@ProdLine IS NULL OR ProdLine LIKE '%' + @ProdLine + '%')
             AND (@Document_Type IS NULL OR Document_Type = Document_Type)

/peter
0
 
rushShahCommented:
hi, try with brackets,

USE [Data]
GO
/****** Object:  StoredProcedure [dbo].[usp_SearchResults2]    Script Date: 09/01/2010 22:40:27 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO

-- =============================================
-- Author:		
-- Create date: 8/29/2010
-- Description:	
-- =============================================
ALTER PROCEDURE [dbo].[usp_SearchResults2] 
	-- Add the parameters for the stored procedure here
	@Item nvarchar(19),
	@ProdLine nvarchar(50),
	@Document_Type nvarchar(50)
AS
BEGIN
	-- SET NOCOUNT ON added to prevent extra result sets from
	-- interfering with SELECT statements.
	SET NOCOUNT ON;

    --Insert statements for procedure here
    IF (RIGHT(@Item,2)='xx') 
		BEGIN
			SET @Item = SUBSTRING(@Item,0,6)
		END

	SELECT Item_Number,
		   ProdLine,
		   Document_Type
	FROM   tblItem
	WHERE		   
		   (Item_Number LIKE '%' + COALESCE(@Item,Item_Number) + '%')  AND
		   (ProdLine LIKE '%' + COALESCE(@ProdLine,ProdLine) + '%') AND
		   (Document_Type = COALESCE(@Document_Type,Document_Type))
END

Open in new window

0
 
NevSoFlyAuthor Commented:
pivar your code did the trick and along with patrikt's suggestion of setting the default refferance to NULL everything turned out fine and saved me several dozen lines of VB code.

thanks
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: Python 3 Fundamentals

This course will teach participants about installing and configuring Python, syntax, importing, statements, types, strings, booleans, files, lists, tuples, comprehensions, functions, and classes.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now