Valleriani
asked on
C++ "FIND_IF" & VECTORS
I have the following snippet below for a vector class. It's called "DDClass" Mainly, since it will handle my damage done on ships.
I get the following error:
2>..\sf\frontier\src\portc pp\Designe dClass.cpp (1669): error C3867: 'DesignedClass::FindCondit ion': function call missing argument list; use '&DesignedClass::FindCondi tion' to create a pointer to member
in my designedclass.h file:
Vector<DDClass, short> ddamage;
template <int T> bool FindCondition(const DDClass& damdone) { return damdone.shipid == T; }
and in designedclass.cpp file:
if (Type() == ship) {
if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))
g_logFile << "FOUND" << endl;
else {
g_logFile << "NOT FOUND" << endl;
}
}
And the main DDClass.h that hanldes the vector class (that is attached)
DDClass.h
#ifndef DDCLASS_H
#define DDCLASS_H
class DDClass {
public:
int shipid;
long damdone;
long cframe;
DDClass(){}
DDClass(int sid, long dd, long f)
: shipid(sid), damdone(dd), cframe(f){}
void print()const{
cout << shipid << ", " << damdone << " on frame: " << cframe << "\n";
}
};
#endif
'15' is the shipid I want it to find, as a test. Mainly I think this is becuase of my custom vector class, but I am not sure how I can solve it/don't know what it wants me to exactly call. Does anyone have any clues? Mainly I want to search, and if not found, add it.
Thanks!
I get the following error:
2>..\sf\frontier\src\portc
in my designedclass.h file:
Vector<DDClass, short> ddamage;
template <int T> bool FindCondition(const DDClass& damdone) { return damdone.shipid == T; }
and in designedclass.cpp file:
if (Type() == ship) {
if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))
g_logFile << "FOUND" << endl;
else {
g_logFile << "NOT FOUND" << endl;
}
}
And the main DDClass.h that hanldes the vector class (that is attached)
DDClass.h
#ifndef DDCLASS_H
#define DDCLASS_H
class DDClass {
public:
int shipid;
long damdone;
long cframe;
DDClass(){}
DDClass(int sid, long dd, long f)
: shipid(sid), damdone(dd), cframe(f){}
void print()const{
cout << shipid << ", " << damdone << " on frame: " << cframe << "\n";
}
};
#endif
'15' is the shipid I want it to find, as a test. Mainly I think this is becuase of my custom vector class, but I am not sure how I can solve it/don't know what it wants me to exactly call. Does anyone have any clues? Mainly I want to search, and if not found, add it.
Thanks!
#include <vector>
#include <ostream>
using namespace std;
template<class T, class I> class Vector {
private:
std::vector<T> vec;
std::ostream* err;
public:
Vector(void) {
err = &g_logFile;
}
Vector(I i, ostream* o =&g_logFile)
: vec(i, T()), err(o)
{
}
~Vector(){
vec.clear();
}
int initializeWith(I i, ostream* o =&g_logFile) {
vec.clear();
vec.resize(i, T());
err = o;
return i == vec.size()? 0 : -1;
}
void _initialize() {
vec.clear();
err = &g_logFile;
}
void initialize() {
vec.clear();
err = &g_logFile;
}
void destroy(){
vec.clear();
vec.swap( vec );
}
Vector<T,I>& operator=(const Vector<T,I>& a) {
if (this != &a) {
vec = a.vec;
err = a.err;
}
return *this;
}
void extendBy(I i)
{
vec.resize(vec.size()+i, T()); //No return with resize.
}
void add(T& t) {
extendBy(1);
vec[vec.size()-1] = t;
}
T* begin() {
return vec.begin();
}
T* end() {
return vec.end();
}
inline I size() const{
return vec.size();
}
etc..
BTW: unless DesignedClass::FindConditi on is static member you can't use it as a predicate for find_if
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
Problem is unfort the game used to use a array.h class, which was a easy swap to vector.h without messing with alot right now. There is 'alot' of coding to change, even though it would be best, mainly there hasn't been issues (crashes/etc) using it. I actually just added the begin/end recently, but I misjudged it by mistake, and thanks for pointing that out!
Though I'd like to eventually fix it properly, but this is one of those things I don't like to play with just yet because I haven't played with them before.
And thank you for the header tip. I'm going to go check it out now and I'll let you know.
Though I'd like to eventually fix it properly, but this is one of those things I don't like to play with just yet because I haven't played with them before.
And thank you for the header tip. I'm going to go check it out now and I'll let you know.
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
Removing it from the header and the begin/end fix seemed to work well. Tested and working, thanks!
Welcome :)
if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))
to this...
if (find_if(ddamage.begin(), ddamage.end(), &DesignedClass::FindCondit