Solved

C++ "FIND_IF" & VECTORS

Posted on 2010-09-02
7
498 Views
Last Modified: 2012-05-10
I have the following snippet below for a vector class. It's called "DDClass" Mainly, since it will handle my damage done on ships.

I get the following error:
2>..\sf\frontier\src\portcpp\DesignedClass.cpp(1669): error C3867: 'DesignedClass::FindCondition': function call missing argument list; use '&DesignedClass::FindCondition' to create a pointer to member


in my designedclass.h file:

      Vector<DDClass, short> ddamage;
      template <int T> bool FindCondition(const DDClass& damdone) { return damdone.shipid == T; }


and in designedclass.cpp file:

      if (Type() == ship) {
            if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))
                  g_logFile << "FOUND" << endl;
            else {
                  g_logFile << "NOT FOUND" << endl;
            }
      }

And the main DDClass.h that hanldes the vector class (that is attached)
DDClass.h

#ifndef DDCLASS_H
#define DDCLASS_H

class DDClass {
public:
    int shipid;
    long damdone;
      long cframe;
      DDClass(){}
      DDClass(int sid, long dd, long f)
            : shipid(sid), damdone(dd), cframe(f){}
      void print()const{
            cout << shipid << ", " << damdone << " on frame: " << cframe << "\n";
      }
};

#endif

'15' is the shipid I want it to find, as a test. Mainly I think this is becuase of my custom vector class, but I am not sure how I can solve it/don't know what it wants me to exactly call. Does anyone have any clues? Mainly I want to search, and if not found, add it.

Thanks!
#include <vector>

#include <ostream>

using namespace std;



template<class T, class I> class Vector {

private:      

	std::vector<T> vec;

	std::ostream* err;

public:

	  Vector(void) {

            err = &g_logFile;

      }



      Vector(I i, ostream* o =&g_logFile) 

                     : vec(i, T()), err(o)

                {

      }



      ~Vector(){

            vec.clear();

      }



      int initializeWith(I i, ostream* o =&g_logFile) {

            vec.clear();

            vec.resize(i, T());

            err = o;

            return i == vec.size()? 0 : -1;

      }



      void _initialize() {

            vec.clear();

            err = &g_logFile;

      }



      void initialize() {

            vec.clear();

            err = &g_logFile;

      }



      void destroy(){

            vec.clear();

			vec.swap( vec );

	  }



	  Vector<T,I>& operator=(const Vector<T,I>& a) {

            if (this != &a) {

                  vec = a.vec;

                  err = a.err;

            }

            return *this;

      }



	void extendBy(I i) 

	{

		vec.resize(vec.size()+i, T()); //No return with resize.

	}



	void add(T& t) {

		extendBy(1);

		vec[vec.size()-1] = t;

	}



	T* begin() {

		return vec.begin();

	}



	T* end() {

		return vec.end();

	}



	inline I size() const{

		return vec.size();

	}



etc..

Open in new window

0
Comment
Question by:Valleriani
  • 5
  • 2
7 Comments
 
LVL 40

Expert Comment

by:evilrix
Comment Utility
Try changing this...

 if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))


to this...

 if (find_if(ddamage.begin(), ddamage.end(), &DesignedClass::FindCondition<15>))
0
 
LVL 40

Expert Comment

by:evilrix
Comment Utility
BTW: unless DesignedClass::FindCondition is static member you can't use it as a predicate for find_if
0
 
LVL 40

Accepted Solution

by:
evilrix earned 500 total points
Comment Utility
Something else, having a using namespace in a header is a problem waiting to happen. Every translation unit that includes that header will be polluted with namespace you use. You should avoid doing this.


The types your begin and end return are wrong, they should be iterators and not pointers.

Honestly, I would avoid having this vector adaptor class... it's just a layer of abstraction that is likely to become a maintenance overhead.
0
Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

 
LVL 7

Author Comment

by:Valleriani
Comment Utility
Problem is unfort the game used to use a array.h class, which was a easy swap  to vector.h without messing with alot right now. There is 'alot' of coding to change, even though it would be best, mainly there hasn't been issues (crashes/etc) using it. I actually just added the begin/end recently, but I misjudged it by mistake, and thanks for pointing that out!

Though I'd like to eventually fix it properly, but this is one of those things I don't like to play with just yet because I haven't played with them before.

And thank you for the header tip. I'm going to go check it out now and I'll let you know.
0
 
LVL 40

Assisted Solution

by:evilrix
evilrix earned 500 total points
Comment Utility
>> I actually just added the begin/end recently, but I misjudged it by mistake, and thanks for pointing that out!

If you need to maintain pointer semantics you could do this...
       T* begin() {

                return &vec[0];

        }



        T* end() {

                return &vec[vec.size()];

        }

Open in new window

0
 
LVL 7

Author Closing Comment

by:Valleriani
Comment Utility
Removing it from the header and the begin/end fix seemed to work well. Tested and working, thanks!
0
 
LVL 40

Expert Comment

by:evilrix
Comment Utility
Welcome :)
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Go is an acronym of golang, is a programming language developed Google in 2007. Go is a new language that is mostly in the C family, with significant input from Pascal/Modula/Oberon family. Hence Go arisen as low-level language with fast compilation…
Does the idea of dealing with bits scare or confuse you? Does it seem like a waste of time in an age where we all have terabytes of storage? If so, you're missing out on one of the core tools in every professional programmer's toolbox. Learn how to …
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…
Viewers will learn how to properly install Eclipse with the necessary JDK, and will take a look at an introductory Java program. Download Eclipse installation zip file: Extract files from zip file: Download and install JDK 8: Open Eclipse and …

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now