?
Solved

C++ "FIND_IF" & VECTORS

Posted on 2010-09-02
7
Medium Priority
?
552 Views
Last Modified: 2012-05-10
I have the following snippet below for a vector class. It's called "DDClass" Mainly, since it will handle my damage done on ships.

I get the following error:
2>..\sf\frontier\src\portcpp\DesignedClass.cpp(1669): error C3867: 'DesignedClass::FindCondition': function call missing argument list; use '&DesignedClass::FindCondition' to create a pointer to member


in my designedclass.h file:

      Vector<DDClass, short> ddamage;
      template <int T> bool FindCondition(const DDClass& damdone) { return damdone.shipid == T; }


and in designedclass.cpp file:

      if (Type() == ship) {
            if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))
                  g_logFile << "FOUND" << endl;
            else {
                  g_logFile << "NOT FOUND" << endl;
            }
      }

And the main DDClass.h that hanldes the vector class (that is attached)
DDClass.h

#ifndef DDCLASS_H
#define DDCLASS_H

class DDClass {
public:
    int shipid;
    long damdone;
      long cframe;
      DDClass(){}
      DDClass(int sid, long dd, long f)
            : shipid(sid), damdone(dd), cframe(f){}
      void print()const{
            cout << shipid << ", " << damdone << " on frame: " << cframe << "\n";
      }
};

#endif

'15' is the shipid I want it to find, as a test. Mainly I think this is becuase of my custom vector class, but I am not sure how I can solve it/don't know what it wants me to exactly call. Does anyone have any clues? Mainly I want to search, and if not found, add it.

Thanks!
#include <vector>
#include <ostream>
using namespace std;

template<class T, class I> class Vector {
private:      
	std::vector<T> vec;
	std::ostream* err;
public:
	  Vector(void) {
            err = &g_logFile;
      }

      Vector(I i, ostream* o =&g_logFile) 
                     : vec(i, T()), err(o)
                {
      }

      ~Vector(){
            vec.clear();
      }

      int initializeWith(I i, ostream* o =&g_logFile) {
            vec.clear();
            vec.resize(i, T());
            err = o;
            return i == vec.size()? 0 : -1;
      }

      void _initialize() {
            vec.clear();
            err = &g_logFile;
      }

      void initialize() {
            vec.clear();
            err = &g_logFile;
      }

      void destroy(){
            vec.clear();
			vec.swap( vec );
	  }

	  Vector<T,I>& operator=(const Vector<T,I>& a) {
            if (this != &a) {
                  vec = a.vec;
                  err = a.err;
            }
            return *this;
      }

	void extendBy(I i) 
	{
		vec.resize(vec.size()+i, T()); //No return with resize.
	}

	void add(T& t) {
		extendBy(1);
		vec[vec.size()-1] = t;
	}

	T* begin() {
		return vec.begin();
	}

	T* end() {
		return vec.end();
	}

	inline I size() const{
		return vec.size();
	}

etc..

Open in new window

0
Comment
Question by:Valleriani
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 2
7 Comments
 
LVL 40

Expert Comment

by:evilrix
ID: 33588283
Try changing this...

 if (find_if(ddamage.begin(), ddamage.end(), FindCondition<15>))


to this...

 if (find_if(ddamage.begin(), ddamage.end(), &DesignedClass::FindCondition<15>))
0
 
LVL 40

Expert Comment

by:evilrix
ID: 33588298
BTW: unless DesignedClass::FindCondition is static member you can't use it as a predicate for find_if
0
 
LVL 40

Accepted Solution

by:
evilrix earned 2000 total points
ID: 33588348
Something else, having a using namespace in a header is a problem waiting to happen. Every translation unit that includes that header will be polluted with namespace you use. You should avoid doing this.


The types your begin and end return are wrong, they should be iterators and not pointers.

Honestly, I would avoid having this vector adaptor class... it's just a layer of abstraction that is likely to become a maintenance overhead.
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
LVL 7

Author Comment

by:Valleriani
ID: 33588725
Problem is unfort the game used to use a array.h class, which was a easy swap  to vector.h without messing with alot right now. There is 'alot' of coding to change, even though it would be best, mainly there hasn't been issues (crashes/etc) using it. I actually just added the begin/end recently, but I misjudged it by mistake, and thanks for pointing that out!

Though I'd like to eventually fix it properly, but this is one of those things I don't like to play with just yet because I haven't played with them before.

And thank you for the header tip. I'm going to go check it out now and I'll let you know.
0
 
LVL 40

Assisted Solution

by:evilrix
evilrix earned 2000 total points
ID: 33588784
>> I actually just added the begin/end recently, but I misjudged it by mistake, and thanks for pointing that out!

If you need to maintain pointer semantics you could do this...
       T* begin() {
                return &vec[0];
        }

        T* end() {
                return &vec[vec.size()];
        }

Open in new window

0
 
LVL 7

Author Closing Comment

by:Valleriani
ID: 33589083
Removing it from the header and the begin/end fix seemed to work well. Tested and working, thanks!
0
 
LVL 40

Expert Comment

by:evilrix
ID: 33589102
Welcome :)
0

Featured Post

Survive A High-Traffic Event with Percona

Your application or website rely on your database to deliver information about products and services to your customers. You can’t afford to have your database lose performance, lose availability or become unresponsive – even for just a few minutes.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In this post we will learn how to make Android Gesture Tutorial and give different functionality whenever a user Touch or Scroll android screen.
Q&A with Course Creator, Mark Lassoff, on the importance of HTML5 in the career of a modern-day developer.
Viewers will learn how to properly install Eclipse with the necessary JDK, and will take a look at an introductory Java program. Download Eclipse installation zip file: Extract files from zip file: Download and install JDK 8: Open Eclipse and …
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

649 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question