Solved

Determine if a string is all numerals

Posted on 2010-09-03
15
521 Views
Last Modified: 2013-11-27
Hi,

I am extracting an string of length 8 from a filename. I want to convert the string to a date so I need to check if it is composed of all numeric digits before I try to convert it or I will cause an error.

So basically I need to determine if the string is composed of all numeric digits or if there are some text digits instead.

i.e.

"12345678"                       this is good
"1234r567"                       any combination with any amount letters is bad

I'll probably have to loop through the components and check to see if they are numeric.

I will use this in existing code to decide whether to process the file or delete it.

Thanks,
scurvylion

0
Comment
Question by:scurvylion
  • 5
  • 4
  • 2
  • +2
15 Comments
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 33598147

you can use the isnumeric() function

if isnumeric(string) then

 else
end if
0
 
LVL 10

Expert Comment

by:ALaRiva
ID: 33598166
Use the IsNumeric() Function, so something like this:

Dim strCheck as String
strCheck = "12345678"

If IsNumeric(strCheck) Then
    'Do what you want here, it is a valid number
Else
    'Not all numbers, do what you want here
End If
0
 
LVL 15

Accepted Solution

by:
dbbishop earned 250 total points
ID: 33598230
The problem with using IsNumeric is that 1234.43 is numeric and -342 is numeric, although neither are all numbers. Try the code below.
Declare Public Function NumCheck(Value as Variant) As Boolean

Dim I as Integer

NumCheck = 1

For I = 1 To Len(Value)

  If Mid(Value, I, 1) < '0' Or Mid(Value, I, 1) > '9' Then 

    NumCheck = 0

    Exit Function

Next I



Then execute by using:

 If NumCheck(myValue) = 0 Then ' not all numeric

Open in new window

0
 
LVL 10

Expert Comment

by:ALaRiva
ID: 33598274
dbbishop,
While I agree with your point, I think that just ends up opening another can of worms.

He says this value will then be converted to a date, so should (s)he be checking for valid numbers that can also be converted to a valid date, and within what time frame of date allowed (only this week? last week? within a year or two), etc. etc.

I think it all boils down to how much this user needs out of this and what his/her full requirement is.

- Anthony
0
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 33598275
i agree with dbbishop, but for the OP's requirement the isNumeric() function will do since
the string will be coming from ....

<I am extracting an string of length 8 from a filename.>

and i doubt that you will find a "-" sign at the start of the string and a dot(.) in the middle of the string...
0
 
LVL 15

Expert Comment

by:dbbishop
ID: 33598371
However, if I recall correctly, 123e34 is also numeric using the IsNumeric() function.
0
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 33598405
<123e34 is also numeric using the IsNumeric() function.>

correct, but not when you pass is as a String..


IsNumeric("123e34")
0
Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 33598411
>>However, if I recall correctly, 123e34 is also numeric using the IsNumeric() function.Indeed, it will :)
0
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 33598439
i stand corrected...
0
 
LVL 92

Assisted Solution

by:Patrick Matthews
Patrick Matthews earned 250 total points
ID: 33598441
If your real concern is to validate that a string can convert to a date, then assuming your string is yyyymmdd...If IsDate(Left(MyStr, 4) & "-" & Mid(MyStr, 5, 2) & "-" & Right(MyStr, 2)) Then   'valid dateElse    'invalidEnd IfIf the string is, say, mmddyyyy....If IsDate(Right(MyStr, 4) & "-" & Left(MyStr, 2) & "-" & Mid(MyStr, 3, 2)) Then   'valid dateElse    'invalidEnd If
0
 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 33598458
In that code I just posted, if the expression passed to IsDate cannot be converted to a Date value, then the function simply returns False.IsDate will work in queries, too.
0
 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 33598531
And, of course, if the string is ddmmyyyy....If IsDate(Right(MyStr, 4) & "-" & Mid(MyStr, 3, 2) & "-" & Left(MyStr, 2)) Then  'valid dateElse   'invalidEnd If
0
 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 33598594
And lastly, ignoring dates for a moment, if all you really want to do is ensure that a given string contains only digits...If Not MyString Like "*[!0-9]*" Then    'code for only digitsElse    'code for at least one non-digitEnd IfThat will work in queries too.
0
 

Author Comment

by:scurvylion
ID: 33598736
Thanks for all of your input guys. First of all, let me apologize for not being as clear as I could of been. I shouldn't have gotten lazy when writing the question up.

MatthewsPatrick hit the nail on the head with the solution for yyyymmdd but since I asked for a solution to whether the string was numeric or not, dbbishop also provided a valid solution. Therefore, I am going to split the points between you two guys.

I appreciate your timely advice.
0
 

Author Closing Comment

by:scurvylion
ID: 33598753
Thanks again guys.
0

Featured Post

Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

Join & Write a Comment

I originally created this report in Crystal Reports 2008 where there is an option to underlay sections. I initially came across the problem in Access Reports where I was unable to run my border lines down through the entire page as I was using the P…
This article describes some techniques which will make your VBA or Visual Basic Classic code easier to understand and maintain, whether by you, your replacement, or another Experts-Exchange expert.
In Microsoft Access, learn how to use Dlookup and other domain aggregate functions and one method of specifying a string value within a string. Specify the first argument, which is the expression to be returned: Specify the second argument, which …
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

708 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now