Set recordsource of unbound subform

I have an unbound subform on a bound form. I am trying to set the recordsource of the subform in vba from the click event of a command button to display the records related to the value of a field on the parent form. I am getting a run time error 2467 - "The expression you entered refers to an object that is closed or doesn't exist." This error is ocurring on the line of code listed below. This seems like it should be very simple but is causing me a great deal of trouble.

Addtionaly, I cannot simply create a bound subform and link the fields as I want to group the data by multiple fields.
Private Sub Command73_Click()

Dim strSQL As String

    strSQL = "SELECT FIRST([Group Code]), [Month], FIRST([Quarter]), FIRST([Year]), " & _
        "SUM([Gross Sales]), SUM([CM-PY Sales]), SUM([E-Sales]), SUM([Rebateable Sales]), " & _
        "SUM([Standard Calc Percent]), SUM([Growth Calc Percent]), SUM([Electronic Calc Percent]) " & _
        "FROM tblHistoricSales WHERE [Group Code] = '" & Me.GROUP_CODE.Value & "' " & _
        "GROUP BY [Month]"
        
'***The error occurs on the following line:
    Me.tblHistoricalSales_subform.Form.RecordSource = strSQL
    
    Me.Requery
    
End Sub

Open in new window

LVL 1
wipnavAsked:
Who is Participating?
 
GRayLConnect With a Mentor Commented:
Note that in my proposed solution you do not need a query.  The main form is bound to the main table, the sub form is bound to the many table, the linkage is controlled by the settings in LinkMasterFields, and LinkChildFields.
0
 
Rey Obrero (Capricorn1)Commented:
Me.[tblHistoricalSales subform].Form.RecordSource = strSQL

are you sure the name of the subform is  tblHistoricalSales_subform


open the form in design view

select the outer edge of the subform control and hit F4, select the All tab
see what is on the Name property
copy that and use it in your code
0
 
GRayLCommented:
That is why LinkMasterFields and LinkChildFields is plural - you can enter multiple fields.
0
Cloud Class® Course: Microsoft Windows 7 Basic

This introductory course to Windows 7 environment will teach you about working with the Windows operating system. You will learn about basic functions including start menu; the desktop; managing files, folders, and libraries.

 
LucasMS Dynamics DeveloperCommented:
What is the error?

Take the query put it in the query designer to see if it works.  Might be something wrong with the query.
0
 
wipnavAuthor Commented:
capricorn - Yes, that was the name of the form, just to be safe, I renamed it to "sfrm" and tried again and I still received the same error.

GRayL - How would you do a group by with LinkMasterFields and LinkChildFields, how would I specify if I wanted a sum, min, max, etc.?
0
 
GRayLCommented:
You would enter the fields, separated by commas and qualified with their tablenames on the Link Master and Child Fields lines.  Then enter the aggregate fields in the subform.
0
 
GRayLCommented:
You would enter the Group By fields,...
0
 
Rey Obrero (Capricorn1)Commented:
<I renamed it to "sfrm" >
where did you do this?
0
 
LucasMS Dynamics DeveloperCommented:
Me.tblHistoricalSales_subform.Form.RecordSource = strSQL
Me.Requery

Should be:

Me.tblHistoricalSales_subform.Form.RecordSource = strSQL
Me.tblHistoricalSales_subform.Form.Requery

0
 
SheilsConnect With a Mentor Commented:
Looks like the confusion it between the subform and the source object which is a common rookie error.

When you create a subform you click on the subform icon on the toolbar and this allows you to create a box. (This box is the subform)

Then you are asked to select a form,table or query insert in the subform (These are the source objects)

By default access gives subform the same name as the source object which adds to the confusion. After falling in this trap for a number of times I have resolved to renaming the subform with the prefix chd. To do this right click on the box around the source object to open the subform property.

Check the data tab. The first item on this tab should be source object

select the other tab. Change name to chdHistoricalSales

Now your subform and subform object have different name it will be easier for you to know what you are referring to.

To change the record source of the source object use the following code

Me.chdHistoricalSales.Form.RecordSource = sql
0
 
Rey Obrero (Capricorn1)Commented:

seen my comment here http:#a33599946
0
 
hnasrCommented:
When you add a textbox control, wizard asks you about the control source.
The textbox name can by any.

With subform control, it asks for the form to use, if no form, it asks to use a table/query to create a form for you to be used.
The subform control can be any, but the form is the one you select. The form is the source object of the subform control. (compare with controol source for the textbox).

Check back previous comments and see if they are helpful.
0
 
Helen FeddemaCommented:
Give your objects and controls the appropriate naming convention prefixes, to avoid confusion (and reference errors).  In these cases I have found it useful to save the SQL as a query (so it can be examined in the query designer if there are any problems), and set it as the subform's record source.  Then, you can just refresh the subform's source object as follows:

Assign a Subform variable to the name of the subform, and set its source object to "", then run queries or otherwise recreate the SQL record source used by the subform, then reassign the source object:
strForm = "frmDataEntryr"
Set subFrm = Forms(strForm)![subDetail]
subFrm.SourceObject = ""
strTable = "tblCMNumbersDetailEntry"
strSQL = "DELETE * FROM " & strTable
DoCmd.SetWarnings False
DoCmd.RunSQL strSQL
strQuery = "qappNumbersDetailEntry"
DoCmd.OpenQuery strQuery
strQuery = "qupdNumbersDetailEntry"
DoCmd.OpenQuery strQuery
subFrm.SourceObject = "fsubCurrentDetails"

Open in new window

0
 
Helen FeddemaCommented:
This method avoids swapping the record source of an open object, which can be problematic.
0
 
wipnavAuthor Commented:
Thanks for your help guys.

GRayL, your solution turned out to be the most appropriate for my problem, I was able to link the master/child fields and place my aggregate functions in the fields on the subform which was quick and easy.

sb9, you got points as well because you indeed did identify the issue that I was having of not referencing the correct object which should help in a situation where linking master/child fields may not be practical.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.