Solved

VBS Rename Script not working correctly.

Posted on 2010-09-06
8
445 Views
Last Modified: 2012-05-10

Hey Rob files only.....
Set fso = CreateObject("Scripting.FileSystemObject") 

Set re  = New RegExp 

 

re.Pattern = "[&]" ' put all characters that you want to strip inside the brackets' 

re.IgnoreCase = True 

re.Global = True 

 

If WScript.Arguments.Unnamed.Count = 1 Then 

  If fso.FolderExists(WScript.Arguments.Unnamed(0)) Then 

    Recurse fso.GetFolder(WScript.Arguments.Unnamed(0)) 

  Else 

    WScript.Echo "Folder not found." 

  End If 

Else 

  WScript.Echo "Please give folder name as argument 1." 

End If 

 

 

Sub Recurse(f) 

  For Each sf In f.SubFolders 

    Recurse sf 

     WScript.Echo sf.Name, " -> ", re.Replace(sf.Name, "and") 

    If fso.FolderExists(Replace(sf.Name, re.Pattern, "and")) = False Then

       sf.Name = re.Replace(sf.Name, "and") 

    Else

       MsgBox "Cannot rename " & sf.Name & " to " & Replace(sf.Name, re.Pattern, "and") & ". Folder already exists."

    End If

  Next 

  For Each sf In f.Files 

    If Right(LCase(sf.Name), 4) = LCase(".doc") Then

	     WScript.Echo sf.Name, " -> ", re.Replace(sf.Name, "and") 

	    If fso.FileExists(Replace(sf.Name, re.Pattern, "and")) = False Then

	       sf.Name = re.Replace(sf.Name, "and") 

	    Else

	       MsgBox "Cannot rename " & sf.Name & " to " & Replace(sf.Name, re.Pattern, "and") & ". File already exists."

	    End If

    End If

  Next 

End Sub

Open in new window

0
Comment
Question by:JohnLo
  • 5
  • 3
8 Comments
 
LVL 65

Expert Comment

by:RobSampson
Comment Utility
Try this to have it rename files only, and not folders, but still iterate through all subfolders.

Regards,

Rob.
Set fso = CreateObject("Scripting.FileSystemObject") 

Set re  = New RegExp 

 

re.Pattern = "[&]" ' put all characters that you want to strip inside the brackets' 

re.IgnoreCase = True 

re.Global = True 

 

If WScript.Arguments.Unnamed.Count = 1 Then 

  If fso.FolderExists(WScript.Arguments.Unnamed(0)) Then 

    Recurse fso.GetFolder(WScript.Arguments.Unnamed(0)) 

  Else 

    WScript.Echo "Folder not found." 

  End If 

Else 

  WScript.Echo "Please give folder name as argument 1." 

End If 

 

 

Sub Recurse(f) 

  For Each sf In f.Files 

    If Right(LCase(sf.Name), 4) = LCase(".doc") Then

	     WScript.Echo sf.Name, " -> ", re.Replace(sf.Name, "and") 

	    If fso.FileExists(Replace(sf.Name, re.Pattern, "and")) = False Then

	       sf.Name = re.Replace(sf.Name, "and") 

	    Else

	       MsgBox "Cannot rename " & sf.Name & " to " & Replace(sf.Name, re.Pattern, "and") & ". File already exists."

	    End If

    End If

  Next 

  For Each sf In f.SubFolders

    Recurse sf

  Next

End Sub

Open in new window

0
 
LVL 4

Author Comment

by:JohnLo
Comment Utility
this is so weird, Back to.....
(24, 9) Microsoft VBScript runtime error: File already exists
0
 
LVL 65

Expert Comment

by:RobSampson
Comment Utility
OK, if this next one doesn't work....I'll just add error checking to the post after that....
Set fso = CreateObject("Scripting.FileSystemObject") 

Set re  = New RegExp 

 

re.Pattern = "[&]" ' put all characters that you want to strip inside the brackets' 

re.IgnoreCase = True 

re.Global = True 

 

If WScript.Arguments.Unnamed.Count = 1 Then 

  If fso.FolderExists(WScript.Arguments.Unnamed(0)) Then 

    Recurse fso.GetFolder(WScript.Arguments.Unnamed(0)) 

  Else 

    WScript.Echo "Folder not found." 

  End If 

Else 

  WScript.Echo "Please give folder name as argument 1." 

End If 

 

 

Sub Recurse(f) 

  For Each sf In f.Files 

    If Right(LCase(sf.Name), 4) = LCase(".doc") Then

	     WScript.Echo sf.Name, " -> ", Replace(sf.Name, re.Pattern, "and")

	    If fso.FileExists(Replace(sf.Name, re.Pattern, "and")) = False Then

	       sf.Name = re.Replace(sf.Name, "and") 

	    Else

	       MsgBox "Cannot rename " & sf.Name & " to " & Replace(sf.Name, re.Pattern, "and") & ". File already exists."

	    End If

    End If

  Next 

  For Each sf In f.SubFolders

    Recurse sf

  Next

End Sub

Open in new window

0
 
LVL 65

Accepted Solution

by:
RobSampson earned 500 total points
Comment Utility
This is has error checking instead.
Set fso = CreateObject("Scripting.FileSystemObject") 

Set re  = New RegExp 

 

re.Pattern = "[&]" ' put all characters that you want to strip inside the brackets' 

re.IgnoreCase = True 

re.Global = True 

 

If WScript.Arguments.Unnamed.Count = 1 Then 

  If fso.FolderExists(WScript.Arguments.Unnamed(0)) Then 

    Recurse fso.GetFolder(WScript.Arguments.Unnamed(0)) 

  Else 

    WScript.Echo "Folder not found." 

  End If 

Else 

  WScript.Echo "Please give folder name as argument 1." 

End If 

 

 

Sub Recurse(f) 

  For Each sf In f.Files 

    If Right(LCase(sf.Name), 4) = LCase(".doc") Then

	     WScript.Echo sf.Name, " -> ", Replace(sf.Name, re.Pattern, "and")

	    On Error Resume Next

	       sf.Name = re.Replace(sf.Name, "and") 

	    If Err.Number <> 0 Then

	       MsgBox "Cannot rename " & sf.Name & " to " & Replace(sf.Name, re.Pattern, "and") & ". Error " & Err.Number & ": " & Err.Description

	       Err.Clear

	    End If

	    On Error GoTo 0

    End If

  Next 

  For Each sf In f.SubFolders

    Recurse sf

  Next

End Sub

Open in new window

0
What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

 
LVL 4

Author Comment

by:JohnLo
Comment Utility
ok lots of error 58's but here is what i think it might be doing. I think it is trying to rename anything with "&" in the name as well as  anything with "and" in the name. if i click ok to all the errors it will go through and finally rename it. issue is i cant click ok when this runs against a folder at night.
 
e.g. filenameandext.doc and not be renamed filenameandext.doc
0
 
LVL 65

Expert Comment

by:RobSampson
Comment Utility
If you change
MsgBox
to
wscript.echo
and then run the script with
cscript MyScript.vbs

it won't make you click OK....but does it still appear to work correctly?

Rob.
0
 
LVL 4

Author Comment

by:JohnLo
Comment Utility
ill try it tonight.......
0
 
LVL 65

Expert Comment

by:RobSampson
Comment Utility
Hi JohnLo, did you have any luck with your testing?

Regards,

Rob.
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

Welcome back!  My apologies for taking so long to write part two of this series; it's been a long time coming!  As I promised in Part 1, this article will focus on how to locate those elusive AD properties that you are searching for.  Why is this us…
Welcome, welcome!  If you are new to the series and haven't been following along, please take a brief moment to review the first three installments: Part 1 (http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/A_266-VBScri…
Here's a very brief overview of the methods PRTG Network Monitor (https://www.paessler.com/prtg) offers for monitoring bandwidth, to help you decide which methods you´d like to investigate in more detail.  The methods are covered in more detail in o…
In this tutorial you'll learn about bandwidth monitoring with flows and packet sniffing with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're interested in additional methods for monitoring bandwidt…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now