Improve company productivity with a Business Account.Sign Up

x
?
Solved

PHP Login User Redirect

Posted on 2010-09-07
3
Medium Priority
?
261 Views
Last Modified: 2012-05-10
Hi Experts. I’m sure this is a pretty simple fix but I can’t seem to figure it out. I currently have a login form working so that if you login it will echo ‘success’ (this was mainly for testing) and if you login with the username ‘admin’ it will redirect you to the ‘admin’ specific page… This is all working. The only issue is with my error checking and validation. If I login with a test username and password it will check to make sure they match and are correct than echo success. If I login with ‘admin’ as the username it will redirect the user to the admin page… regardless of what password they enter. Is there a way to make it so that it checks ‘admin’ for the correct password before redirecting? Any help would be greatly appreciated.
<?php
ob_start();
session_start();

$username = $_POST['username'];
$password = md5($_POST['password']);

if ($username&&$password)
{
	
	$connect = mysql_connect("xxx", "xxx", "xxx") or die("Connection Error!");
	mysql_select_db("xxx") or die("Couldn't find db");
	
	$query = mysql_query("SELECT * FROM users WHERE username='$username'");
	
	$numrows = mysql_num_rows($query);
	
	if ($numrows!=0)
	{
		while ($row = mysql_fetch_assoc($query))
{
	$dbusername = $row['username'];
	$dbpassword = $row['password'];
}

//check to see if they match
if($username==$dbusername&&$password==md5($dbpassword))
{
	echo "Success!";
	$_SESSION['username']=$username;
}
else
echo "<br>Password is incorrect.<br><a href='#'>Back</a><br>";

	}
	
	else
	die ("<br>That user doesn't exist.<br><a href='#'>Back</a><br>");
	
}
else
die("<br>Please enter username and password.<br><a href='#'>Back</a><br>");


//ADD USER REDIRECTS HERE

if ($username=="xxx")
{
header("Location: xxx/index.php");
}


?>

Open in new window

0
Comment
Question by:brettsky07
  • 2
3 Comments
 
LVL 84

Accepted Solution

by:
Dave Baldwin earned 2000 total points
ID: 33620108
I would put the redirect just after the 'Success' and session variable so it was inside the condition checks instead of outside where it just takes a username if it gets that far which it is.
0
 

Author Comment

by:brettsky07
ID: 33620186
wow. cant beleive I didnt try that. haha that worked just fine thanks!
0
 
LVL 84

Expert Comment

by:Dave Baldwin
ID: 33620398
thank you.
0

Featured Post

Upgrade your Question Security!

Your question, your audience. Choose who sees your identity—and your question—with question security.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

These days socially coordinated efforts have turned into a critical requirement for enterprises.
Many old projects have bad code, but the budget doesn't exist to rewrite the codebase. You can update this code to be safer by introducing contemporary input validation, sanitation, and safer database queries.
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

580 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question