Solved

PHP Login User Redirect

Posted on 2010-09-07
3
249 Views
Last Modified: 2012-05-10
Hi Experts. I’m sure this is a pretty simple fix but I can’t seem to figure it out. I currently have a login form working so that if you login it will echo ‘success’ (this was mainly for testing) and if you login with the username ‘admin’ it will redirect you to the ‘admin’ specific page… This is all working. The only issue is with my error checking and validation. If I login with a test username and password it will check to make sure they match and are correct than echo success. If I login with ‘admin’ as the username it will redirect the user to the admin page… regardless of what password they enter. Is there a way to make it so that it checks ‘admin’ for the correct password before redirecting? Any help would be greatly appreciated.
<?php

ob_start();

session_start();



$username = $_POST['username'];

$password = md5($_POST['password']);



if ($username&&$password)

{

	

	$connect = mysql_connect("xxx", "xxx", "xxx") or die("Connection Error!");

	mysql_select_db("xxx") or die("Couldn't find db");

	

	$query = mysql_query("SELECT * FROM users WHERE username='$username'");

	

	$numrows = mysql_num_rows($query);

	

	if ($numrows!=0)

	{

		while ($row = mysql_fetch_assoc($query))

{

	$dbusername = $row['username'];

	$dbpassword = $row['password'];

}



//check to see if they match

if($username==$dbusername&&$password==md5($dbpassword))

{

	echo "Success!";

	$_SESSION['username']=$username;

}

else

echo "<br>Password is incorrect.<br><a href='#'>Back</a><br>";



	}

	

	else

	die ("<br>That user doesn't exist.<br><a href='#'>Back</a><br>");

	

}

else

die("<br>Please enter username and password.<br><a href='#'>Back</a><br>");





//ADD USER REDIRECTS HERE



if ($username=="xxx")

{

header("Location: xxx/index.php");

}





?>

Open in new window

0
Comment
Question by:brettsky07
  • 2
3 Comments
 
LVL 82

Accepted Solution

by:
Dave Baldwin earned 500 total points
ID: 33620108
I would put the redirect just after the 'Success' and session variable so it was inside the condition checks instead of outside where it just takes a username if it gets that far which it is.
0
 

Author Comment

by:brettsky07
ID: 33620186
wow. cant beleive I didnt try that. haha that worked just fine thanks!
0
 
LVL 82

Expert Comment

by:Dave Baldwin
ID: 33620398
thank you.
0

Featured Post

What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

Join & Write a Comment

Introduction HTML checkboxes provide the perfect way for a web developer to receive client input when the client's options might be none, one or many.  But the PHP code for processing the checkboxes can be confusing at first.  What if a checkbox is…
Deprecated and Headed for the Dustbin By now, you have probably heard that some PHP features, while convenient, can also cause PHP security problems.  This article discusses one of those, called register_globals.  It is a thing you do not want.  …
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
The viewer will learn how to look for a specific file type in a local or remote server directory using PHP.

747 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now