MonitorFromWindow AV

When a user resizes my app I trap the WMSize to make sure the app doesn't grow wider than the workspace.  I need to keep a maximized app from going over the Vista sidebar if it is "stay on top".

We have a customer who is using a laptop.  At work this laptop is used with a docking station.

When I call Screen.MonitorFromWindow it sometimes throws an AV on his laptop.  Can anyone tell me why and how to fix?  I am assuming it has to do with the docking station since have we no other customer reporting this problem.

Thanks.
alexiatAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

cebassoCommented:
0
Emmanuel PASQUIERFreelance Project ManagerCommented:
does the problem occurs when the user is using the docking station, or when he is out of it ?
Has he changed that state since the application started (docked in or out) ?
0
Emmanuel PASQUIERFreelance Project ManagerCommented:
The code source for the root MonitorFromWindow function is quite complex : it can, or cannot, rely on Windows API, depending on their availability, or on a default stub (Delphi tries his own algo to emulate windows API) if it is not available.
Let's suppose that this AV comes from the stub function : it only support detection of the primary monitor. So if after MonitorFromWindow you call FindMonitor with that result and the monitor is not the primary, it can return a NIL monitor.
If you use that monitor returned from TScreen.MonitorFromWindow without checking for NIL, you have an AV.
function TScreen.MonitorFromWindow(const Handle: THandle;
  MonitorDefault: TMonitorDefaultTo): TMonitor;
begin
  Result := FindMonitor(MultiMon.MonitorFromWindow(Handle,
    MonitorDefaultFlags[MonitorDefault]));
end;

function TScreen.FindMonitor(Handle: HMONITOR): TMonitor;
var
  I: Integer;
begin
  Result := nil;
  for I := 0 to MonitorCount - 1 do
    if Monitors[I].Handle = Handle then
    begin
      Result := Monitors[I];
      break;
    end;
end;

// this is the stub. It is called first, as being assigned to MultiMon.MonitorFromWindow variable
// It's first task is to see if the API is available, and if so, 
// replace func global variable with the API func address, and use it
// if not, it is emulated with xMonitorFromRect
function xMonitorFromWindow(hWnd: HWND; dwFlags: DWORD): HMONITOR; stdcall;
var
  wp: TWindowPlacement;
begin
  if not InitApis[mmMonitorFromWindow] then
  begin
    @MonitorFromWindow := InitAnApi(mmMonitorFromWindow, @MonitorFromWindow, 'MonitorFromWindow');
    Result := MonitorFromWindow(hWnd, dwFlags);
    Exit;
  end;

  if Boolean(dwFlags and (MONITOR_DEFAULTTOPRIMARY or MONITOR_DEFAULTTONEAREST)) then
    Result := xPRIMARY_MONITOR
  else
  begin
    if IsIconic(hWnd) then
      GetWindowPlacement(hWnd, @wp)
    else
      GetWindowRect(hWnd, wp.rcNormalPosition);
    Result := xMonitorFromRect(@wp.rcNormalPosition, dwFlags);
  end
end;

// and this one COULD return an invalid handle (0)
function xMonitorFromRect(lprcScreenCoords: PRect; dwFlags: DWORD): HMONITOR; stdcall;
begin
  if not InitApis[mmMonitorFromRect] then
  begin
    @MonitorFromRect := InitAnApi(mmMonitorFromRect, @MonitorFromRect, 'MonitorFromRect');
    Result := MonitorFromRect(lprcScreenCoords, dwFlags);
    Exit;
  end;

  Result := 0;
  if Boolean(dwFlags and (MONITOR_DEFAULTTOPRIMARY or MONITOR_DEFAULTTONEAREST)) or
    (lprcScreenCoords.Right > 0) and
    (lprcScreenCoords.Bottom > 0) and
    (lprcScreenCoords.Left < GetSystemMetrics(SM_CXSCREEN)) and
    (lprcScreenCoords.Top < GetSystemMetrics(SM_CYSCREEN)) then
      Result := xPRIMARY_MONITOR;
end;

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Emmanuel PASQUIERFreelance Project ManagerCommented:
In short, you'd better gather a lot more intel about your user problem : OS, context of the error, and also context of the times there is no error etc...
Try to locate the exact place in Delphi code where the AV occurs. For this, you can use the "Find Execution Error" delphi function with the hexadecimal error address when the AV occurs in your user laptop.
0
alexiatAuthor Commented:
Thanks.  Now I have an understanding of the problem and I can work with the user to find out exactly when and where the problem is happening.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Delphi

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.