Solved

MonitorFromWindow AV

Posted on 2010-09-10
5
761 Views
Last Modified: 2013-11-05
When a user resizes my app I trap the WMSize to make sure the app doesn't grow wider than the workspace.  I need to keep a maximized app from going over the Vista sidebar if it is "stay on top".

We have a customer who is using a laptop.  At work this laptop is used with a docking station.

When I call Screen.MonitorFromWindow it sometimes throws an AV on his laptop.  Can anyone tell me why and how to fix?  I am assuming it has to do with the docking station since have we no other customer reporting this problem.

Thanks.
0
Comment
Question by:alexiat
  • 3
5 Comments
 
LVL 4

Expert Comment

by:cebasso
ID: 33657278
0
 
LVL 25

Expert Comment

by:epasquier
ID: 33660483
does the problem occurs when the user is using the docking station, or when he is out of it ?
Has he changed that state since the application started (docked in or out) ?
0
 
LVL 25

Accepted Solution

by:
epasquier earned 500 total points
ID: 33660584
The code source for the root MonitorFromWindow function is quite complex : it can, or cannot, rely on Windows API, depending on their availability, or on a default stub (Delphi tries his own algo to emulate windows API) if it is not available.
Let's suppose that this AV comes from the stub function : it only support detection of the primary monitor. So if after MonitorFromWindow you call FindMonitor with that result and the monitor is not the primary, it can return a NIL monitor.
If you use that monitor returned from TScreen.MonitorFromWindow without checking for NIL, you have an AV.
function TScreen.MonitorFromWindow(const Handle: THandle;

  MonitorDefault: TMonitorDefaultTo): TMonitor;

begin

  Result := FindMonitor(MultiMon.MonitorFromWindow(Handle,

    MonitorDefaultFlags[MonitorDefault]));

end;



function TScreen.FindMonitor(Handle: HMONITOR): TMonitor;

var

  I: Integer;

begin

  Result := nil;

  for I := 0 to MonitorCount - 1 do

    if Monitors[I].Handle = Handle then

    begin

      Result := Monitors[I];

      break;

    end;

end;



// this is the stub. It is called first, as being assigned to MultiMon.MonitorFromWindow variable

// It's first task is to see if the API is available, and if so, 

// replace func global variable with the API func address, and use it

// if not, it is emulated with xMonitorFromRect

function xMonitorFromWindow(hWnd: HWND; dwFlags: DWORD): HMONITOR; stdcall;

var

  wp: TWindowPlacement;

begin

  if not InitApis[mmMonitorFromWindow] then

  begin

    @MonitorFromWindow := InitAnApi(mmMonitorFromWindow, @MonitorFromWindow, 'MonitorFromWindow');

    Result := MonitorFromWindow(hWnd, dwFlags);

    Exit;

  end;



  if Boolean(dwFlags and (MONITOR_DEFAULTTOPRIMARY or MONITOR_DEFAULTTONEAREST)) then

    Result := xPRIMARY_MONITOR

  else

  begin

    if IsIconic(hWnd) then

      GetWindowPlacement(hWnd, @wp)

    else

      GetWindowRect(hWnd, wp.rcNormalPosition);

    Result := xMonitorFromRect(@wp.rcNormalPosition, dwFlags);

  end

end;



// and this one COULD return an invalid handle (0)

function xMonitorFromRect(lprcScreenCoords: PRect; dwFlags: DWORD): HMONITOR; stdcall;

begin

  if not InitApis[mmMonitorFromRect] then

  begin

    @MonitorFromRect := InitAnApi(mmMonitorFromRect, @MonitorFromRect, 'MonitorFromRect');

    Result := MonitorFromRect(lprcScreenCoords, dwFlags);

    Exit;

  end;



  Result := 0;

  if Boolean(dwFlags and (MONITOR_DEFAULTTOPRIMARY or MONITOR_DEFAULTTONEAREST)) or

    (lprcScreenCoords.Right > 0) and

    (lprcScreenCoords.Bottom > 0) and

    (lprcScreenCoords.Left < GetSystemMetrics(SM_CXSCREEN)) and

    (lprcScreenCoords.Top < GetSystemMetrics(SM_CYSCREEN)) then

      Result := xPRIMARY_MONITOR;

end;

Open in new window

0
 
LVL 25

Expert Comment

by:epasquier
ID: 33660597
In short, you'd better gather a lot more intel about your user problem : OS, context of the error, and also context of the times there is no error etc...
Try to locate the exact place in Delphi code where the AV occurs. For this, you can use the "Find Execution Error" delphi function with the hexadecimal error address when the AV occurs in your user laptop.
0
 

Author Closing Comment

by:alexiat
ID: 33666463
Thanks.  Now I have an understanding of the problem and I can work with the user to find out exactly when and where the problem is happening.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Hello everybody This Article will show you how to validate number with TEdit control, What's the TEdit control? TEdit is a standard Windows edit control on a form, it allows to user to write, read and copy/paste single line of text. Usua…
In my programming career I have only very rarely run into situations where operator overloading would be of any use in my work.  Normally those situations involved math with either overly large numbers (hundreds of thousands of digits or accuracy re…
Video by: Mark
This lesson goes over how to construct ordered and unordered lists and how to create hyperlinks.
Many functions in Excel can make decisions. The most simple of these is the IF function: it returns a value depending on whether a condition you describe is true or false. Once you get the hang of using the IF function, you will find it easier to us…

910 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now