Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 274
  • Last Modified:

Insert Records create Duplicate Records

The code below is inserting additional data in another personal user information table.  however it keeps creating more than one record upon insert.  Why? and How do I fix it?
Protected Sub CreateUserWizard1_CreatedUser(ByVal sender As Object, ByVal e As System.EventArgs)
        'Insert Data into table and Add other pertinent data
        Dim UserNameTextBox As TextBox = CreateUserWizardStep1.ContentTemplateContainer.FindControl("UserName")
        Dim createDate As Date = DateTime.Now.ToString("MM/dd/yy")

        Dim rowsAffected As Integer
        Dim rIdentity As Integer = -1
        Try
            Dim myConnectionString As String
            Dim myQuery As String
            Dim myConnection As SqlConnection
            Dim cmd As SqlCommand


            myConnectionString = "Data Source=ServerIP;Initial Catalog=dbname; User Id=username; Password=password;"
            myQuery = "INSERT INTO aspnet_UserName (UserName, Firstname, Lastname, Prefixname, Suffixname, Nickname, " _
                & "CreateDate, AccountStatus, OrgNameID) VALUES ('" _
                & UserNameTextBox.Text & "', '" & Firstname.Text & "', '" & Lastname.Text & "', '" & PrefixnameDDL.Text & "', '" _
                & Suffix.Text & "', '" & Nickname.Text & "', '" & createDate & "', 'Enabled', '" _
                & getOrgNameID(OrganizationDDL.Text) & "') SELECT SCOPE_IDENTITY();"
            myConnection = New SqlConnection(myConnectionString)
            myConnection.Open()
            cmd = New SqlCommand(myQuery, myConnection)
            rowsAffected = cmd.ExecuteNonQuery()
            rIdentity = Integer.Parse(cmd.ExecuteScalar().ToString()) 'Get the @Identity Column

            myConnection.Close()
        Catch ex As Exception
            ClientScript.RegisterStartupScript(Me.GetType(), "alert", "<script language='javascript'>alert('CreateUserWizard1_CreatedUser produce the following error: " + ex.Message + "');</script>")
            Response.Write(ex.Message)
        End Try
    End Sub

Open in new window

0
Robert Treadwell
Asked:
Robert Treadwell
1 Solution
 
rockiroadsCommented:
one of two ways perhaps

create a unique index so that the operation fails

or

read the table, check the record exists or not
if it exists then update else insert
0
 
MlandaTCommented:
1. You are using the CreateUserWizard.
2. When you use this wizard, the CreateUserWizard1_CreatedUser event only fires AFTER the user has already been created.
3. You are doing an insert there... which is creating the duplicate user.

With the CreateUserWizard, the user is automatically created for you, you dont need to execute an INSERT.

Comment out all the code in this method, compile and attempt to create a user. You will see that the duplicate users are gone.
0
 
David Christal CISSPCommented:
If MlandaT's suggestion doesn't work out try it with line 24 commented out.
Looks like you're executing the insert on both 24 & 25
0

Featured Post

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now