Solved

Insert Records create Duplicate Records

Posted on 2010-09-10
3
253 Views
Last Modified: 2012-05-10
The code below is inserting additional data in another personal user information table.  however it keeps creating more than one record upon insert.  Why? and How do I fix it?
Protected Sub CreateUserWizard1_CreatedUser(ByVal sender As Object, ByVal e As System.EventArgs)

        'Insert Data into table and Add other pertinent data

        Dim UserNameTextBox As TextBox = CreateUserWizardStep1.ContentTemplateContainer.FindControl("UserName")

        Dim createDate As Date = DateTime.Now.ToString("MM/dd/yy")



        Dim rowsAffected As Integer

        Dim rIdentity As Integer = -1

        Try

            Dim myConnectionString As String

            Dim myQuery As String

            Dim myConnection As SqlConnection

            Dim cmd As SqlCommand





            myConnectionString = "Data Source=ServerIP;Initial Catalog=dbname; User Id=username; Password=password;"

            myQuery = "INSERT INTO aspnet_UserName (UserName, Firstname, Lastname, Prefixname, Suffixname, Nickname, " _

                & "CreateDate, AccountStatus, OrgNameID) VALUES ('" _

                & UserNameTextBox.Text & "', '" & Firstname.Text & "', '" & Lastname.Text & "', '" & PrefixnameDDL.Text & "', '" _

                & Suffix.Text & "', '" & Nickname.Text & "', '" & createDate & "', 'Enabled', '" _

                & getOrgNameID(OrganizationDDL.Text) & "') SELECT SCOPE_IDENTITY();"

            myConnection = New SqlConnection(myConnectionString)

            myConnection.Open()

            cmd = New SqlCommand(myQuery, myConnection)

            rowsAffected = cmd.ExecuteNonQuery()

            rIdentity = Integer.Parse(cmd.ExecuteScalar().ToString()) 'Get the @Identity Column



            myConnection.Close()

        Catch ex As Exception

            ClientScript.RegisterStartupScript(Me.GetType(), "alert", "<script language='javascript'>alert('CreateUserWizard1_CreatedUser produce the following error: " + ex.Message + "');</script>")

            Response.Write(ex.Message)

        End Try

    End Sub

Open in new window

0
Comment
Question by:Robert Treadwell
3 Comments
 
LVL 65

Expert Comment

by:rockiroads
ID: 33651225
one of two ways perhaps

create a unique index so that the operation fails

or

read the table, check the record exists or not
if it exists then update else insert
0
 
LVL 30

Expert Comment

by:MlandaT
ID: 33651245
1. You are using the CreateUserWizard.
2. When you use this wizard, the CreateUserWizard1_CreatedUser event only fires AFTER the user has already been created.
3. You are doing an insert there... which is creating the duplicate user.

With the CreateUserWizard, the user is automatically created for you, you dont need to execute an INSERT.

Comment out all the code in this method, compile and attempt to create a user. You will see that the duplicate users are gone.
0
 
LVL 5

Accepted Solution

by:
David Christal CISSP earned 500 total points
ID: 33651712
If MlandaT's suggestion doesn't work out try it with line 24 commented out.
Looks like you're executing the insert on both 24 & 25
0

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

In this article I will describe the Backup & Restore method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
Deploying a Microsoft Access application in a Citrix environment is not difficult but takes a few steps. However, Citrix system people are often of little help, as they typically know next to nothing about Access. The script provided here will take …
This video gives you a great overview about bandwidth monitoring with SNMP and WMI with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're looking for how to monitor bandwidth using netflow or packet s…
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

746 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now