Solved

Insert Records create Duplicate Records

Posted on 2010-09-10
3
259 Views
Last Modified: 2012-05-10
The code below is inserting additional data in another personal user information table.  however it keeps creating more than one record upon insert.  Why? and How do I fix it?
Protected Sub CreateUserWizard1_CreatedUser(ByVal sender As Object, ByVal e As System.EventArgs)
        'Insert Data into table and Add other pertinent data
        Dim UserNameTextBox As TextBox = CreateUserWizardStep1.ContentTemplateContainer.FindControl("UserName")
        Dim createDate As Date = DateTime.Now.ToString("MM/dd/yy")

        Dim rowsAffected As Integer
        Dim rIdentity As Integer = -1
        Try
            Dim myConnectionString As String
            Dim myQuery As String
            Dim myConnection As SqlConnection
            Dim cmd As SqlCommand


            myConnectionString = "Data Source=ServerIP;Initial Catalog=dbname; User Id=username; Password=password;"
            myQuery = "INSERT INTO aspnet_UserName (UserName, Firstname, Lastname, Prefixname, Suffixname, Nickname, " _
                & "CreateDate, AccountStatus, OrgNameID) VALUES ('" _
                & UserNameTextBox.Text & "', '" & Firstname.Text & "', '" & Lastname.Text & "', '" & PrefixnameDDL.Text & "', '" _
                & Suffix.Text & "', '" & Nickname.Text & "', '" & createDate & "', 'Enabled', '" _
                & getOrgNameID(OrganizationDDL.Text) & "') SELECT SCOPE_IDENTITY();"
            myConnection = New SqlConnection(myConnectionString)
            myConnection.Open()
            cmd = New SqlCommand(myQuery, myConnection)
            rowsAffected = cmd.ExecuteNonQuery()
            rIdentity = Integer.Parse(cmd.ExecuteScalar().ToString()) 'Get the @Identity Column

            myConnection.Close()
        Catch ex As Exception
            ClientScript.RegisterStartupScript(Me.GetType(), "alert", "<script language='javascript'>alert('CreateUserWizard1_CreatedUser produce the following error: " + ex.Message + "');</script>")
            Response.Write(ex.Message)
        End Try
    End Sub

Open in new window

0
Comment
Question by:Robert Treadwell
3 Comments
 
LVL 65

Expert Comment

by:rockiroads
ID: 33651225
one of two ways perhaps

create a unique index so that the operation fails

or

read the table, check the record exists or not
if it exists then update else insert
0
 
LVL 30

Expert Comment

by:MlandaT
ID: 33651245
1. You are using the CreateUserWizard.
2. When you use this wizard, the CreateUserWizard1_CreatedUser event only fires AFTER the user has already been created.
3. You are doing an insert there... which is creating the duplicate user.

With the CreateUserWizard, the user is automatically created for you, you dont need to execute an INSERT.

Comment out all the code in this method, compile and attempt to create a user. You will see that the duplicate users are gone.
0
 
LVL 5

Accepted Solution

by:
David Christal CISSP earned 500 total points
ID: 33651712
If MlandaT's suggestion doesn't work out try it with line 24 commented out.
Looks like you're executing the insert on both 24 & 25
0

Featured Post

Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Deploying a Microsoft Access application in a Citrix environment is not difficult but takes a few steps. However, Citrix system people are often of little help, as they typically know next to nothing about Access. The script provided here will take …
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …
A short tutorial showing how to set up an email signature in Outlook on the Web (previously known as OWA). For free email signatures designs, visit https://www.mail-signatures.com/articles/signature-templates/?sts=6651 If you want to manage em…

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question