How to pass an array a subroutine Excel VBA

Posted on 2010-09-13
Last Modified: 2012-08-14

I am trying to write a script that scans the contents of the first cell in the first 52 columns, then askes the user which columns they have data in that they would like merged. Then I would like to take their response and pass it to a subroutine to merge the cells appropriately. However, I am having trouble passing an array to my subroutine. I keep getting "Run-time error '1004': Application-defined or object defined error" Below is the snippet of code i am referring to. The error highlights the portion of code where i am merging 2 cells together. I think there is some sort of type mismatch, because when I change "Column" to a specific number...say 3, then the code runs without errors and merges the cells properly in column 3.

Private Sub cmdOkay_Click()

Dim i As Long, msg As String, Check As String, boxa As String, boxb As String

Dim Arr(52, 1)

Dim j, k As Integer

j = 0

k = 0

'Generate a list of the selected items

With ListBox1

    For i = 0 To .ListCount - 1

        k = k + 1

        If .Selected(i) Then

            msg = msg & .List(i) & vbNewLine

            Arr(j, 1) = k + 1

            j = j + 1

        End If

    Next i

End With



If Check = vbYes Then


    If UserForm1.CheckBox3.Value = True Then

        Module4.Carrier_Merge Arr

    End If


    'Unload the userform since user is happy with selection(s)

    Unload Me


    'User wants to try again, so clear listbox selections and

    'return user to the userform

    For i = 0 To ListBox1.ListCount - 1

        ListBox1.Selected(i) = False


End If




End Sub

Sub Carrier_Merge(ArrValues())

Dim i

Dim row1 As Integer

Dim row2 As Integer

Dim Column

Column = 0

row1 = 2

row2 = 3

Do Until IsEmpty(Range("A" & row1))

    If Right(Range("A" & row1), 2) <> "_3" And Right(Range("A" & row2), 2) = "_3" Then


        For i = 0 To UBound(ArrValues)

            Column = ArrValues(i, 1)

            Worksheets("Cell Site Demand").Range(Cells(row1, Column), Cells(row2, Column)).Merge

        Next i



       row1 = row1 + 2

       row2 = row2 + 2




    row1 = row1 + 1

    row2 = row2 + 1


    End If





end sub

Open in new window

Question by:towster2
LVL 58

Expert Comment

ID: 33666670
Pass it as a type Variant

Sub Carrier_Merge(ByVal ArrValues as Variant)

And just use it normally as you would an array.
LVL 33

Accepted Solution

Norie earned 500 total points
ID: 33674006
Are you sure the error is caused by the array?

Sounds to me that it's being passed OK, if it wasn't then an error would have been raised earlier and the message wouldn't be the one you describe.

One thing you might want to consider is that you only reference a worksheet once in the sub that does the merging.

That means that Range and Cells will be looking at the active sheet.

It might be worth fixing that.

Then I suggest you put a watch on the variable column to check if it's getting the right value from the array.

PS You might want to consider using another name for that variable - Column is a VBA property of ranges etc

Author Closing Comment

ID: 33674612
Thanks for your help. You were dead on!

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

The System Center Operations Manager 2012, known as SCOM, is a part of the Microsoft system center product that provides the user with infrastructure monitoring and application performance monitoring. SCOM monitors:   Windows or UNIX/LinuxNetwo…
This collection of functions covers all the normal rounding methods of just about any numeric value.
This Micro Tutorial will demonstrate the scrolling table in Microsoft Excel using the INDEX function.
This Micro Tutorial will demonstrate how to create pivot charts out of a data set. I also added a drop-down menu which allows to choose from different categories in the data set and the chart will automatically update.

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now