Solved

SQL Server database mail problem

Posted on 2010-09-15
6
1,247 Views
Last Modified: 2012-05-10
I am using the below code in SQL Server 2008 to query the database and send an email to user(s) based on the criteria in my select statement.

Problem is, that the variable @Emails is not getting anything. It should get the email address or multiple email address of the query to send using database mail.

I know that the query is returning rows, because if I comment out the "USE msdb" and below, I get a table of results. When I uncomment that code, I get an error which says, "At least one of the following parameters must be specified. "@recipients, @copy_recipients, @blind_copy_recipients"." So I know that it is not getting the @reciepents from the query.

Please help.
Thank you!!
USE BurgoyneMusic



GO

Declare @Emails varchar(50)



Select @Emails=@Emails + (a.Email) From Student As a Where exists (SELECT * From CreditCard As b WHERE a.StudentID = b.StudentID And b.CCMonth = month(DATEADD("m",-1,GETDATE())) And b.CCYear = DATEPART(year,GETDATE()))



USE msdb

EXEC sp_send_dbmail @profile_name='MyProfile',

@recipients= @Emails,

@subject='subject',

@body='message body'

Open in new window

0
Comment
Question by:mlg101
  • 2
  • 2
  • 2
6 Comments
 
LVL 11

Expert Comment

by:Larissa T
Comment Utility
null +'something' produce null
Initialize @Emails to empty string
----------------------
select @Emails=''
Select @Emails=@Emails + (a.Email) From Student As a Where exists (SELECT * From CreditCard As b WHERE a.StudentID = b.StudentID And b.CCMonth = month(DATEADD("m",-1,GETDATE())) And b.CCYear = DATEPART(year,GETDATE()))
0
 
LVL 4

Expert Comment

by:pbarry1
Comment Utility
Hi,

could you please do a "PRINT @Emails" just before the "USE msdb" to see what is the result of the query.  It looks like you're not putting a separator between the email addresses.  So you're probably getting something like: "email1@abc.comemail2@abc.comemail3@abc.com ..." which is not a valid address.  

If you want to see the detailed error, you can look in the logging tables.  Here's one:
   SELECT * FROM msdb.dbo.sysmail_faileditems

P.S. You don't need to change the database context with "USE msdb".  You can prefix the call to sp_send_dbmail like this:
EXEC msdb..sp_send_dbmail @profile_name='MyProfile',
@recipients= @Emails,
@subject='subject',
@body='message body'
0
 
LVL 1

Author Comment

by:mlg101
Comment Utility
Tro- I will try that when I get back to computer.

Pbarry- I designed my data to only return one row to start testing but I will try that too. And if I don't say "use msdb" then send dbmail is not declared.
0
IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 
LVL 4

Accepted Solution

by:
pbarry1 earned 250 total points
Comment Utility
One more thing,  unless you're using the "SET CONCAT_NULL_YIELDS_NULL OFF;" setting, if your query returns a record with a NULL email address, you'll end up with a NULL string.  You should check for NULL email addresses and replace it with something you want:  For instance:

Select @Emails=@Emails + ISNULL(a.Email, '') From Student As a Where...

As for the "USE msdb", I'm not sure why you get an error message, but this one will work (adding the "dbo" schema):
EXEC msdb.dbo.sp_send_dbmail @profile_name='MyProfile',
@recipients= @Emails,
@subject='subject',
@body='message body'
0
 
LVL 1

Author Comment

by:mlg101
Comment Utility
pbarry - I tried the ISNULL and it gave me the error, "the isnull property requires 2 arguments". But I did change the EXEC msdb.dbo.sp_....to what you said and it was fine. Still not getting anything for @Emails. I tried "print @Emails" and it did nothing. Then I checked the error log like you suggested and it did not have an error for my recent tries with the way it all is.

Tro- I tried your new select @Emails = "Select....etc. and with the quotes around the 2nd Select, it says my argument is too long. It has to be 128 charachters or less. If I do it without the quotes around the 2nd select, then it says incorrect syntax near Select.
0
 
LVL 11

Assisted Solution

by:Larissa T
Larissa T earned 250 total points
Comment Utility
1) emails  must be separated by ","
2) isnull does need 2 arguments, make sure you copy all code as is.
3) "print did nothing" - confirms that @Emails value is null after your select. Some of a.emails are nulls
4) what it means "with the quotes around the 2nd Select..." Can you post statement that gives you error?

try this
-----------------------
Declare @Emails varchar(526)
Select @Emails=isnull(@Emails+',','') + a.Email From Student As a
Where a.Email>''
and exists (SELECT * From CreditCard As b WHERE a.StudentID = b.StudentID And b.CCMonth = month(DATEADD("m",-1,GETDATE())) And b.CCYear = DATEPART(year,GETDATE()))

print '@Emails='+ isnull(@Emails, 'empty')
--USE msdb
EXEC msdb..sp_send_dbmail @profile_name='MyProfile',
@recipients= @Emails,
@subject='subject',
@body='message body'
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Having an SQL database can be a big investment for a small company. Hardware, setup and of course, the price of software all add up to a big bill that some companies may not be able to absorb.  Luckily, there is a free version SQL Express, but does …
Everyone has problem when going to load data into Data warehouse (EDW). They all need to confirm that data quality is good but they don't no how to proceed. Microsoft has provided new task within SSIS 2008 called "Data Profiler Task". It solve th…
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Viewers will learn how to use the UPDATE and DELETE statements to change or remove existing data from their tables. Make a table: Update a specific column given a specific row using the UPDATE statement: Remove a set of values using the DELETE s…

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now