Solved

create Union Query problems

Posted on 2010-09-17
12
529 Views
Last Modified: 2012-05-10
Dear Experts,

I have a piece of code which used to work, but not longer does.  What the code does is merge (Union All) 2 queries together.  

Basically there is a table with the SQL string stored in it with the following fields:

SearchID (Autonumber)
SearchName (Text)
SearchTime (Date/Time)
SearchString (Memo)
Merge (Yes/No)

The search string field basically contains the sql for the query (without the; at the end) – e.g.

SELECT [Tbl-Contacts].* FROM [Tbl-Contacts] WHERE ((([Tbl-Contacts].SumBoard) Is Not Null) AND (([Tbl-Contacts].SumFinance) Is Not Null) AND (([Tbl-Contacts].SumHR) Is Not Null) AND (([Tbl-Contacts].SumRD) Is Not Null)) AND (([Tbl-Contacts].SumReg) Is Not Null) AND (([Tbl-Contacts].SumSales) Is Not Null) AND (([Tbl-Contacts].State)='Delaware')

The attached code should go through the table picking up the searchstring where Merge = -1 and join the statements up with a union all and then add that as a new record in the table, the result would look something like this …

SELECT [Tbl-Contacts].* FROM [Tbl-Contacts] WHERE ((([Tbl-Contacts].SumBoard) Is Not Null) AND (([Tbl-Contacts].SumFinance) Is Not Null) AND (([Tbl-Contacts].SumHR) Is Not Null) AND (([Tbl-Contacts].SumRD) Is Not Null)) AND (([Tbl-Contacts].SumReg) Is Not Null) AND (([Tbl-Contacts].SumSales) Is Not Null) AND (([Tbl-Contacts].State)='Delaware')
Union All
SELECT [Tbl-Contacts].* FROM [Tbl-Contacts] WHERE ((([Tbl-Contacts].SumBoard)=0) AND (([Tbl-Contacts].SumFinance) Is Not Null) AND (([Tbl-Contacts].SumHR) Is Not Null) AND (([Tbl-Contacts].SumRD) Is Not Null)) AND (([Tbl-Contacts].SumReg) Is Not Null) AND (([Tbl-Contacts].SumSales) Is Not Null) AND ((([Tbl-Contacts].Firm)  Like '*GSK*'))

However result that is produced doesn’t include the first record (however many records are selected for merging

Can anybody help?

Private Sub Merge_Click()

  

    

    ' ********* Check Bit  *********

If Len(Me!TextName & "") = 0 Then

       MsgBox "You must add a Name", vbExclamation

        Cancel = True

        Exit Sub

    End If

    

DoCmd.Save

Dim rs As DAO.Recordset, uSQL As String

Set rs = CurrentDb.OpenRecordset("select * from [Tbl-SavedSearches] where merge=-1")

uSQL = ""

Do Until rs.EOF

uSQL = uSQL & " Union All " & rs("SearchString")





rs.MoveNext

Loop



rs.Close



uSQL = Mid(uSQL, 11)

Debug.Print uSQL

   

    

' ********* Save Bit  *********

Dim rs1 As DAO.Recordset

Set rs1 = CurrentDb.OpenRecordset("tbl-SavedSearches")

rs1.AddNew

rs1!SearchName = Me.[TextName]

rs1!SearchTime = Now()

rs1!SearchString = uSQL

rs1.Update

rs1.Close



  

    Dim stDocName As String

    Dim stLinkCriteria As String



    stDocName = "Frm-SavedSearches"

    DoCmd.Close acForm, "Frm-SavedSearches"

    DoCmd.OpenForm stDocName, , , stLinkCriteria

    DoCmd.Close acForm, "Frm-Merge-Searches"



End Sub

Open in new window

0
Comment
Question by:correlate
  • 5
  • 3
  • 2
  • +2
12 Comments
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 33701564
try

rs.movefirst    'ADD this line before doing the loop

Do Until rs.EOF
0
 
LVL 12

Expert Comment

by:Paul_Harris_Fusion
ID: 33701626
If I understand you correctly, it is the first SQL statement that is missing not the first record returned from the entire statement.

Try replacing the inner loop with this:

Dim rs As DAO.Recordset, uSQL As String
Set rs = CurrentDb.OpenRecordset("select * from [Tbl-SavedSearches] where merge=-1")
uSQL = ""

If not rs.BOF then
   rs.MoveFirst

   Do While not rs.EOF
        uSQL = uSQL & " Union All " & rs("SearchString")
       rs.MoveNext
   Loop

End if


0
 
LVL 31

Expert Comment

by:Helen_Feddema
ID: 33701666
Also, you might want to replace the IsNull function with Nz, and check for Nz([FieldName]) <> 0 or <> "" (depending on whether the field is text or numeric), since often one wants to exclude blanks or zeroes as well as Nulls.
0
 

Author Comment

by:correlate
ID: 33701923
Hi Capricorn 1 & Paul Harris,

I tried both, but alas I'm getting the same result, its still only only picking up on the 1,

here I'm attaching what I am using as Paul's code, I tried, I'll attach Capricorn's version in the next comment
Private Sub Merge_Click()

  

    

    ' ********* Check Bit  *********

If Len(Me!TextName & "") = 0 Then

       MsgBox "You must add a Name", vbExclamation

        Cancel = True

        Exit Sub

    End If

    

DoCmd.Save



Dim rs As DAO.Recordset, uSQL As String

Set rs = CurrentDb.OpenRecordset("select * from [Tbl-SavedSearches] where merge=-1")

uSQL = ""



If Not rs.BOF Then

   rs.MoveFirst



   Do While Not rs.EOF

        uSQL = uSQL & " Union All " & rs("SearchString")

       rs.MoveNext

   Loop



End If



'uSQL = Mid(uSQL, 11)

'Debug.Print uSQL

   

    

' ********* Save Bit  *********

Dim rs1 As DAO.Recordset

Set rs1 = CurrentDb.OpenRecordset("tbl-SavedSearches")

rs1.AddNew

rs1!SearchName = Me.[TextName]

rs1!SearchTime = Now()

rs1!SearchString = uSQL

rs1.Update

rs1.Close



  

    Dim stDocName As String

    Dim stLinkCriteria As String



    stDocName = "Frm-SavedSearches"

    DoCmd.Close acForm, "Frm-SavedSearches"

    DoCmd.OpenForm stDocName, , , stLinkCriteria

    DoCmd.Close acForm, "Frm-Merge-Searches"



End Sub

Open in new window

0
 

Author Comment

by:correlate
ID: 33701948
Capricorn's code...
Private Sub Merge_Click()

  

    

    ' ********* Check Bit  *********

If Len(Me!TextName & "") = 0 Then

       MsgBox "You must add a Name", vbExclamation

        Cancel = True

        Exit Sub

    End If

    

DoCmd.Save

Dim rs As DAO.Recordset, uSQL As String

Set rs = CurrentDb.OpenRecordset("select * from [Tbl-SavedSearches] where merge=-1")

uSQL = ""

rs.MoveFirst

Do Until rs.EOF

uSQL = uSQL & " Union All " & rs("SearchString")





rs.MoveNext

Loop



rs.Close



uSQL = Mid(uSQL, 11)

Debug.Print uSQL

   

    

' ********* Save Bit  *********

Dim rs1 As DAO.Recordset

Set rs1 = CurrentDb.OpenRecordset("tbl-SavedSearches")

rs1.AddNew

rs1!SearchName = Me.[TextName]

rs1!SearchTime = Now()

rs1!SearchString = uSQL

rs1.Update

rs1.Close



  

    Dim stDocName As String

    Dim stLinkCriteria As String



    stDocName = "Frm-SavedSearches"

    DoCmd.Close acForm, "Frm-SavedSearches"

    DoCmd.OpenForm stDocName, , , stLinkCriteria

    DoCmd.Close acForm, "Frm-Merge-Searches"



End Sub

Open in new window

0
 
LVL 119

Accepted Solution

by:
Rey Obrero earned 500 total points
ID: 33701986
try this


post the message box content
Private Sub Merge_Click()

  

    

    ' ********* Check Bit  *********

If Len(Me!TextName & "") = 0 Then

       MsgBox "You must add a Name", vbExclamation

        Cancel = True

        Exit Sub

    End If

    

DoCmd.Save

Dim rs As DAO.Recordset, uSQL As String

Set rs = CurrentDb.OpenRecordset("select * from [Tbl-SavedSearches] where merge=-1")

uSQL = ""



rs.movelast

msgbox rs.recordcount & " records found"



rs.MoveFirst

Do Until rs.EOF

uSQL = uSQL & " Union All " & rs("SearchString")





rs.MoveNext

Loop



rs.Close



uSQL = Mid(uSQL, 11)

Debug.Print uSQL

   

    

' ********* Save Bit  *********

Dim rs1 As DAO.Recordset

Set rs1 = CurrentDb.OpenRecordset("tbl-SavedSearches")

rs1.AddNew

rs1!SearchName = Me.[TextName]

rs1!SearchTime = Now()

rs1!SearchString = uSQL

rs1.Update

rs1.Close



  

    Dim stDocName As String

    Dim stLinkCriteria As String



    stDocName = "Frm-SavedSearches"

    DoCmd.Close acForm, "Frm-SavedSearches"

    DoCmd.OpenForm stDocName, , , stLinkCriteria

    DoCmd.Close acForm, "Frm-Merge-Searches"



End Sub

Open in new window

0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 47

Expert Comment

by:Dale Fye (Access MVP)
ID: 33702026
What are you attempting to achieve with the line:

uSQL = Mid(uSQL, 11)

0
 

Author Comment

by:correlate
ID: 33702133
Hi Capricorn1

Message = 1 records found
0
 
LVL 119

Expert Comment

by:Rey Obrero
ID: 33702149
that is the reason, why you are only getting one record
0
 

Author Comment

by:correlate
ID: 33702154
Hi fyed

This bit I believe cuts off the first 11 characters in the string otherwise the string would start " Union All SELECT..." rather than SELECT
0
 
LVL 47

Expert Comment

by:Dale Fye (Access MVP)
ID: 33702164
Duh!  brain cramp.
0
 

Author Closing Comment

by:correlate
ID: 33702384
Hi Capricorn1 - thanks for that - works a treat now - your comment made me check other codes in there and what I found was there was another RS! which ran on Open form that cleared out the ticks,
0

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

Introduction The Visual Basic for Applications (VBA) language is at the heart of every application that you write. It is your key to taking Access beyond the world of wizards into a world where anything is possible. This article introduces you to…
'Between' is such a common word we rarely think about it but in SQL it has a very specific definition we should be aware of. While most database vendors will have their own unique phrases to describe it (see references at end) the concept in common …
With Microsoft Access, learn how to start a database in different ways and produce different start-up actions allowing you to use a single database to perform multiple tasks. Specify a start-up form through options: Specify an Autoexec macro: Us…
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now