Solved

Comma with unknown meaning in VBA for recorded macro in Excel to query SQL Server

Posted on 2010-09-17
6
343 Views
Last Modified: 2012-05-10
I'm tring to dress up some code that I recorded in Excel with the macro recorder.  This code queries SQL Server and returns a table to Excel.  The recorder inserted some commas at the end of a line that appear to have no meaning.  But, when I take them out, I get a type mismatch error.

I have added some & _ to the recorded code to make it easier to read.  But you can spot two places where there is  this set of characters  ", " that cannot be taken out.  Can anyone tell me what the purpose of the commas are?  

Here is the code in working condition.  Notice the comma in the middle of the word FROM for the TSQL from clause.  There is another comma in the middle of the word AND inside the TSQL where clause.  If I take these commas and the quotation marks that encapsulate the commas out of the code, the code  bombs with a type mismatch.  Does anyone know why?


Sub MultipleCustsRecorded()
   ActiveSheet.Cells.ClearContents
   
    With ActiveSheet.ListObjects.Add(SourceType:=0, Source:= _
        "ODBC;DRIVER=SQL Server Native Client 10.0;SERVER=SQL1;UID=User;PWD=Password;" & _
        "APP=2007 Microsoft Office system;WSID=ZZZZZ;DATABASE=HJ_TestTBIData;" _
        , Destination:=Range("$A$1")).QueryTable
        .CommandText = Array( _
        "SELECT rptPreOrdersDetail.DueDate, rptPreOrdersDetail.RouteNo, rptPreOrdersDetail.CustNo, " & _
            "rptPreOrdersDetail.ItemNo, rptPreOrdersDetail.Package, rptPreOrdersDetail.Brand, " & _
            "rptPreOrdersDetail.CaseQty" & Chr(13) & "" & Chr(10) & _
            "F", "ROM HJ_TestTBIData.dbo.rptPreOrdersDetail rptPreOrdersDetail" & Chr(13) & "" & Chr(10) & _
        "WHERE (rptPreOrdersDetail.CustNo=29890) AND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'}) " & _
            "OR (rptPreOrdersDetail.CustNo=28765) " & _
            "A", "ND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'})" & Chr(13) & "" & Chr(10) & _
            "ORDER BY rptPreOrdersDetail.Package, rptPreOrdersDetail.ItemNo")
        .RowNumbers = False
        .FillAdjacentFormulas = False
        .PreserveFormatting = True
        .RefreshOnFileOpen = False
        .BackgroundQuery = True
        .RefreshStyle = xlInsertDeleteCells
        .SavePassword = False
        .SaveData = True
        .AdjustColumnWidth = True
        .RefreshPeriod = 0
        .PreserveColumnInfo = True
        .ListObject.DisplayName = "Table_Query_from_HJPreOrders"
        .Refresh BackgroundQuery:=False
    End With
End Sub

Open in new window

0
Comment
Question by:Lynn Huff
  • 4
  • 2
6 Comments
 
LVL 85

Accepted Solution

by:
Rory Archibald earned 500 total points
ID: 33702794
Your SQL string is being built up using an Array and the commas are separating the elements of the array. You could simply remove the array and use one long string.
0
 
LVL 3

Author Comment

by:Lynn Huff
ID: 33703591
Rorya, I tried your suggestion.  The result was a "syntax error."
0
 
LVL 85

Expert Comment

by:Rory Archibald
ID: 33703976
What exactly did you use?
0
What is SQL Server and how does it work?

The purpose of this paper is to provide you background on SQL Server. It’s your self-study guide for learning fundamentals. It includes both the history of SQL and its technical basics. Concepts and definitions will form the solid foundation of your future DBA expertise.

 
LVL 3

Author Comment

by:Lynn Huff
ID: 33704161
This is the code i tried that produced a syntax error.
Sub MultipleCustsRecorded()
   ActiveSheet.Cells.ClearContents
   
    With ActiveSheet.ListObjects.Add(SourceType:=0, Source:= _
        "ODBC;DRIVER=SQL Server Native Client 10.0;SERVER=SQL1;UID=User;PWD=Password;" & _
        "APP=2007 Microsoft Office system;WSID=ZZZZZ;DATABASE=HJ_TestTBIData;" _
        , Destination:=Range("$A$1")).QueryTable
        .CommandText = "SELECT rptPreOrdersDetail.DueDate, rptPreOrdersDetail.RouteNo, rptPreOrdersDetail.CustNo, " & _
            "rptPreOrdersDetail.ItemNo, rptPreOrdersDetail.Package, rptPreOrdersDetail.Brand, " & _
            "rptPreOrdersDetail.CaseQty" & Chr(13) & "" & Chr(10) & _
            "F", "ROM HJ_TestTBIData.dbo.rptPreOrdersDetail rptPreOrdersDetail" & Chr(13) & "" & Chr(10) & _
        "WHERE (rptPreOrdersDetail.CustNo=29890) AND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'}) " & _
            "OR (rptPreOrdersDetail.CustNo=28765) " & _
            "A", "ND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'})" & Chr(13) & "" & Chr(10) & _
            "ORDER BY rptPreOrdersDetail.Package, rptPreOrdersDetail.ItemNo"
        .RowNumbers = False
        .FillAdjacentFormulas = False
        .PreserveFormatting = True
        .RefreshOnFileOpen = False
        .BackgroundQuery = True
        .RefreshStyle = xlInsertDeleteCells
        .SavePassword = False
        .SaveData = True
        .AdjustColumnWidth = True
        .RefreshPeriod = 0
        .PreserveColumnInfo = True
        .ListObject.DisplayName = "Table_Query_from_HJPreOrders"
        .Refresh BackgroundQuery:=False
    End With
End Sub

Open in new window

0
 
LVL 3

Author Comment

by:Lynn Huff
ID: 33704168
That's wrong, let me try again in a minute.
0
 
LVL 3

Author Comment

by:Lynn Huff
ID: 33704201
You were right after all.  I followed only part of your suggestion the first time.  I took out the array, but forgot to take out the commas at the same time.  I'm so used to testing after changing only one item that I forgot those two changes needed to be enacted together.

Thanks.

I'll award points.
0

Featured Post

Visualize your virtual and backup environments

Create well-organized and polished visualizations of your virtual and backup environments when planning VMware vSphere, Microsoft Hyper-V or Veeam deployments. It helps you to gain better visibility and valuable business insights.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This code takes an Excel list of URL’s and adds a header titled “URL List”. It then searches through all URL’s in column “A”, looking for duplicates. When a duplicate is found, it is moved to the top of the list. The duplicate URL’s are then highlig…
When you see single cell contains number and text, and you have to get any date out of it seems like cracking our heads.
The viewer will learn how to create a normally distributed random variable in Excel, use a normal distribution to simulate the return on an investment over a period of years, Create a Monte Carlo simulation using a normal random variable, and calcul…
Excel styles will make formatting consistent and let you apply and change formatting faster. In this tutorial, you'll learn how to use Excel's built-in styles, how to modify styles, and how to create your own. You'll also learn how to use your custo…

740 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question