Solved

Comma with unknown meaning in VBA for recorded macro in Excel to query SQL Server

Posted on 2010-09-17
6
335 Views
Last Modified: 2012-05-10
I'm tring to dress up some code that I recorded in Excel with the macro recorder.  This code queries SQL Server and returns a table to Excel.  The recorder inserted some commas at the end of a line that appear to have no meaning.  But, when I take them out, I get a type mismatch error.

I have added some & _ to the recorded code to make it easier to read.  But you can spot two places where there is  this set of characters  ", " that cannot be taken out.  Can anyone tell me what the purpose of the commas are?  

Here is the code in working condition.  Notice the comma in the middle of the word FROM for the TSQL from clause.  There is another comma in the middle of the word AND inside the TSQL where clause.  If I take these commas and the quotation marks that encapsulate the commas out of the code, the code  bombs with a type mismatch.  Does anyone know why?


Sub MultipleCustsRecorded()

   ActiveSheet.Cells.ClearContents

   

    With ActiveSheet.ListObjects.Add(SourceType:=0, Source:= _

        "ODBC;DRIVER=SQL Server Native Client 10.0;SERVER=SQL1;UID=User;PWD=Password;" & _

        "APP=2007 Microsoft Office system;WSID=ZZZZZ;DATABASE=HJ_TestTBIData;" _

        , Destination:=Range("$A$1")).QueryTable

        .CommandText = Array( _

        "SELECT rptPreOrdersDetail.DueDate, rptPreOrdersDetail.RouteNo, rptPreOrdersDetail.CustNo, " & _

            "rptPreOrdersDetail.ItemNo, rptPreOrdersDetail.Package, rptPreOrdersDetail.Brand, " & _

            "rptPreOrdersDetail.CaseQty" & Chr(13) & "" & Chr(10) & _

            "F", "ROM HJ_TestTBIData.dbo.rptPreOrdersDetail rptPreOrdersDetail" & Chr(13) & "" & Chr(10) & _

        "WHERE (rptPreOrdersDetail.CustNo=29890) AND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'}) " & _

            "OR (rptPreOrdersDetail.CustNo=28765) " & _

            "A", "ND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'})" & Chr(13) & "" & Chr(10) & _

            "ORDER BY rptPreOrdersDetail.Package, rptPreOrdersDetail.ItemNo")

        .RowNumbers = False

        .FillAdjacentFormulas = False

        .PreserveFormatting = True

        .RefreshOnFileOpen = False

        .BackgroundQuery = True

        .RefreshStyle = xlInsertDeleteCells

        .SavePassword = False

        .SaveData = True

        .AdjustColumnWidth = True

        .RefreshPeriod = 0

        .PreserveColumnInfo = True

        .ListObject.DisplayName = "Table_Query_from_HJPreOrders"

        .Refresh BackgroundQuery:=False

    End With

End Sub

Open in new window

0
Comment
Question by:Lynn Huff
  • 4
  • 2
6 Comments
 
LVL 85

Accepted Solution

by:
Rory Archibald earned 500 total points
ID: 33702794
Your SQL string is being built up using an Array and the commas are separating the elements of the array. You could simply remove the array and use one long string.
0
 
LVL 3

Author Comment

by:Lynn Huff
ID: 33703591
Rorya, I tried your suggestion.  The result was a "syntax error."
0
 
LVL 85

Expert Comment

by:Rory Archibald
ID: 33703976
What exactly did you use?
0
Highfive + Dolby Voice = No More Audio Complaints!

Poor audio quality is one of the top reasons people don’t use video conferencing. Get the crispest, clearest audio powered by Dolby Voice in every meeting. Highfive and Dolby Voice deliver the best video conferencing and audio experience for every meeting and every room.

 
LVL 3

Author Comment

by:Lynn Huff
ID: 33704161
This is the code i tried that produced a syntax error.
Sub MultipleCustsRecorded()

   ActiveSheet.Cells.ClearContents

   

    With ActiveSheet.ListObjects.Add(SourceType:=0, Source:= _

        "ODBC;DRIVER=SQL Server Native Client 10.0;SERVER=SQL1;UID=User;PWD=Password;" & _

        "APP=2007 Microsoft Office system;WSID=ZZZZZ;DATABASE=HJ_TestTBIData;" _

        , Destination:=Range("$A$1")).QueryTable

        .CommandText = "SELECT rptPreOrdersDetail.DueDate, rptPreOrdersDetail.RouteNo, rptPreOrdersDetail.CustNo, " & _

            "rptPreOrdersDetail.ItemNo, rptPreOrdersDetail.Package, rptPreOrdersDetail.Brand, " & _

            "rptPreOrdersDetail.CaseQty" & Chr(13) & "" & Chr(10) & _

            "F", "ROM HJ_TestTBIData.dbo.rptPreOrdersDetail rptPreOrdersDetail" & Chr(13) & "" & Chr(10) & _

        "WHERE (rptPreOrdersDetail.CustNo=29890) AND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'}) " & _

            "OR (rptPreOrdersDetail.CustNo=28765) " & _

            "A", "ND (rptPreOrdersDetail.DueDate={ts '2010-09-15 00:00:00'})" & Chr(13) & "" & Chr(10) & _

            "ORDER BY rptPreOrdersDetail.Package, rptPreOrdersDetail.ItemNo"

        .RowNumbers = False

        .FillAdjacentFormulas = False

        .PreserveFormatting = True

        .RefreshOnFileOpen = False

        .BackgroundQuery = True

        .RefreshStyle = xlInsertDeleteCells

        .SavePassword = False

        .SaveData = True

        .AdjustColumnWidth = True

        .RefreshPeriod = 0

        .PreserveColumnInfo = True

        .ListObject.DisplayName = "Table_Query_from_HJPreOrders"

        .Refresh BackgroundQuery:=False

    End With

End Sub

Open in new window

0
 
LVL 3

Author Comment

by:Lynn Huff
ID: 33704168
That's wrong, let me try again in a minute.
0
 
LVL 3

Author Comment

by:Lynn Huff
ID: 33704201
You were right after all.  I followed only part of your suggestion the first time.  I took out the array, but forgot to take out the commas at the same time.  I'm so used to testing after changing only one item that I forgot those two changes needed to be enacted together.

Thanks.

I'll award points.
0

Featured Post

Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

Join & Write a Comment

In this article I will describe the Backup & Restore method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
Use this article to create a batch file to backup a Microsoft SQL Server database to a Windows folder.  The folder can be on the local hard drive or on a network share.  This batch file will query the SQL server to get the current date & time and wi…
Viewers will learn the basics of slicers and timelines for both PivotTables and standard Excel tables in Excel 2013.
The viewer will learn how to simulate a series of coin tosses with the rand() function and learn how to make these “tosses” depend on a predetermined probability. Flipping Coins in Excel: Enter =RAND() into cell A2: Recalculate the random variable…

758 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now