• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 577
  • Last Modified:

javascript code error

I think I have looked at this took long because I cannot find my error - I believe the error is in the 1st js file - When I try to open htm file I see formatting etc but I do not see the 1-10 items
Could someone please take a look - any help or direction is appreciated.
 experts-exch-question.docx
0
NannaG
Asked:
NannaG
  • 5
  • 4
  • 2
1 Solution
 
cyberkiwiCommented:
First js file.
You have 2 cases where normal"  had no starting double-quote.
1 case where rgb...)" has an extra double quote at the end.
1 case where "rgb...)" has double quotes at the beginning and end.
function eventSource(e) {
   var IE=document.attachEvent ? true:false;
   var DOM=document.addEventListener ? true: false;
   if (IE) return event.srcElement;
   else if (DOM) return e.currentTarget;
}

function setUpTranslation() { 
var phrases=document.getElementsByTagName ("p");
for (var i=0; i < phrases.length; i++) {
phrases[i].number = i; 
phrases[i].childNodes[1].innerHTML = french[i];
phrases[i].childNodes[1].style.fontStyle = "italic";
phrases[i].childNodes[1].style.color = "#000";

phrases[i].onmousedown=function() {
this.childNodes[1].innerHTML=english[this.number];
this.childNodes[1].style.fontStyle= "normal";
this.childNodes[1].style.color= rgb(155, 102, 102);
}
phrases[i].onmouseup=function() {
this.childNodes[1].innerHTML=french[this.number];
this.childNodes[1].style.fontStyle="italic";
thischildNodes[1].style.color="#000";
}
}
}

function swapFE(e) {
var phrase=eventSource(e);
if (IE) phrase.attachEvent("on"+ mousedown, swapFE);
else if (DOM) phrase.addEventListener(onmousedown, swapFE, false);
var phrasenum=parseInt (phrase.innerHTML.previousSibling);
phrase.innerHTML.nodeValue=english[phrasenum - 1];
phrase.style.fontStyle="normal";
phrase.style.color=rgb(155, 102, 102);
}


function swapEF(e) {
var phrase=eventSource(e);
if (IE) phrase.attachEvent("on"+ mouseup, swapEF);
else if (DOM) phrase.addEventListener(onmouseup, swapEF, false);
var phrasenum=parseInt (phrase.innerHTML.previousSibling);
phrase.innerHTML.nodeValue=french [phrasenum - 1];
phrase.style.fontStyle="italic";
phrase.style.color="black";
}

Open in new window

0
 
cyberkiwiCommented:
Actually, the double-quotes are correct.
It should be

2 cases where normal"  had no starting double-quote.
1 case where rgb...)" had no starting double-quote.

function eventSource(e) {
   var IE=document.attachEvent ? true:false;
   var DOM=document.addEventListener ? true: false;
   if (IE) return event.srcElement;
   else if (DOM) return e.currentTarget;
}

function setUpTranslation() { 
var phrases=document.getElementsByTagName ("p");
for (var i=0; i < phrases.length; i++) {
phrases[i].number = i; 
phrases[i].childNodes[1].innerHTML = french[i];
phrases[i].childNodes[1].style.fontStyle = "italic";
phrases[i].childNodes[1].style.color = "#000";

phrases[i].onmousedown=function() {
this.childNodes[1].innerHTML=english[this.number];
this.childNodes[1].style.fontStyle= "normal";
this.childNodes[1].style.color= "rgb(155, 102, 102)";
}
phrases[i].onmouseup=function() {
this.childNodes[1].innerHTML=french[this.number];
this.childNodes[1].style.fontStyle="italic";
thischildNodes[1].style.color="#000";
}
}
}

function swapFE(e) {
var phrase=eventSource(e);
if (IE) phrase.attachEvent("on"+ mousedown, swapFE);
else if (DOM) phrase.addEventListener(onmousedown, swapFE, false);
var phrasenum=parseInt (phrase.innerHTML.previousSibling);
phrase.innerHTML.nodeValue=english[phrasenum - 1];
phrase.style.fontStyle="normal";
phrase.style.color="rgb(155, 102, 102)";
}


function swapEF(e) {
var phrase=eventSource(e);
if (IE) phrase.attachEvent("on"+ mouseup, swapEF);
else if (DOM) phrase.addEventListener(onmouseup, swapEF, false);
var phrasenum=parseInt (phrase.innerHTML.previousSibling);
phrase.innerHTML.nodeValue=french [phrasenum - 1];
phrase.style.fontStyle="italic";
phrase.style.color="black";
}

Open in new window

0
 
NannaGAuthor Commented:
Ok, I made those corrections, Thank You,  but I still do not see my content - Pleae see the attached img
IMG.docx
0
Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

 
VeganBenCommented:
I haven't been through all your source code, but this line stands out for two reasons:

phrase.innerHTML.nodeValue=french [phrasenum - 1];


phrase.innerHTML will be fine.. you don't need "nodeValue"
and the space between "french" and the square brackets has to go.

In the English half of it:
phrase.innerHTML.nodeValue=english[phrasenum - 1];


just remove the "nodeValue"
0
 
NannaGAuthor Commented:
I've made the additional nodevalue removal - no changes though ??
0
 
VeganBenCommented:
can we see where you instantiate and populate the french and english arrays?
0
 
cyberkiwiCommented:
Instead of making corrections, can you just use http:#a33712736 as your js file?
It works for me as-is.
0
 
NannaGAuthor Commented:
I am reviewing my files also, do I need to send you anything other files - I have .css also
0
 
NannaGAuthor Commented:
Hum?  Do you think this is a browser issue? I'm using vista,  IE 7
0
 
NannaGAuthor Commented:
Well I'll be!! I changed to my laptop , Windows 7 and guess what - yep - it does work: Thank you so much for taking your time to assist me. Your Great!!
0
 
cyberkiwiCommented:
I was just firing up Windows 2008 and IE8 to have a look, but I'm glad it worked out for you.

Regards
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

  • 5
  • 4
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now