I have this function that returns data from a table. I use the main function to retrieve all the data I want then I try to break it down from a second function cause I have different needs in the reports that I use.
This is the function:
-----------------------
declare @d datetime
set @d = getdate() + {?Days}
select * from dbo.ServiceViewBatch( @d )
WHERE serviceType = 'VMF'
----------------------
I need to partition the result for this to be the same as another function I used to use to get the same results, this was the old function. Now, I've tried adding the partition bit to the function above but it keeps saying the BY bit is wrong. Any ideas how to integrate the partition bit in the the function above? It's ONLY the partition bit I need to integrate, same BY statements as all of those are in the table I get the data from.
--------------------
RETURN ( SELECT * FROM (
SELECT countryCode, cityCode, itemCode, storeType, vendorCode, gridCodeX, gridCodeY, facings, brand, rc, storeCode, storeName, ARABIC, ItemName, upcCode, TREF,
ROW_NUMBER() OVER ( PARTITION BY countryCode, cityCode, storeCode, gridCodeX, vendorCode ORDER BY vendorCode DESC) rnum
FROM dbo.ScheduleView
WHERE (CASE DATEPART(weekday, @date )
WHEN 1 THEN [SunVMF] WHEN 2 THEN [MonVMF] WHEN 3 THEN [TueVMF] WHEN 4 THEN [WedVMF] WHEN 5 THEN [ThuVMF] WHEN 6 THEN [FriVMF] WHEN 7 THEN
[SatVMF] END = 1)) temp
WHERE rnum = 1
)
----------------------------
Guy Hengel [angelIII / a3]Billing EngineerCommented:
>Now, I've tried adding the partition bit to the function above but it keeps saying the BY bit is wrong.
can you please clarify what exctly you are adding when it fails?
I mean, the code, as posted, seems fine ...
0
kenuk110Author Commented:
Sorry, yeah I see what you mean.
This is what I run:
declare @d datetime
set @d = getdate() + {?Days}
select * from dbo.ServiceViewBatch( @d )
WHERE serviceType = 'VMF'
I'd like to have it like this
declare @d datetime
set @d = getdate() + {?Days}
select *, ROW_NUMBER() OVER ( PARTITION BY countryCode, cityCode, storeCode, gridCodeX, vendorCode ORDER BY vendorCode DESC) from dbo.ServiceViewBatch( @d )
WHERE serviceType = 'VMF'
When I put this in it says it there is an problem with the PARTITION BY bit. It's obviously wrong but I really don't have the skill to figure out which bit is wrong!!
An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.
One of a set of tools we're offering as a way of saying thank you for being a part of the community.
It still brings back back all the records and not just a single record, as in I should only see one record for each gridcodex for that store in that city and in that country.
Let me see if I can figure it out or give you some more info.
0
kenuk110Author Commented:
Hi again,
I'm stuck, I have tried 'partitioning' with just the gridcodex, the storecode, most of them but the result still returns all the records for a gridcodex.
This is the function that I'm using to get the main data:
ALTER function [dbo].[ServiceViewBatch](@date date)
returns table
as
RETURN WITH cte AS (
SELECT [ServiceValue]
, [ItemName]
, [countryCode]
, [storeCode]
, [cityCode]
, [itemCode]
, [storeType]
, [vendorCode]
, [upcCode]
, [rc]
, [gridCodeX]
, [gridCodeY]
, [facings]
, [brand]
, [serviceDay]
, [serviceType]
, [ARABIC]
, [TREF]
, ROW_NUMBER()
OVER (ORDER BY CountryCode, CityCode, StoreCode, RC, servicetype, gridcodeX, itemCode) rnum
FROM [T1].[dbo].[ServiceSchedule]
WHERE serviceday = DATENAME(WEEKDAY, @date)
)
-- final selection
SELECT a.*
, rt.svSum as RunTotal
, convert(int, ceiling(rt.svSum/750)) as BatchGroup
FROM cte a
CROSS APPLY(
SELECT SUM(serviceValue) svSum
FROM cte b
WHERE b.rnum <= a.rnum
) rt
------------------------------
The original code is passes the WHERE statement correctly but when it runs the updated code it brings back all the records.
declare @d datetime
set @d = getdate() + {?Days}
select * from dbo.ServiceViewBatch( @d )
WHERE serviceType = 'VMF'
Really stuck now as to how to select the data so it'd distinct by countryCode, cityCode, storeCode, gridCodeX.
I have to apologize, I think I've mis comminicated the solution. The function you have sent back needs to be just how it was, it's the main function I use to get back all the data I need. From there I call the function but put in where statements like WHERE serviceType = 'VMF' etc. It just breaks down the full view to just the type of records I need.
The one I'm having trouble with is the small query that I pass to the function, this script:
declare @d datetime
set @d = getdate() + {?Days}
select v.*
, ROW_NUMBER() OVER ( PARTITION BY countryCode, cityCode, storeCode, gridCodeX, vendorCode ORDER BY vendorCode DESC)
from dbo.ServiceViewBatch( @d ) v
WHERE v.serviceType = 'VMF'
I have added this to get what I hoped was distinct per gridcodeX per store per city per country but it brings back all the records attached to that gridcodex. I only actually need one record of any that has this gridcodex assigned to it, it's just the way I need to present the data for this report.
An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.
One of a set of tools we're offering as a way of saying thank you for being a part of the community.
can you please clarify what exctly you are adding when it fails?
I mean, the code, as posted, seems fine ...