• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 491
  • Last Modified:

crystal display string

I just want to add a asterisk on the end of a string value if it meets a criteria and if it doesn't I want to return the original value.  Here is my code under display string for the field I am working on.  What happens is that the else statement return blank.

if {Command.RECIPE_LINES_PART_CODE} <> "" then
{Command.PART_CODE}+ "*"
else  ({Command.PART_CODE})

0
Amerilab
Asked:
Amerilab
  • 5
  • 3
  • 3
  • +3
2 Solutions
 
Kurt ReinhardtSr. Business Intelligence Consultant/ArchitectCommented:
Try the following:

If
  (
  Not (IsNull({Command.RECIPE_LINES_PART_CODE}))
  OR {Command.RECIPE_LINES_PART_CODE} <> ""
  )
Then
//as a force of habit, I alway use an ampersand to concatenate objects, since the + only works between strings, but & works with all datatypes
  {Command.PART_CODE} & "*"
Else
  {Command.PART_CODE}

Also, have you verified that {Command.PART_CODE} really has data for the records in question?

~Kurt
0
 
AmerilabAuthor Commented:
yes it does.  When I put in the code it blanks out the one that doesn't meet the first criteria.

Tried it same result.
0
 
Kurt ReinhardtSr. Business Intelligence Consultant/ArchitectCommented:
That's odd.  The code basically says: If field 1 exists, then concatenate field 2 with * otherwise field 2 by itself. You're saying field 2 exists in this scenario, even if field 1 doesn't?

1)  Is all the code in a single command or are there multiple commands/table joins?
2)  Are you running this comparison in the detail section of the report or in a header/footer?

~Kurt
0
Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
AmerilabAuthor Commented:
I am running it right on the field in the report.   If I have nothing in the display string code then all data comes up.  But when I put it back in the report only show some of the data.  The data that meets the first criteria.  
0
 
mlmccCommented:
Add WhilePrintingRecords; as the first line.

If you don't use that it may evaluate it early.

mlmcc
0
 
GJParkerCommented:
Instead of using the display string formula add a new formula and place thsi and teh 2 fields recipe_lines_part_code and part_code onto your report and show us a screenshot of teh report indicating which records are returning the wrong results.
0
 
James0628Commented:
I think Kurt may be right about nulls being the issue, but I also think he got some of the logic wrong.  I believe what he posted is saying if RECIPE_LINES_PART_CODE is not null or is not "".  Since it can't be both null and "", it will always _not_ be one or the other, so the ELSE will never be executed.  Try this:

if not IsNull ({Command.RECIPE_LINES_PART_CODE}) and
 {Command.RECIPE_LINES_PART_CODE} <> "" then
{Command.PART_CODE}+ "*"
else  ({Command.PART_CODE})


 I'm assuming that you want to treat a null like an empty string, so that says if the field is not null and not the empty string, add the "*", otherwise don't add the "*".

 James
0
 
msd1305Commented:
go to File->Report Options.

Select "Convert Database NULL values to default" and "Convert otjer NULL values to default" . This will replace your null values with proper values i.e. NULL string with "" and NULL integer with 0.
0
 
James0628Commented:
msd1305 has a good point.  If nulls are the problem, that would be another way to handle this.  Actually, it's what I would usually do for something like this.  I guess I was too focused on the formula to think of it.  :-)

 James
0
 
msd1305Commented:
Amerilab, dont u think u should have accepted my comment as the solution??
0
 
AmerilabAuthor Commented:
Yes.  I apologize.  I accepted the wrong one.  Is there anyway to change this?  
0
 
AmerilabAuthor Commented:
How do I change the accepted answer?
0
 
Kurt ReinhardtSr. Business Intelligence Consultant/ArchitectCommented:
If anything, I suggest you split points between at least James and msd1305.  The issue, based on your acceptance, was obviously due to NULLs.  James corrected the syntax in my original suggestion, which accounted for both NULLs and empty strings.  MSD1305's converts NULLs to empty strings - both accomplish the same thing.

Regardless, I actually recommend against converting NULLs to empty strings. There's a specific scenario in which Crystal Reports will erroneously filter out records based on that setting.  It involves  having  parameter against the field that contains NULL values.  That specific scenario may not apply to this report, but it's good to know about as a "best practices" rule of report design (the issue has existed in every version of Crystal Reports since at least 8 - 2008).  Here are some links that demonstrate the problem:

https://www.box.net/shared/yd65ff3k8h (sample report)
https://docs.google.com/present/view?id=ddcfj5p5_78fbcxb9cz (explained in this presentation from the 2009 conference)

~Kurt
0
 
msd1305Commented:
I went through the document though I do not really see it as a disadvantage considering the problem we face when formulas dont work properly with NULL values (even the isnul()l function does not always work as it should be ) and we end up wasting lot of time to find out the reason.
0
 
mlmccCommented:
Just accept the comments you want

http://www.experts-exchange.com/help.jsp#hs=29&hi=407

mlmcc
0
 
AmerilabAuthor Commented:
Thanks
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 5
  • 3
  • 3
  • +3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now