Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

Only return user tables in SQL query from Excel VBA

Posted on 2010-09-23
8
Medium Priority
?
702 Views
Last Modified: 2012-05-10
I have a piece of code which works brilliantly at finding tables in a SQL database and putting their structures into an excel worksheet.  At the moment the code looks for the 5 tables as defined in thistbl by name.

Is there a way that I can look through the database for all tables so that should, for instance, a table be added I dont need to change the vba code?

Do system tables have a type which could be included in a WHERE or something like that?
Sub readSQLstructure()

Dim DBConn As New ADODB.Connection
Dim RSConn As New Recordset
Sheets("SQL Structure").Activate
ActiveSheet.Cells.Clear
DBConn.Open ("Provider=SQLOLEDB.1;User ID=user;Password=password;Initial Catalog=catalog;Data Source=server;")

With RSConn

tblno = 1
tblnos = 5
For tblno = 1 To tblnos
nextrow = ActiveSheet.UsedRange.Rows.Count + 1

If nextrow = 2 Then
nextrow = 1
End If

thistbl = Choose(tblno, "Assignments", "Equipment", "Faults", "Theatres", "Users")

Sql = "SELECT ORDINAL_POSITION AS POSITION, TABLE_NAME, COLUMN_NAME, DATA_TYPE, CHARACTER_MAXIMUM_LENGTH AS MAX_LENGTH, COLUMN_DEFAULT, IS_NULLABLE As ALLOW_NULL FROM INFORMATION_SCHEMA.Columns WHERE Table_Name = " & "'" & thistbl & "'"
RSConn.Open Sql, DBConn
Worksheets("SQL Structure").Range("A" & nextrow).CopyFromRecordset RSConn
RSConn.Close
Next tblno
End With
DBConn.Close
End Sub

Open in new window

0
Comment
Question by:simonwait
  • 4
  • 3
8 Comments
 
LVL 46

Expert Comment

by:Kent Olsen
ID: 33745084
Piece of cake.  :)

  SELECT * FROM sys.objects WHERE type in (N'U')



Good Luck,
Kent
0
 
LVL 1

Author Comment

by:simonwait
ID: 33745113
so?.  Returns invalid object name sys.objects

Sql = "SELECT ORDINAL_POSITION AS POSITION, TABLE_NAME, COLUMN_NAME, DATA_TYPE, CHARACTER_MAXIMUM_LENGTH AS MAX_LENGTH, COLUMN_DEFAULT, IS_NULLABLE As ALLOW_NULL FROM sys.objects WHERE type in (N'U')"

Open in new window

0
 
LVL 46

Expert Comment

by:Kent Olsen
ID: 33745180
The user doesn't have permission to query the table.

You may want to grant SELECT to the user, or create a view on the table that the user can access.


Kent
0
Nothing ever in the clear!

This technical paper will help you implement VMware’s VM encryption as well as implement Veeam encryption which together will achieve the nothing ever in the clear goal. If a bad guy steals VMs, backups or traffic they get nothing.

 
LVL 1

Author Comment

by:simonwait
ID: 33745210
If the user didnt have select then would the original code not work either?
0
 
LVL 46

Expert Comment

by:Kent Olsen
ID: 33745443
That's a different schema/table.

I suggest that you create view to return the data.  Granting access to items in the sys schema to external users is a bad idea.


Kent
0
 
LVL 35

Expert Comment

by:Norie
ID: 33757967
Simon
Add * to the field list in the original query.
This will return all the fields from INFORMATION_SCHEMA and the ones already specified.
There should be a field that indicates what 'type' of table, you could then set criteria for that field to only return the types of tables you want.
Another option would be to use a wildcard in the criteria for the table name.
This would only really work if the names of the tables you were interested in had something in common, or conversely (sort of) if the names
of the tables you aren't interested had something in common. eg 'sys????'
0
 
LVL 1

Accepted Solution

by:
simonwait earned 0 total points
ID: 34029865
I have decided to look only for tables listed in a column of one of the sheets.
0
 
LVL 1

Author Closing Comment

by:simonwait
ID: 34067952
This seemed the simplest solution.  There appears to be no easy way of generically returning only user tables if they all have radom names.
0

Featured Post

Ask an Anonymous Question!

Don't feel intimidated by what you don't know. Ask your question anonymously. It's easy! Learn more and upgrade.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

When table data gets too large to manage or queries take too long to execute the solution is often to buy bigger hardware or assign more CPUs and memory resources to the machine to solve the problem. However, the best, cheapest and most effective so…
In this blog, we’ll look at how improvements to Percona XtraDB Cluster improved IST performance.
In this video, Percona Solution Engineer Dimitri Vanoverbeke discusses why you want to use at least three nodes in a database cluster. To discuss how Percona Consulting can help with your design and architecture needs for your database and infras…
In this video, Percona Solution Engineer Rick Golba discuss how (and why) you implement high availability in a database environment. To discuss how Percona Consulting can help with your design and architecture needs for your database and infrastr…
Suggested Courses
Course of the Month9 days, 19 hours left to enroll

927 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question