Procedure and AddObject

So I created a Form, Tree, Container...

I'm using the below approach to Add an object (container) in right pane and then display something inside the container:

Define Form - For Form
Create a Top Level Form

   Add Object Tree as ......

   PROCEDURE Tree.NodeClick
   LPARAMETERS Node
         ss=Node.FullPath

         IF SS="Item2"
                AllObjectCont=CREATEOBJECT("CommonForm")
      AllObjectCont.AddObject("AllObjectCont","ContDef")
      AllObjectCont.Show
      READ EVENTS
         else
         endif
    endproc
ENDDEFINE - for Form

DEFINE CLASS CommonForm as Form

      Top=10
      Left=304
      Height=454
      Width=287
      visible=.t.
      borderstyle = 2
      AlwaysOnTop=.t.
      DoCreate = .T.
      controbox=.f.
      MinButton=.f.
      MaxButton=.t.
      autocenter = .f.
      autosize =.t.
      LockScreen=.f.
      Movable=.t.
      ngridx = 0
      ngridy = 0
      Name = "CommonForm"
      ShowWindow = 1
      TitleBar=0
      Anchor=15
      Visible=.t.

ENDDEFINE


When I click on Item2 the form "CommonForm" is not displayed - it doesn't give any error also.

Am I doing something wrong here?

I want to define a Container in Right Pane when someone clicks on the Tree Nodes and then should be able to place items in the Containers.

Thanks!
SP

 
LVL 35
Nirmal SharmaSolution ArchitectAsked:
Who is Participating?
 
Olaf DoschkeConnect With a Mentor Software DeveloperCommented:
When adding object with Addobjects you need to set them visible.

Four other things:
1. You shouldn't name the container you put on the form the same as the object which holds the form reference. It's not against any rule, but a source for confusion.

2. Why create a container with all things inside and put it on a form rather than creating a form itself as class, then you'd create the form you want and show it, done.

3. The Anchor property of the form also is useless. Either a form is resizable or not, but it's not anchored to any other container, even not the _screen. It's objects on the form which need anchoring, not the form.

4. READ EVENTS is not meant for doing with every form you create, you should only have on read events in a min.prg after intialising your application, started a menu and maybe started a main form. If you want execution to stop while a form runs, make the form modal, but better yet try to cope without any modal form, as long as there is one modal form the user can't switch elsewhere in your application. The read events is rather the resting place outside any form caller method or menu that the runtime resides on as long as there is no user input, most of the time, but there should only be one of that.

IF SS="Item2"
    oForm = CREATEOBJECT("CommonForm")
    oForm.AddObject("AllObjectCont","ContDef")
    oForm.AllObjectCont.visible = .T. && this was missing
    oForm.Show(1)
Else
Endif

And if you don't Show(1), but Sho() or Show(2) code continues to run, you can use another item of the treeview to start another form parallel to "Commonform" with the "ContDef" container on it.

Bye, Olaf.
0
 
Nirmal SharmaSolution ArchitectAuthor Commented:
thisform.AddObject("Conts","Container")
thisform.Conts.Visible=.t.

it works!

once question I have is - how do I check if the same container is already defined and close it before adding again?

Thanks!
SP
                  
0
 
Olaf DoschkeConnect With a Mentor Software DeveloperCommented:
If you do that code again, you again start with an empty commonform, so there is no need to check if the container is already defined. You can create as many objects of some class as you want.

As you run the form modal (via Read events or with my alternative Show(1)) there is no chance you get there again before the form is closed.

Bye, Olaf.
0
Cloud Class® Course: CompTIA Healthcare IT Tech

This course will help prep you to earn the CompTIA Healthcare IT Technician certification showing that you have the knowledge and skills needed to succeed in installing, managing, and troubleshooting IT systems in medical and clinical settings.

 
Nirmal SharmaSolution ArchitectAuthor Commented:
Thanks Olaf!

Now I have a new problem - anchoring does not work with the new Container/Form added using the AddObject method when Top Level form is already maximized.

SP
0
 
Nirmal SharmaSolution ArchitectAuthor Commented:
>>>As you run the form modal (via Read events or with my alternative Show(1)) there is no chance you get there again before the form is closed.

This is not I want! Show(1) method doesn't allow me to select anything in the Left Pane (tree).

0
 
Olaf DoschkeSoftware DeveloperCommented:
Anything you put on a form has it's original position then and anchoring works from that moment on, but you can't put a small container on a large form and expect it to resize in relation to the forms base size, no.

Composing forms at runtime is not the way to go anyway.


In regard to Show(1) vs READ EVENTS:

Okay, but you also can't want to stay in the nodeclick event until a CLEAR EVENTS is issued. The problem without SHOW(1) or READ EVENTS is, that the form variable is released when the form finishes and so the form does not persist. You need to add that form reference somewhere it persist, eg let a form handler object handle form creation. This could be done from the treeview menu, when you simply do this in the treeview init:
This.Addobject("forms","collection")

And in the nodeclick after creating and showing the form simply do
This.forms.add(oForm)

This keeps the form alive, and the form reference is removed from the collection, when the form is closed.

With your read events solution, where do you put a clear events? Nowhere? You will not be able to close foxpro then, when you're in a read events. The nodeclick method never finishes.

Bye, Olaf.
0
 
Nirmal SharmaSolution ArchitectAuthor Commented:
Thanks!
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.