[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1693
  • Last Modified:

C# ImportRow for datatable losing data

i use the importrow to copy rows from one datatable to another. It was working fine then i added a few more fields to the stored procedure that populates then one datatable. Now i'm missing two columns after the import. I've debugged it and the data is def there from the sql server it, the fields go null after import. I checked and all the field names match up. I'm not sure what else could be wrong. any insight would be appreciated.
foreach (DataRow mebselrow in ds.Tables[0].Rows)
                 {
           mebselrow["Source"] = source;    
           member.ImportRow(mebselrow);
                  }

Open in new window

0
national_fulfillment
Asked:
national_fulfillment
2 Solutions
 
abdkhlaifCommented:
is this an application under development or a running application that you are trying to debug?
in other words, was your application running when you modified the stored procedure? if so, just restart it and the import will be ok.
0
 
JayFromPepCommented:
Send us a screenshot of the tables from the designer.
0
 
national_fulfillmentAuthor Commented:
the sql input is a stored procedure (below)  and no this isn't a production app yet.

CREATE PROCEDURE [MemberExport]
@key1 nvarchar(2),
@key2 nvarchar(2)
as
          SELECT     tblKeyDescription.KeyDescription, 'source' as Source,'catdrop' as CatDrop,tblListSelection.MembNumb, Cast(Cast(Year( tblListSelection.orderdate) As varchar(4)) +
      Right('0' + Cast(Month( tblListSelection.orderdate) as varchar(2)), 2) +
      Right('0' + Cast(Day( tblListSelection.orderdate) as varchar(2)), 2) as Int)
 as ROrdDate , MemSql.FirstName, MemSql.LastName, MemSql.Company, MemSql.Opt, MemSql.Address,
                      MemSql.City, MemSql.State, MemSql.Zip, MemSql.Country, MemSql.Phone
FROM         tblListSelection INNER JOIN
                      tblKeyDescription ON tblListSelection.Key1 = tblKeyDescription.Key1 INNER JOIN
                      MemSql ON tblListSelection.MembNumb = MemSql.Membnum
where tblListSelection.key1=@key1 and tblListSelection.key2=@key2 and supress='PULL'
GO

 // this is the datatable 

 DataTable member = new DataTable();

            DataColumn Description = new DataColumn();
            Description.ColumnName = "KeyDescription";
            member.Columns.Add(Description);


            DataColumn Source = new DataColumn();
            Description.ColumnName = "Source";
            member.Columns.Add(Source);

            DataColumn Catdrop = new DataColumn();
            Catdrop.ColumnName = "CatDrop";
            member.Columns.Add(Catdrop);

            DataColumn MembNumb = new DataColumn();
            MembNumb.ColumnName = "MembNumb";
            member.Columns.Add(MembNumb);            

            DataColumn OrderDate = new DataColumn();
            MembNumb.ColumnName = "ROrdDate";
            member.Columns.Add(OrderDate);

            DataColumn Fname = new DataColumn();
            Fname.ColumnName = "FirstName";
            member.Columns.Add(Fname);

            DataColumn LName = new DataColumn();
            LName.ColumnName = "LastName";
            member.Columns.Add(LName);

            DataColumn Company = new DataColumn();
            Company.ColumnName = "Company";
            member.Columns.Add(Company);

            DataColumn Opt= new DataColumn();
            Opt.ColumnName = "Opt";
            member.Columns.Add(Opt);

            DataColumn Address = new DataColumn();
            Address.ColumnName = "Address";
            member.Columns.Add(Address);

            DataColumn City = new DataColumn();
            City.ColumnName = "City";
            member.Columns.Add(City);

            DataColumn State = new DataColumn();
            State.ColumnName = "State";
            member.Columns.Add(State);

            DataColumn Zip = new DataColumn();
            Zip.ColumnName = "Zip";
            member.Columns.Add(Zip);

            DataColumn Country = new DataColumn();
            Country.ColumnName = "Country";
            member.Columns.Add(Country);

            DataColumn Phone = new DataColumn();
            Phone.ColumnName = "Phone";
            member.Columns.Add(Phone);

Open in new window

0
Restore individual SQL databases with ease

Veeam Explorer for Microsoft SQL Server delivers an easy-to-use, wizard-driven interface for restoring your databases from a backup. No expert SQL background required. Web interface provides a complete view of all available SQL databases to simplify the recovery of lost database

 
abdkhlaifCommented:
ImportRow method works for columns that exist on both tables. Having missing columns means that the table that you are copying to is missing these columns.

You can use DataTable.Clone() method to copy the structure without the data. Then you can add/remove columns from/to the target table to suit your needs. Then you can use ImportRow to import specific or all rows from source table to target table:
DataTable dtSource = new DataTable();
dtSource.Columns.Add("Name");
dtSource.Columns.Add("Age");
// ... add rows here for testing
DataTable dtTarget = dtSource.Clone();
dtTarget.Columns.Add("Address");
dtTarget.Columns.Remove("Age");

foreach (DataRow dr in dtSource.Rows)
	dtTarget.ImportRow(dr); // this will import 'Name' column only

Open in new window

0
 
Nash2334Commented:
I've had some funny results using ImportRow in the past and have used the "ItemArray" property of the rows instead with better results:

MyDataRow myRow = myDataTable.NewMyDataRow();
myRow.BeginEdit();
myRow.ItemArray = myCloneSourceRow.ItemArray;
myRow.EndEdit();

myDataTable.BeginLoadData();
myDataTable.AddMyDataRow(myRow);
myDataTable.EndLoadData();
0
 
national_fulfillmentAuthor Commented:
the problem ended up being a mistake with copy/paste

            DataColumn Description = new DataColumn();
            Description.ColumnName = "KeyDescription";
            member.Columns.Add(Description);

 (below should really be Source.Column not Description like the previous Column, so in reality my columns didn't match between the two tables) it wasn't jumping out at me cause i kept focusing on the names of the columns, not that i had flipped columns.
Thanks for everyones quick responses.


            DataColumn Source = new DataColumn();
           Description.ColumnName = "Source";
       member.Columns.Add(Source);

and the proposed alternate solution to use itemarray did work i just like having less lines of code to manage.
0

Featured Post

Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now