Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 574
  • Last Modified:

Creating a slide control at runtime

Hi can anyone see why there is no CSliderCtrl control being displayed in my dialog at runtime here is my code below
There should be 8 slider controls being displayed
BOOL ColorControl::OnInitDialog()
{
      CPropertyPage::OnInitDialog();

      // TODO:  Add extra initialization here
      
        int sliderTop = 22;
            int SliderBottom = 10;
          for(int i=0;i<m_BOARDCONTROL.chcount;i++){
            if(i<1){
          SetRect(&rcSlider,49,22,110,10);
            }else{
            sliderTop=sliderTop+22;
            SliderBottom=SliderBottom+10;
            SetRect(&rcSlider,49,sliderTop,110,SliderBottom);
            }

      m_Slider.Create(WS_CHILD | WS_VISIBLE | TBS_BOTH | TBS_NOTICKS | WS_TABSTOP ,rcSlider, this, 1);
      m_Slider.ShowWindow(SW_SHOW);
      }
      return TRUE;  // return TRUE unless you set the focus to a control
      // EXCEPTION: OCX Property Pages should return FALSE
}

Open in new window

0
nchannon
Asked:
nchannon
  • 4
  • 2
2 Solutions
 
AndyAinscowCommented:
Have you single stepped into the code to see what code is executing?
Does the m_Slider.Create(... return 0 to indicate success ?

Also the setting TBS_BOTH | TBS_NOTICKS is wierd.  That says display no ticks AND display ticks on both sides of the control - try removing the setting you don't require, it may be upsetting the create call with a request like that.
0
 
ZoppoCommented:
Hi nchannon,

what is the result when running the ocde? Do you see anything? Do you recieve an error/assertion?

IMO it could be a problem to reuse 'm_Slider' due to MFC internal mechanisms - at least I would guess (I didn't test it) that creating the second slider control may destroy the first created and attached to 'm_Slider' a.s.o.

ZOPPO
0
 
AndyAinscowCommented:
Good point by Zoppo (which I didn't see) - that reuse of m_Slider should result in only one slider control.  But as you don't see any I guess you have another problem as well.
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
nchannonAuthor Commented:
Thanks for your comments I change my code to the following and now it works. Andy the return value if the object is created returns 1 and 0 if it fails but great at least I new the object was being created.
Thanks Zoppo with your observation of m_Slider I changed this to an array m_Slider[8] also changed the CRect values and now it all works
BOOL rs;
	    int sliderTop = 20;
		int SliderBottom = 50;
	    for(int i=0;i<m_BOARDCONTROL.chcount;i++){
		if(i<1){
	    SetRect(&rcSlider[i],15,20,220,50);
		}else{
		sliderTop=sliderTop+31;
		SliderBottom=SliderBottom+31;
		SetRect(&rcSlider[i],15,sliderTop,220,SliderBottom);
		}

	    rs=m_Slider[i].Create(WS_CHILD | WS_VISIBLE | TBS_HORZ | TBS_TOP | TBS_AUTOTICKS | TBS_ENABLESELRANGE ,rcSlider[i], this, i+1);
	    m_Slider[i].ShowWindow(SW_SHOW);
	}

Open in new window

0
 
AndyAinscowCommented:
You don't actually require separate rectangles for the controls, that can safely be reused
0
 
nchannonAuthor Commented:
hi Andy not quite sure what you mean by I dont require the separate rectangles for each control.
To my understanding I need to position each control array so they are not positioned on top of each other mybe you could explane a little better so I can try what you mean
0
 
AndyAinscowCommented:
&rcSlider[i] - no need for an array to store the rectangles
0

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 4
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now