Solved

Problem deleting duplicates using a CTE when there are table joins

Posted on 2010-11-10
10
1,194 Views
Last Modified: 2012-05-10
I've used CTEs to remove duplicates successfully before, but this time round I wanted to delete them from one table having joined to other tables and it comes back with the error:

View or function 'dupnotesCTE' is not updatable because the modification affects multiple base tables. See the attached code for my sql statement.

Not sure where I've gone wrong here...can someone help please?
;WITH dupnotesCTE([FileNo]

      ,[CommentDate]

      ,[CommentTime]

      ,[CommentUser]

      ,[Cat]

      ,[Pri]

      ,[Line]

      ,[Note], Ranking)

AS

(

SELECT	p.[FileNo]

      ,p.[CommentDate]

      ,p.[CommentTime]

      ,p.[CommentUser]

      ,p.[Cat]

      ,p.[Pri]

      ,p.[Line]

      ,p.[Note]

	,Ranking = row_number() OVER(PARTITION BY p.[FileNo]

      ,p.[CommentDate]

      ,p.[CommentTime]

      ,p.[CommentUser]

      ,p.[Cat]

      ,p.[Pri]

      ,p.[Line]

      ,p.[Note] ORDER BY p.[FileNo]

      ,p.[CommentDate]

      ,p.[CommentTime]

      ,p.[CommentUser]

      ,p.[Cat]

      ,p.[Pri]

      ,p.[Line]

      ,p.[Note])

FROM filenotes p

join detailtable d on ltrim(rtrim(p.FileNo)) = ltrim(rtrim(d.FileNo))

join country c on d.country_no = c.country_no

where c.continent in ('Asia','Europe')

)



delete from dupnotesCTE

where ranking > 1

Open in new window

0
Comment
Question by:Grffster
  • 5
  • 5
10 Comments
 
LVL 32

Expert Comment

by:Erick37
ID: 34101354


...

delete p
FROM filenotes p
JOIN dupnotesCTE c ON c.FileNo = p.fileNo --??
where c.ranking > 1
0
 

Author Comment

by:Grffster
ID: 34101830
This won't work though will it as, say you have a pair of duplicates A and B. You have A in dupnotesCTE with rank 1, and B in dupnotesCTE with rank 2. When you link from filenotes to dupnotes you'll have 4 records:

filenotes.A and dupnotes.A (rank 1)
filenotes.A and dupnotes.B (rank 2)
filenotes.B and dupnotes.A (rank 1)
filenotes.B and dupnotes.B (rank 2)

Your "where c.ranking > 1" will remove the 2nd and 4th combinations but you're left with two records i.e. combinations 1 and 3 above.

May be mistaken, but my query seems to reflect this.
0
 
LVL 32

Expert Comment

by:Erick37
ID: 34102171
Does filenotes table have an identity column or primary key that you could use to join the cte?

0
 

Author Comment

by:Grffster
ID: 34102188
No it doesn't sorry.
0
 
LVL 32

Expert Comment

by:Erick37
ID: 34102227
So all of the columns with the duplicate FileNo are also duplicate?
0
Control application downtime with dependency maps

Visualize the interdependencies between application components better with Applications Manager's automated application discovery and dependency mapping feature. Resolve performance issues faster by quickly isolating problematic components.

 

Author Comment

by:Grffster
ID: 34102264
Yes, all the fields per fileno duplicate are identical i.e. a true duplicated record with the same data in each column:

[FileNo],[CommentDate],[CommentTime],[CommentUser],[Cat],[Pri],[Line],[Note]
0
 
LVL 32

Expert Comment

by:Erick37
ID: 34102504
Having an identity column would greatly simplify identifying the duplicates.

One possibility would be to copy the records over to a temp table with an identity column.
Remove the duplicates from the temp table.
Delete all the records from the user table that you originally copied to the temp table.
Insert the cleaned records back into filenotes table.

Here are some other alternatives:
"How to delete duplicate records or rows among identical rows in a table where no primary key exists"
http://www.kodyaz.com/articles/delete-duplicate-records-rows-in-a-table.aspx
0
 

Author Comment

by:Grffster
ID: 34102929
I've added an identity column to the filenotes table now. How should it look now? Do I do something like at the bottom of your last link in method 3?
0
 
LVL 32

Accepted Solution

by:
Erick37 earned 500 total points
ID: 34103157
You will add the identity column to the CTE and use that to join the table to the cte.

;WITH dupnotesCTE AS
(
  SELECT
      IdentityColumn
      ,[FileNo]
      ...
      ,row_number() OVER(PARTITION BY p.[FileNo] order by IdentityColumn) AS Ranking
     ...

)
delete p
FROM filenotes p
JOIN dupnotesCTE c ON c.IdentityColumn = p.IdentityColumn AND c.ranking > 1
0
 

Author Closing Comment

by:Grffster
ID: 34103515
That's worked a dream thanks Eric.
0

Featured Post

Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Recently, when I was asked to create a new SQL 2005 cluster, Microsoft released a new service pack for MS SQL 2005 what is Service Pack 3. When I finished the installation of MS SQL 2005 I found myself troubled why the installation of SP3 failed …
When writing XML code a very difficult part is when we like to remove all the elements or attributes from the XML that have no data. I would like to share a set of recursive MSSQL stored procedures that I have made to remove those elements from …
Along with being a a promotional video for my three-day Annielytics Dashboard Seminor, this Micro Tutorial is an intro to Google Analytics API data.
This is used to tweak the memory usage for your computer, it is used for servers more so than workstations but just be careful editing registry settings as it may cause irreversible results. I hold no responsibility for anything you do to the regist…

910 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now