Solved

How do you insert given text into a line in a text file using a batch script?

Posted on 2010-11-10
8
492 Views
Last Modified: 2012-05-10
Greetings,

I have a batch file that grabs a file off of an ftp server, then deletes a given line based off a search string using type and find.

type in.txt | fine /V "<searchstring>">out.txt

I want to take that out.txt and insert text into one of the lines now, for example:

lineinformation1|moreinfo1|info1|somerandomnumber1
lineinfomation2|||somerandomnumber2
lineinformation3|moreinfo3|info3|somerandomnumber3

and afterwards i want the line to look like:

lineinformation1|moreinfo1|info1|somerandomnumber1
lineinfomation2|insertedinfo|moreinsertedinfo|somerandomnumber2
lineinformation3|moreinfo3|info3|somerandomnumber3

is there any not too complex way to write this?
0
Comment
Question by:jedininja
  • 3
  • 2
  • 2
  • +1
8 Comments
 
LVL 26

Expert Comment

by:pony10us
Comment Utility
Some questions that might make a difference in the code:

1. Is the "lineinformation2" always the same?
2. Do the "|" actually exist as shown?

0
 

Author Comment

by:jedininja
Comment Utility
@pony10us

yes, the informationline2 is always the same, so is the "insesrtedinfo"

also the | are in as shown. i've been trying this:

for /F "token=*" %%l in (myfilename.txt) do (
   set line=%%l
   set line=!line:"|||"="|insertedinfo|moreinsertedinfo|"!
   echo !line!>> newmyfilename.txt
)

but its not changing the line, also tried it with the full line name in it.
0
 

Author Comment

by:jedininja
Comment Utility
ended up going with a vb script and running it in my batch.


'replace.vbs
Dim objFSO: Set objFSO = CreateObject("Scripting.FileSystemObject")
Dim objFile: Set objFile = objFSO.OpenTextFile("C:\TEMP\oldfilename.txt")

OldData = "|||"
NewData = "|newinfo|moreinfo|"

arrData = Replace(objFile.ReadAll, OldData, NewData)
objFile.Close
Dim objOutput: Set objOutput = objFSO.CreateTextFile("C:\TEMP\newfilename.txt")
objOutput.Write arrData
objOutput.Close

Set objOutput=Nothing
Set objFile=Nothing
Set objFSO=Not

Open in new window

0
 
LVL 16

Accepted Solution

by:
t0t0 earned 250 total points
Comment Utility
Try this:

Save the code as PROC.BAT and call it like this:

   PROC in.txt > out.txt

or

   PROC "in.txt" > "out.txt"




@echo off
setlocal enabledelayedexpansion

for /f "tokens=* usebackq" %%a in ("%~1") do (
   set line=%%a
   set line=!line:^|^|^|=^|insertedinfo^|moreinsertedinfo^|!
   echo !line!
)

exit /b
0
Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

 
LVL 51

Expert Comment

by:Bill Prew
Comment Utility
@t0t0, looks good.  

@pony10us, are you watching :-).

Only thing I would mention is that this assumes that there aren't any "odd" characters in the existing file data, or the new data to be inserted, occasionally certain special characters can be mishandled by BAT, whereas they typically are handled okay in VBS.

~bp
0
 
LVL 26

Expert Comment

by:pony10us
Comment Utility
@jedininja - I was thinking about VBS

@t0t0 - your code is much cleaner than what I was working on but I was trying to do it without the user having to input anything. Of course I was not able to finish it.

@billprew - of course I am watching.  :)   I almost had something but was trying to use an IF inside a FOR /f and it wouldn't work.  Any ideas?  

Your comments make good sense as usual    :)
0
 
LVL 16

Expert Comment

by:t0t0
Comment Utility
--> bill

There was no mention of 'odd' characters in the question, other than the pipe symbol of course.

The 'file data' is taken literally from the example given in the question by the asker.

The solution i provide above works with the data provided.

I would be quite happy to amend the code, if possible, to handle other requirements where special characters are concerned however, this may not be an issue we need to concerned ourselves with.

VBS does provide advantages over DOS and maybe, keeping in flavour with DOS, the VBS script could be generated from within the same batch file thereby not requiring a 'seperate' external file.


--> pony10us

Your comments are noted.
0
 

Author Closing Comment

by:jedininja
Comment Utility
t0t0 strikes again :)
0

Featured Post

6 Surprising Benefits of Threat Intelligence

All sorts of threat intelligence is available on the web. Intelligence you can learn from, and use to anticipate and prepare for future attacks.

Join & Write a Comment

If like me you are one who spends a lot of time working and scripting with cmd.exe, sometimes it is handy to be able to quickly view a calendar for a given month and year. This script will quickly do just that!  Save the code posted below to a .bat …
This article was inspired by a question here at Experts Exchange (http://www.experts-exchange.com/Software/Photos_Graphics/Images_and_Photos/Q_28629170.html). The requirements stated in that question are (1) reduce the file size of a large number of…
This tutorial demonstrates a quick way of adding group price to multiple Magento products.
This video explains how to create simple products associated to Magento configurable product and offers fast way of their generation with Store Manager for Magento tool.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now