Solved

ON_UPDATE_COMMAND_UI vs ON_COMMAND

Posted on 2010-11-12
3
1,206 Views
Last Modified: 2012-05-10
Previously in MFC I've managed to use the ON_UPDATE_COMMAND_UI handler to set the state of check boxes and buttons on application menu bars and let ON_COMMAND set the new state.

I'm now using a ribbon bar with a CBCGPRibbonSlider on it. The position of the slider maintained by ON_UPDATE.. and a change to the position from the ON_COMMAND handler.

THE PROBLEM is in the ON_COMMAND handler I use pCtrl->GetPos(); only to find that the ON_UPDATE_COMMAND_UI has already set it back to the previous position.

I could ignore the GetPos value but have no other CBCGPRibbonSlider method to know its new position.

Am I going about the UPDATE + COMMAND interface the wrong way or should the CBCGPRibbonSlider return the position better?

void CMainFrame::OnMapDDIDetails()
{
	int iDDIViewDetails = -1;
	CBCGPRibbonSlider* pCtrl  = (CBCGPRibbonSlider*)m_wndRibbonBar.FindByID(IDC_MAP_DDI_DETAILS, FALSE);
	if(pCtrl!=NULL)
	{
		iDDIViewDetails = pCtrl->GetPos();
		if((iDDIViewDetails>=0)||(iDDIViewDetails<=2))
			ChangeDetails(iDDIViewDetails);
	}
}
void CMainFrame::OnUpdateMapDDIDetails(CCmdUI* pCmdUI)
{
	int iDDIViewDetails = -1;
	CBCGPRibbonSlider* pCtrl  = (CBCGPRibbonSlider*)m_wndRibbonBar.FindByID(IDC_MAP_DDI_DETAILS, FALSE);
	if(pCtrl!=NULL)
	{
		iDDIViewDetails = GetDetailState();
		if((iDDIViewDetails>=0)||(iDDIViewDetails<=2))
			pCtrl->SetPos(iDDIViewDetails);
	}
}

Open in new window

0
Comment
Question by:itdeptneci
3 Comments
 
LVL 31

Accepted Solution

by:
Zoppo earned 500 total points
ID: 34119674
Hi itdeptneci,

the only way to avoid this is to simply not set the control's position within the ON_UPDATE_COMMAND_UI handler. The ON_UPDATE_COMMAND_UI handler is used to implement the visible state of a GUI element's, it's not intended to be used to update data which might be associated with that control. And IMO this is really senseful, since if one uses a ON_COMMAND_UPDATE_UI handler to change any data may initiate another ON_UPDATE_COMMAND_UI.

So, I would suggest you add a 'int' member to your applications document - in 'OnMapDDIDetails' you can retrieve its value as you now do for 'iDDIViewDetails'. In 'OnUpdateMapDDIDetails' just handle visibility/disabled-state of the control. Add a 'OnActivateView' handler and use the 'SetPos' there as you before did in 'OnUpdateMapDDIDetails'.

Hope that helps,

ZOPPO
0
 
LVL 40

Expert Comment

by:evilrix
ID: 34824134
This question has been classified as abandoned and is being closed as part of the Cleanup Program. See my comment at the end of the question for more details.
0

Featured Post

Netscaler Common Configuration How To guides

If you use NetScaler you will want to see these guides. The NetScaler How To Guides show administrators how to get NetScaler up and configured by providing instructions for common scenarios and some not so common ones.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Go is an acronym of golang, is a programming language developed Google in 2007. Go is a new language that is mostly in the C family, with significant input from Pascal/Modula/Oberon family. Hence Go arisen as low-level language with fast compilation…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

770 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question