Solved

VBA, VB6, Ms access

Posted on 2010-11-13
10
355 Views
Last Modified: 2012-05-10
Dear experts, i have a from on ms access where i have a button save and save some records in different tables. for this i set different openrecordset. the problem is its saving in all tables except for 1

here it is
Set db = CurrentDb
Set rst = db.OpenRecordset("Player_Details")


With rst
    .AddNew
    !Firstname = Me.Text3
    !Lastname = Me.Text5
    !DoB = Me.Text7
    !Height = Me.Text9
    !Weight = Me.Text11
    !Level = Me.Combo33
    pk_value = ![idPlayer_Details]
    .Update

End With
rst.Close
    

Set db8 = CurrentDb
Set rst8 = db8.OpenRecordset("Player_Occupation")
With rst8
    .AddNew
    !idOccupations = Me.Combo37
    !idPlayer_Details = pk_value
    !NameOfInstitute = Me.Text26
    !Hobby = Me.Text26
    .Update
End With
rst8.Close



Set db3 = CurrentDb
Set rst3 = db3.OpenRecordset("Team_History")
With rst3
    .AddNew
    !idTeam_Details = Me.Combo40
    !idPlayer_Details = pk_value
    .Update
End With
rst3.Close

Open in new window


Player_Details and Team_History are saving successfully. but i dont know why Player_Occupation is not updating.. Please help
0
Comment
Question by:Alv45525
  • 2
  • 2
  • 2
  • +4
10 Comments
 
LVL 8

Expert Comment

by:2toria
Comment Utility
Do you get any error messages at all?  

One hint that might be useful, especially for future readability of your code, is to give your fields descriptive names.  For example, if your team details combobox was called cboTeamDetails it would read much better, especially if you leave this code for a few weeks/months and have to come back at some point to debug.  Other than that I can't see anything particularly wrong.  It is early in the morning here though.

Matt
0
 

Author Comment

by:Alv45525
Comment Utility
^^ thats for response Matt,

Yes i know i need to work on the name of the variables later. it was just a set up.

Actually theres no error message.

all saves in respective tables except for Player_Occupation
0
 
LVL 8

Expert Comment

by:2toria
Comment Utility
Can you upload the file for me to have a look at?  It might be easier to check out the problem.

Matt
0
 
LVL 24

Expert Comment

by:Bitsqueezer
Comment Utility
Hi,

instead of using a recordset you should better use a SQL command for that purpose like this:

DBEngine(0)(0).Execute "INSERT INTO Player_Occupation " & _
                       "           (idOccupations,idPlayer_Details," & _
                       "            NameOfInstitute,Hobby) " & _
                       "       VALUES " & _
                       "           (" & Nz(Me.Combo37,0) & "," & _
                                    Nz(pk_value,0) & ",'" & _
                                    Nz(Me.Text26) & "','" & Nz(Me.Text26) & "')"

Open in new window


(DBEngine(0)(0) is a kind of equivalent to CurrentDB, but it's faster as it is an always existing instance of the currnet database object.)
I assumed in this example that the id fields are numerical and the Text26 is alphanumerical (you need to enclose the value in single quotes in this case). Is it correct that two fields in this case have the value of the same textbox (Me.Text26)?

It's difficult to say anything about the recordset solution without knowing what type of recordset you declared, how your error handling takes place and how your tables look like so I agree with Matt that in such cases it is easier to post the database (an extract without important data of course).

Cheers,

Christian
0
 
LVL 119

Accepted Solution

by:
Rey Obrero earned 250 total points
Comment Utility
i see that you have two "id"  fields    
    !idOccupations = Me.Combo37
    !idPlayer_Details = pk_value

in the table Player_Occupation that look like Foreign keys.(FK)

check the relationship of table Player_Occupation to the tables where the above FK id's are
Primary Keys (PK)
If Referential Integrity (RI) is set in the relationship , those FK must be added first as PK to their respective tables.
0
Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

 
LVL 31

Expert Comment

by:Helen_Feddema
Comment Utility
In addition to giving your controls meaningful names, bear in mind that there is a difference between the control object itself, and the value from the control, which is what you are assigning to fields in the recordsets.  Sometimes it is helpful to assign the values from the controls to variables, so you can test whether they have the correct data, and examine them in the Watch window or write them to the Immediate window.  Here is a sample (for a Date value):

   If IsDate(Me![txtDate].Value) = True Then
      dteSingle = CDate(Me![txtDate].Value)
   End If
0
 
LVL 65

Expert Comment

by:rockiroads
Comment Utility
Looking at Player_Occupation

    .AddNew
    !idOccupations = Me.Combo37
    !idPlayer_Details = pk_value
    !NameOfInstitute = Me.Text26
    !Hobby = Me.Text26
    .Update

I do not see anything wrong with this so as long as the add was fine, pk_value should have something. Looks like in Player_Details the column idPlayer_Details has been setup as a AutoNumber. Is this right?

If that is the case and you are going on something the same for Player_Occupation, then is idOccupations a autonumber or are you referencing a combo which is a lookup of occupations? If it is the latter then I assume a value has been selected and you do have an autonumber setup? If there is an autonumber set can you not add something like this to check if one has been generated or not i.e.

debug.print  !myOccupationsAutonumber

Do you use

ON ERROR RESUME NEXT

if so then comment out that line so you can tell if an error occurred or add this after the .Update in Player_Occupation

if err.number <> 0 then
    msgbox "Error " & err.number & " when updating occupations. " & err.description
end if

0
 

Author Comment

by:Alv45525
Comment Utility
i am referencing a combo which is a lookup of occupations
0
 
LVL 119

Expert Comment

by:Rey Obrero
Comment Utility
Alv45525,


before anything else,  i suggest that you check what was posted in http:#a34127359





0
 
LVL 75

Expert Comment

by:DatabaseMX (Joe Anderson - Access MVP)
Comment Utility
@Bitsqueezer:

As far as DbEngine(0)(0) ... I might suggest you check this out:
http://groups.google.com/group/comp.databases.ms-access/msg/9fe98bb5d7cba5ea?hl=en&

mx
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Whether you've completed a degree in computer sciences or you're a self-taught programmer, writing your first lines of code in the real world is always a challenge. Here are some of the most common pitfalls for new programmers.
Describes a method of obtaining an object variable to an already running instance of Microsoft Access so that it can be controlled via automation.
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.
Access reports are powerful and flexible. Learn how to create a query and then a grouped report using the wizard. Modify the report design after the wizard is done to make it look better. There will be another video to explain how to put the final p…

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

7 Experts available now in Live!

Get 1:1 Help Now