Solved

TSQL Best practice No loop

Posted on 2010-11-15
7
453 Views
Last Modified: 2012-05-10
I have a table that has the fields: sCustID and severl other fields.. I want to "Group" together the like sCustid's by giving them a unique GroupID number.. If you run my code you will see what I'm trying to do.. The only problem is my code is backwards.. It groups the ones that are no alike together and the ones that are alike have different group numbers.. What am I doing wrong?
DECLARE @tmp TABLE (id TINYINT IDENTITY(1,1), sCustID CHAR(10)) 
 
INSERT @tmp

SELECT sCustID FROM ctsapp.app.tblVRUInvReq
 
	SELECT  
    o.sCustID, o.id - omin.minid + 1 AS GroupNum 
		FROM @tmp o 
		INNER JOIN 
			(SELECT sCustID, MIN(id) minid  FROM @tmp GROUP BY sCustID) AS omin ON 
                o.sCustID = omin.sCustID

Open in new window

0
Comment
Question by:cheryl9063
  • 3
  • 3
7 Comments
 
LVL 41

Expert Comment

by:ralmada
ID: 34140115
can you try using the dense rank function?
SELECT sCustID, dense_rank() over (order by sCustID) as groupno FROM ctsapp.app.tblVRUInvReq

Open in new window

0
 
LVL 10

Accepted Solution

by:
GDG_DBA earned 500 total points
ID: 34140164
I am not sure what you are trying to do with this part:

o.id - omin.minid + 1 AS GroupNum


Try just using the omin.minid.  (See attached)
-G
SELECT  
    o.sCustID, omin.minid AS GroupNum --, o.id - omin.minid + 1 AS GroupNum 
		FROM @tmp o 
		INNER JOIN 
			(
			SELECT sCustID, MIN(id) minid  FROM @tmp GROUP BY sCustID
			) AS omin ON 
                o.sCustID = omin.sCustID

Open in new window

0
 
LVL 1

Author Closing Comment

by:cheryl9063
ID: 34140199
I don't know what I was doing either but thanks!!
0
The New “Normal” in Modern Enterprise Operations

DevOps for the modern enterprise offers many benefits — increased agility, productivity, and more, but digital transformation isn’t easy, especially if you’re not addressing the right issues. Register for the webinar to dive into the “new normal” for enterprise modern ops.

 
LVL 41

Expert Comment

by:ralmada
ID: 34140227
Hmmm, have you tried my suggestion?
0
 
LVL 1

Author Comment

by:cheryl9063
ID: 34140273
Although I'm sure your answer is fine I don't want to use your suggestion..Based on  many reasons  I need to use the query I was using.. My question was what was wrong with my code not how do you perform the same thing using different approaches.. Also, my DBA does not want more functions at this time but many many thanks for your response.
0
 
LVL 41

Expert Comment

by:ralmada
ID: 34140359
>>I don't want to use your suggestion..Based on  many reasons  I need to use the query I was using.. My question was what was wrong with my code not how do you perform the same thing using different approaches.. <<
your current approach is very clunky. There's no need to create a new temporary table and then select assign group id.the way you're doing

>>Also, my DBA does not want more functions at this time but many many thanks for your response. <<
You don't have to create any function here. Dense_rank is a function that comes with SQL server, same as MIN, MAX, etc.

If you still insist, it's up to you, all I'm saying that at least you should have tried my suggestion and split the points accordingly since I have provided you a valid solution, waaaay simpler than the one you currently have.

0
 
LVL 1

Author Comment

by:cheryl9063
ID: 34140528
If you run an execution plan and see what the Optimzer prefers
Query 1 ( my way)  cost 21%

Query 2( your way) cost 56%

Any kind of function results in a productivity impact.
0

Featured Post

Three Reasons Why Backup is Strategic

Backup is strategic to your business because your data is strategic to your business. Without backup, your business will fail. This white paper explains why it is vital for you to design and immediately execute a backup strategy to protect 100 percent of your data.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

For both online and offline retail, the cross-channel business is the most recent pattern in the B2C trade space.
I have a large data set and a SSIS package. How can I load this file in multi threading?
Via a live example, show how to extract insert data into a SQL Server database table using the Import/Export option and Bulk Insert.
Via a live example, show how to backup a database, simulate a failure backup the tail of the database transaction log and perform the restore.

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question