Solved

VBScript File Rename

Posted on 2010-11-17
14
840 Views
Last Modified: 2012-05-10
I have a folder with many text files in it.  Each file contains the following 7 lines:

CHART #:  3563A
PATIENT NAME:  Joan Q Public
DOB:  01/18/1934
SEX:  female
SSN:  123-45-6789
NOTE DATE:  09/26/2007
Note for Joan Smith on 9/26/2007 - Chart 3563A

The File names contain a sequence number followed by the value in CHART #:  I need to renname each file using a vbscript by appending the line starting with NOTE DATE to the current file name.

The above file would be named 1234_3563A NOTE DATE: 09/26/2007.txt
0
Comment
Question by:vpnsol123
  • 6
  • 3
14 Comments
 
LVL 51

Expert Comment

by:Bill Prew
ID: 34161259
How about something like this?

~bp

@echo off
cd c:\basedir
for %%A in (*.txt) do (
  for /F "tokens=*" %%B in ('findstr /I "note date:" "%%A"') do (
    ren "%%A" "%%~nA %%B.txt"
  )
)

Open in new window

0
 
LVL 65

Expert Comment

by:RobSampson
ID: 34161718
You could try this too.  You can't have the colon in the file name, so I've removed that when changing it.

Try it on a test folder first.

Regards,

Rob.
strFolder = "C:\Files"

Set objFSO = CreateObject("Scripting.FileSystemObject")

Const intForReading = 1

For Each objFile In objFSO.GetFolder(strFolder).Files

	If Right(LCase(objFile.Name), 4) = ".txt" Then

		Set objText = objFSO.OpenTextFile(objFile.Path, intForReading, False)

		strAppend = ""

		While Not objText.AtEndOfStream

			strLine = objText.ReadLine

			If InStr(strLine, "NOTE DATE:") > 0 Then strAppend = strLine

		Wend

		objText.Close

		If strAppend <> "" Then objFile.Name = Left(objFile.Name, Len(objFile.Name) - 4) & " " & Replace(strAppend, ":", "") & ".txt"

	End If

Next

MsgBox "Done"

Open in new window

0
 
LVL 51

Expert Comment

by:Bill Prew
ID: 34163435
Good point on the colon, missed the forest for the trees I guess :-).  Anyway, in the BAT approach, we could remove the colon as follows.

~bp

@echo off
setlocal EnableDelayedExpansion
cd c:\basedir
for %%A in (*.txt) do (
  for /F "tokens=*" %%B in ('findstr /I "note date:" "%%A"') do (
    set NewName=%%~nA %%B.txt
    ren "%%A" "!NewName::=!"
  )
)

Open in new window

0
 

Author Comment

by:vpnsol123
ID: 34164741
When I run this, I get invalid procedure call or agrument  line 13 character 27 error 800A0005
0
 
LVL 51

Expert Comment

by:Bill Prew
ID: 34166669
Try changing this:

If strAppend <> "" Then objFile.Name = Left(objFile.Name, Len(objFile.Name) - 4) & " " & Replace(strAppend, ":", "") & ".txt"

to this:

If strAppend <> "" Then objFile.Name = Left(objFile.Name, Len(objFile.Name) - 4) & " " & Replace(strAppend, ":", "") & ".txt" End If

~bp
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 65

Assisted Solution

by:RobSampson
RobSampson earned 150 total points
ID: 34168681
In my code, that could be due to the fact that setting objFile.Name directly might not work.  Try this.

Regards,

Rob.
strFolder = "C:\Files"

Set objFSO = CreateObject("Scripting.FileSystemObject")

Const intForReading = 1

For Each objFile In objFSO.GetFolder(strFolder).Files

	If Right(LCase(objFile.Name), 4) = ".txt" Then

		Set objText = objFSO.OpenTextFile(objFile.Path, intForReading, False)

		strAppend = ""

		While Not objText.AtEndOfStream

			strLine = objText.ReadLine

			If InStr(strLine, "NOTE DATE:") > 0 Then strAppend = strLine

		Wend

		objText.Close

		If strAppend <> "" Then

			strNewName = Left(objFile.Name, Len(objFile.Name) - 4) & " " & Replace(strAppend, ":", "") & ".txt"

			If objFSO.FileExists(strNewName) = True Then objFSO.DeleteFile strNewName, True

			objFSO.MoveFile objFile.Path, strNewName

		End If

	End If

Next

MsgBox "Done"

Open in new window

0
 
LVL 51

Expert Comment

by:Bill Prew
ID: 34312869
The poster has asked to close the question after some potentially useful answers were provided, but without giving an explanation.  Not sure what "gh" represents?  Would like the poster to either work further with the experts toward a working solution, or explain why none are useful.

~bp
0
 
LVL 51

Expert Comment

by:Bill Prew
ID: 34368945
I guess without further input from the original poster, we likely should close the question as abandoned and not award points.  If points were to be awarded then Rob should likely get all or most, since he had the VBS solution, which was the zone posted in...

~bp
0
 
LVL 51

Accepted Solution

by:
Bill Prew earned 350 total points
ID: 34369726
Okay, this feels funny I guess, but I did some testing, determined that neither solution worked properly, and will now post corrected versions.  At this point I think I would suggest closing, selecting this post as the accepted answer, with no points to Rob or I.  Rob, feel free to disagree.

In the BAT script the arguments to the FIND were not quite right above and found an extra line in the text files.  That is corrected below.

In addition neither approach dealt with the fact that the date in the text file that were going to add to the file name in the rename contained forward slash "/" characters, which throws an error in a filename.  I've adjusted both scripts to replace with dash "-" before the rename.

Naturally without the original poster replying we don't know if either (or both) approaches met their need.

Batch (BAT) approach:

@echo off
setlocal EnableDelayedExpansion
cd c:\Files
for %%A in (*.txt) do (
  for /F "tokens=*" %%B in ('findstr /I /C:"note date:" "%%A"') do (
    set NewName=%%~nA %%B.txt
    set NewName=!NewName:/=-!
    ren "%%A" "!NewName::=!"
  )
)

Open in new window

VB script (VBS) approach:

strFolder = "C:\Files"
Set objFSO = CreateObject("Scripting.FileSystemObject")
Const intForReading = 1
For Each objFile In objFSO.GetFolder(strFolder).Files
        If Right(LCase(objFile.Name), 4) = ".txt" Then
                Set objText = objFSO.OpenTextFile(objFile.Path, intForReading, False)
                strAppend = ""
                While Not objText.AtEndOfStream
                        strLine = objText.ReadLine
                        If InStr(strLine, "NOTE DATE:") > 0 Then strAppend = strLine
                Wend
                objText.Close
                If strAppend <> "" Then
                        strNewName = Left(objFile.Name, Len(objFile.Name) - 4) & " " & Replace(Replace(strAppend, ":", ""), "/", "-") & ".txt"
                        If objFSO.FileExists(strNewName) = True Then objFSO.DeleteFile strNewName, True
                        objFSO.MoveFile objFile.Path, strNewName
                End If
        End If
Next
MsgBox "Done"

Open in new window

~bp
0
 
LVL 65

Expert Comment

by:RobSampson
ID: 34373217
Thanks Bill, great job.  I had forgotten about the forward slash, and admittedly didn't test it, so I'm fine with the way this has been closed.

Thanks all.

Rob.
0

Featured Post

How to improve team productivity

Quip adds documents, spreadsheets, and tasklists to your Slack experience
- Elevate ideas to Quip docs
- Share Quip docs in Slack
- Get notified of changes to your docs
- Available on iOS/Android/Desktop/Web
- Online/Offline

Join & Write a Comment

Unlike scripting languages such as C# where a semi-colon is used to indicate the end of a command, Microsoft's VBScript language relies on line breaks to determine when a command begins and ends. As you can imagine, this quickly results in messy cod…
Introduction During my participation as a VBScript contributor at Experts Exchange, one of the most common questions I come across is this: "I have a script that runs against only one computer. How can I make it run against a list of computers in …
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
In this tutorial you'll learn about bandwidth monitoring with flows and packet sniffing with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're interested in additional methods for monitoring bandwidt…

708 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now