• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 662
  • Last Modified:

How do I get a C++ program to read input from a text file?

How do I get a C++ program to read input from a text file?  I have a program that works when entering input directly from the console.  I have modified it to accept input from a text file, but it currently will not compile.  It appears that the problem is associated with the paramaters being passed.
#include <iostream>
#include <fstream>  //
#include <strstream>  //
#include <string>
#include <vector>
using namespace std;

#include "DivideByZeroException.h" // DivideByZeroException class
#include "UninitializedException.h" // UninitializedException class
#include "SyntaxException.h" // SyntaxException class

#include "expression.h"
#include "subexpression.h"
#include "symboltable.h"
#include "parse.h"

SymbolTable symbolTable;

void parseAssignments(strstream& in);

int main()
{
	const int SIZE = 256;
	Expression* expression;
    char paren, comma, line[SIZE];
	string variable;  //added for IO file
    double value;     //added for IO file

	ifstream fin("input.txt");
	while (true)
	{
		symbolTable.init(variable, value);
		fin.getline(line, SIZE);
		if (!fin)
			break;
		strstream in(line, SIZE);
		
		in >> paren;
		cout << line << " ";

	//cout << "Enter expression: ";
	//cin >> paren;
 
	try
	{

		if (cin.peek() == '(')  //mistmatch left paren exception.
		{
			throw SyntaxException();
		}

		expression = SubExpression::parse(strstream&);
		
		if (cin.peek() == ')')       //mistmatch right paren exception.
		{
			throw SyntaxException();
		}

		if (cin.peek() != ',')		//missing comma exception. 
		{ 
			throw SyntaxException();
		}

		cin >> comma;
		parseAssignments(in);

		//if (cin.peek() != ';')		//missing comma exception. 
		//{ 
		//	throw SyntaxException();
		//}

		double result = expression->evaluate();
		cout << "Value = " << result << endl;
	}
	catch (DivideByZeroException &divideByZeroException)
	{
		cout << "Error: " << divideByZeroException.what() << endl;
	}
	catch (UninitializedException &uninitializedException)
	{
		cout << "Error: " << uninitializedException.what() << endl;
	}
	catch (SyntaxException &syntaxException)
	{
		cout << "Error: " << syntaxException.what() << endl;
	} 
	}
    return 0;
}

void parseAssignments(strstream& in)
{
    char assignop, delimiter;
    string variable;
    double value;

    do
    {
        variable = parseName();
		in >> ws >> assignop >> value >> delimiter;

		if (assignop != '=')
		{
			throw SyntaxException();
		}
		else
			symbolTable.insert(variable, value);
    }
    while (delimiter == ',');
}

Open in new window

0
NSing9
Asked:
NSing9
  • 4
  • 3
1 Solution
 
NSing9Author Commented:
There appear to be problems with the sysntax here:
#include <iostream>
using namespace std;

#include "SyntaxException.h" // SyntaxException class

#include "expression.h"
#include "subexpression.h"
#include "operand.h"
#include "plus.h"
#include "minus.h"
#include "times.h"
#include "divide.h"

SubExpression::SubExpression(Expression* left, Expression* right)
{
    this->left = left;
    this->right = right;
}

Expression* SubExpression::parse(strstream&)
{
    Expression* left;
    Expression* right;
    char operation, paren;
    
    left = Operand::parse();
    cin >> operation;
    right = Operand::parse();
    cin >> paren;
	switch (operation)
    {
        case '+':
            return new Plus(left, right);
        case '-':
            return new Minus(left, right);
        case '*':
            return new Times(left, right);
        case '/':
            return new Divide(left, right);
		default:
			throw SyntaxException(); 
    }
    return 0;
}

Open in new window

0
 
NSing9Author Commented:
The definitions are here:
class SubExpression: public Expression
{
public:
    SubExpression(Expression* left, Expression* right);
    static Expression* parse();
protected: 
    Expression* left;
    Expression* right;
};

Open in new window

0
 
trinitrotolueneDirector - Software EngineeringCommented:
what is the meaning of this line

Expression* SubExpression::parse(strstream&)

you have to pass an strstream argument else how do you expect the function to do what its supposed to do?

and strstream is deprecated. Consider using stringstream instead.
http://www.cplusplus.com/reference/iostream/stringstream/
0
What Kind of Coding Program is Right for You?

There are many ways to learn to code these days. From coding bootcamps like Flatiron School to online courses to totally free beginner resources. The best way to learn to code depends on many factors, but the most important one is you. See what course is best for you.

 
trinitrotolueneDirector - Software EngineeringCommented:
this line needs to be corrected

expression = SubExpression::parse(strstream&);

as you can see no argument is being passed
0
 
trinitrotolueneDirector - Software EngineeringCommented:
the switch is a bit strange too

switch (operation)
    {
        case '+':
            return new Plus(left, right);
        case '-':
            return new Minus(left, right);
        case '*':
            return new Times(left, right);
        case '/':
            return new Divide(left, right);
            default:


you should be breaking out of a case statement when a specific case matches unless you have a need to do otherwise
0
 
NSing9Author Commented:
It was understood that the wrong parameters were being assigned.  I had to figure out the correct solution myself.
0
 
trinitrotolueneDirector - Software EngineeringCommented:
ofcourse what did you expect? write out the complete solution for you. Thats not what EE does. We are experts not your assistants.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 4
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now