Solved

c turn bit position in memory

Posted on 2010-11-19
8
449 Views
Last Modified: 2012-05-10
Hello,
turn a bit sequence in c mingw,  unfortunately  i strand if i only try to print it out in the opposite direction, normal printout is properly

example:
11100101 11001110 11100001
should be :
10000111 01110011 10100111

 
0
Comment
Question by:thomas2010
  • 4
  • 2
  • 2
8 Comments
 
LVL 16

Expert Comment

by:imladris
ID: 34177350
The example:

example:
11100101 11001110 11100001
should be :
10000111 01110011 10100111

indicates that the second line should show the same byte sequence, except each byte is printed out in reverse order.

So, in the second loop you want to be addressing the same bytes as in the first loop (that is buffer[i/8]).
In the first loop you check the top bit first (1<<(7-(i%8)) evaluates to (1<<(7-(0%8)) for i is 0, which is (1<<(7-0)), which winds up being 0x80. For i is 1, you will wind up with (1<<(7-1)), which will wind up being 0x40. So you start by checking the leftmost (Most Significant) bit, then going down to the right (to the Least Significant) bit.

In the second loop I assume you want to check the bottom bit first. So something like:

buf[i\8] & (1<<i)

would check the byte against 0x01 for i is 0, against 0x02 if i is 1, etc. etc.
0
 

Author Comment

by:thomas2010
ID: 34177570
second loop should give out each bit from right to left ( lsb to msb,)



0
 
LVL 84

Expert Comment

by:ozo
ID: 34177620
Another way could be just changing the loop to
for(int i = size*8; i>=0; i--)
0
Does Powershell have you tied up in knots?

Managing Active Directory does not always have to be complicated.  If you are spending more time trying instead of doing, then it's time to look at something else. For nearly 20 years, AD admins around the world have used one tool for day-to-day AD management: Hyena. Discover why

 
LVL 16

Expert Comment

by:imladris
ID: 34178269
>second loop should give out each bit from right to left ( lsb to msb,)

As I had surmised, and this condition for the if statement:

buf[i\8] & (1<<i)

will do exactly that. For i is 0 you will get 0x01, which is the lsb. For i is 1 you get a mask of 0x02 which is the next bit, etc.

0
 
LVL 16

Expert Comment

by:imladris
ID: 34178274
Sorry, the buf index should be division, of course, just like the first loop:

buf[i/8] & (1<<i)

0
 
LVL 16

Expert Comment

by:imladris
ID: 34189565
Did any of those answers help?

If so, it is now time to select and grade one (or more) answers.

If not, perhaps a clarifying question would help.
0
 

Author Comment

by:thomas2010
ID: 34191703
Hi . the answer not help really,
it is still not working fine. are you sure i dont need the modulus ?

void turnbits( unsigned char *buffer, int size)
{
		//OK
		for(int i = 0; i < size*8; i++)
  	{
    		if( buffer[i/8] & 1<<(7-(i%8)) )
    		{
    				printf("1");
    		}
    		else
    		{
    				printf("0");
    		}
  	}	
  	
  	printf("turn\n");
  	
  	//Not working
		for(int i = size*8; i>=0; i--)
  	{
  		if(buffer[i/8] & (1<<i) )
    		//if( buffer[((size-1)-(i/8))] & 1<<(7-(i%8)) )
    		{
    				printf("1");
    		}
    		else
    		{
    				printf("0");
    		}
  	}	
}

Open in new window

0
 
LVL 84

Accepted Solution

by:
ozo earned 500 total points
ID: 34193373
Either reverse the loop to i = size*8-1; i>=0; i--
or reverse the indexing to buffer[((size-1)-(i/8))] & 1<<(i%8)
not both, and not some mixture of the two
0

Featured Post

ScreenConnect 6.0 Free Trial

Discover new time-saving features in one game-changing release, ScreenConnect 6.0, based on partner feedback. New features include a redesigned UI, app configurations and chat acknowledgement to improve customer engagement!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Preface I don't like visual development tools that are supposed to write a program for me. Even if it is Xcode and I can use Interface Builder. Yes, it is a perfect tool and has helped me a lot, mainly, in the beginning, when my programs were small…
Windows programmers of the C/C++ variety, how many of you realise that since Window 9x Microsoft has been lying to you about what constitutes Unicode (http://en.wikipedia.org/wiki/Unicode)? They will have you believe that Unicode requires you to use…
The goal of this video is to provide viewers with basic examples to understand and use structures in the C programming language.
The goal of this video is to provide viewers with basic examples to understand opening and writing to files in the C programming language.

825 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question