Expand Powershell Script

Hello,

I built a Powershell script last week (with the very fine help from this site!!!) which could use a little improvement. So maybe anyone can help me with this?

At least the script should do the following:
- Test if a server from an input-file is available
- Query which operatings system is used
- Query which service pack level is applied
- Query if the OS is 32/64 Bit
- Query if SNMP service is installed
- Query if a user "testuser" is member of the local admin group
- Write out all the information to a csv file for Excel import

I hope I don´t ask too much !?! Any help would be great!
The basic code is attached...

Regards
Steffen

Get-Content -path "w:\servers.txt" | ForEach-Object {

  $ComputerName = $_

  Get-WmiObject Win32_OperatingSystem -ComputerName $ComputerName | Select-Object `
    @{n='Computer Name';e={ $ComputerName }},
    @{n='Operating System';e={ $_.Caption }},
    @{n='Servicepack';e={ $_.ServicePackMajorVersion }},
    @{n='SNMP';e={ Get-WmiObject Win32_service -ComputerName $ComputerName -Filter "Name='SNMP'" | Select-Object -ExpandProperty Name }},
    @{n='Architecture';e={ Get-WmiObject Win32_Processor -ComputerName $ComputerName | Select-Object -ExpandProperty Caption }}

} | Export-Csv "w:\SNoutfile1.csv" -NoTypeInformation

Open in new window

SSR-ISAsked:
Who is Participating?
 
Chris DentConnect With a Mentor PowerShell DeveloperCommented:

Apologies. Missed a {, I can't see another, I think the first error caused the remainder.

Yell if not, of course :)

Chris
Function Get-AdminGroupMember {
  Param(
    [String]$ComputerName = $Env:ComputerName
  )

  ([ADSI]"WinNT://$ComputerName/Administrators").Members() | Select-Object `
    @{n='Name';e={ $_.GetType().InvokeMember('Name', 'GetProperty', $Null, $_, $Null) }},
    @{n='ADSPath';e={ $_.GetType().InvokeMember('ADSPath', 'GetProperty', $Null, $_, $Null) }},
    @{n='Class';e={ $_.GetType().InvokeMember('class', 'GetProperty', $Null, $_, $Null) }},
    @{n='Type';e={ "Direct" }}
}

Get-Content -path "w:\servers.txt" | ForEach-Object {

  $ComputerName = $_

  # Test if a server from an input-file is available (ping)
  If (Test-Connection $ComputerName -Quiet -Count 2) {

    $OperatingSystem = Get-WmiObject Win32_OperatingSystem -ComputerName $ComputerName

    If ($?) {

      # If the command worked
 
      $OperatingSystem | Select-Object `
        @{n='Computer Name';e={ $ComputerName }},
        @{n='Status';e={ "OK" }},
        @{n='Operating System';e={ $_.Caption }},
        @{n='Servicepack';e={ $_.ServicePackMajorVersion }},
        @{n='SNMP';e={ Get-WmiObject Win32_service -ComputerName $ComputerName -Filter "Name='SNMP'" | Select-Object -ExpandProperty Name }},
        @{n='Architecture';e={ Get-WmiObject Win32_Processor -ComputerName $ComputerName | Select-Object -ExpandProperty Caption }},
        @{n='TestUserIsAdmin';e={ 
          If ((Get-AdminGroupMember $ComputerName) | Where-Object { $_.Name -Like "testuser" }) { $True } Else { $False } }}

    } Else {

      # If the command failed
      
      "" | Select-Object `
        @{n='ComputerName';e={ $ComputerName }},
        @{n='Status';e={ "WMI Connect Fail" }},
        "Operating System", ServicePack, SNMP, Architecture, TestUserIsAdmin

    }
  } Else {

    # If ping failed
  
    "" | Select-Object `
      @{n='ComputerName';e={ $ComputerName }},
      @{n='Status';e={ "Ping Fail" }},
      "Operating System", ServicePack, SNMP, Architecture, TestUserIsAdmin
  }
} | Export-Csv "w:\SNoutfile1.csv" -NoTypeInformation

Open in new window

0
 
Chris DentPowerShell DeveloperCommented:
Hey :)

The first bit can use Test-Connection.

TestUser, is this a local user? Or a Domain User?

Chris
Get-Content -path "w:\servers.txt" | ForEach-Object {

  $ComputerName = $_

  # Test if a server from an input-file is available (ping)
  If (Test-Connection $ComputerName -Quiet -Count 2) {

    Get-WmiObject Win32_OperatingSystem -ComputerName $ComputerName | Select-Object `
      @{n='Computer Name';e={ $ComputerName }},
      @{n='Operating System';e={ $_.Caption }},
      @{n='Servicepack';e={ $_.ServicePackMajorVersion }},
      @{n='SNMP';e={ Get-WmiObject Win32_service -ComputerName $ComputerName -Filter "Name='SNMP'" | Select-Object -ExpandProperty Name }},
      @{n='Architecture';e={ Get-WmiObject Win32_Processor -ComputerName $ComputerName | Select-Object -ExpandProperty Caption }}

  }
} | Export-Csv "w:\SNoutfile1.csv" -NoTypeInformation

Open in new window

0
 
SSR-ISAuthor Commented:
Oh, the "TestUser" is a domain user.
0
Creating Active Directory Users from a Text File

If your organization has a need to mass-create AD user accounts, watch this video to see how its done without the need for scripting or other unnecessary complexities.

 
Chris DentPowerShell DeveloperCommented:

Cool. So, local groups (and users for that matter) are a bit of a pain, the interface isn't quite as advanced as would be nice. Fortunately, been there / done that :)

Modified to test the administrators group for that user account.

Chris
Function Get-AdminGroupMember {
  Param(
    [String]$ComputerName = $Env:ComputerName
  )

  ([ADSI]"WinNT://$ComputerName/Administrators").Members() | Select-Object `
    @{n='Name';e={ $_.GetType().InvokeMember('Name', 'GetProperty', $Null, $_, $Null) }},
    @{n='ADSPath';e={ $_.GetType().InvokeMember('ADSPath', 'GetProperty', $Null, $_, $Null) }},
    @{n='Class';e={ $_.GetType().InvokeMember('class', 'GetProperty', $Null, $_, $Null) }},
    @{n='Type';e={ "Direct" }}
}


Get-Content -path "w:\servers.txt" | ForEach-Object {

  $ComputerName = $_

  # Test if a server from an input-file is available (ping)
  If (Test-Connection $ComputerName -Quiet -Count 2) {

    Get-WmiObject Win32_OperatingSystem -ComputerName $ComputerName | Select-Object `
      @{n='Computer Name';e={ $ComputerName }},
      @{n='Operating System';e={ $_.Caption }},
      @{n='Servicepack';e={ $_.ServicePackMajorVersion }},
      @{n='SNMP';e={ Get-WmiObject Win32_service -ComputerName $ComputerName -Filter "Name='SNMP'" | Select-Object -ExpandProperty Name }},
      @{n='Architecture';e={ Get-WmiObject Win32_Processor -ComputerName $ComputerName | Select-Object -ExpandProperty Caption }},
      @{n='TestUserIsAdmin';e={ 
        If ((Get-AdminGroupMember $ComputerName) | Where-Object { $_.Name -Like "testuser" }) { $True } Else { $False } }}
  }
} | Export-Csv "w:\SNoutfile1.csv" -NoTypeInformation

Open in new window

0
 
SSR-ISAuthor Commented:
This works so far in my test environment. Thanks!

The was another thing with my further script. For some servers I got an access denied and sometimes "RPC Server not available". Is it possible to document this error messages in the csv file? Just to know why the connection didn´t work.
0
 
Chris DentPowerShell DeveloperCommented:

Sure.

I added a note to catch ping failures as well. It "should" work :)

Chris
Function Get-AdminGroupMember {
  Param(
    [String]$ComputerName = $Env:ComputerName
  )

  ([ADSI]"WinNT://$ComputerName/Administrators").Members() | Select-Object `
    @{n='Name';e={ $_.GetType().InvokeMember('Name', 'GetProperty', $Null, $_, $Null) }},
    @{n='ADSPath';e={ $_.GetType().InvokeMember('ADSPath', 'GetProperty', $Null, $_, $Null) }},
    @{n='Class';e={ $_.GetType().InvokeMember('class', 'GetProperty', $Null, $_, $Null) }},
    @{n='Type';e={ "Direct" }}
}

Get-Content -path "w:\servers.txt" | ForEach-Object {

  $ComputerName = $_

  # Test if a server from an input-file is available (ping)
  If (Test-Connection $ComputerName -Quiet -Count 2) {

    $OperatingSystem = Get-WmiObject Win32_OperatingSystem -ComputerName $ComputerName

    If ($?) {

      # If the command worked
 
      $OperatingSystem | Select-Object `
        @{n='Computer Name';e={ $ComputerName }},
        @{n='Status';e={ "OK" }},
        @{n='Operating System';e={ $_.Caption }},
        @{n='Servicepack';e={ $_.ServicePackMajorVersion }},
        @{n='SNMP';e={ Get-WmiObject Win32_service -ComputerName $ComputerName -Filter "Name='SNMP'" | Select-Object -ExpandProperty Name }},
        @{n='Architecture';e={ Get-WmiObject Win32_Processor -ComputerName $ComputerName | Select-Object -ExpandProperty Caption }},
        @{n='TestUserIsAdmin';e={ 
          If ((Get-AdminGroupMember $ComputerName) | Where-Object { $_.Name -Like "testuser" }) { $True } Else { $False } }}

    } Else 

      # If the command failed
      
      "" | Select-Object `
        @{n='ComputerName';e={ $ComputerName }},
        @{n='Status';e={ "WMI Connect Fail" }},
        "Operating System", ServicePack, SNMP, Architecture, TestUserIsAdmin

    }
  } Else {

    # If ping failed
  
    "" | Select-Object `
      @{n='ComputerName';e={ $ComputerName }},
      @{n='Status';e={ "Ping Fail" }},
      "Operating System", ServicePack, SNMP, Architecture, TestUserIsAdmin
  }
} | Export-Csv "w:\SNoutfile1.csv" -NoTypeInformation

Open in new window

0
 
Chris DentPowerShell DeveloperCommented:

Perhaps I should just add a quick note about this.

Export-Csv expects everything we return to have the same properties, otherwise it gets all confused and might hide stuff.

A property of the return object in this case would be a field like "Operating System". If this is not present in all of our different return values (the working one, WMI Conenct Fail, and Ping Fail) then things will disappear. Quite frustrating if you don't know about it.

Chris
0
 
SSR-ISAuthor Commented:
Thanks a lot Chris-Dent. I´ll give it a try in out test environment and then let it run in production!
I´ll give you some feedback.

Steffen
0
 
SSR-ISAuthor Commented:
Uh, I´m sorry, but I got some errors running the script:
Missing statement block after 'else' keyword.
At line:40 char:7

Missing statement after '=' in hash literal.
At line:41 char:47

Missing statement after '=' in hash literal.
At line:42 char:46

Missing statement after '=' in hash literal.
At line:51 char:45

Missing statement after '=' in hash literal.
At line:52 char:37

Unexpected token '}' in expression or statement.
At line:55 char:1
0
 
SSR-ISAuthor Commented:
Hi Chirs,

the script was running very fine last night! As you expected, after a wmi- or ping connection error, the CSV-file missed the servername. But this was no problem at all because by importing it into my Excel-Listíng the lines matched.

Thanks a lot for your help! I might come up with some SNMP-Installion-Script questions later today ;-))
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.