Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium


membership.getuser() for parameter to display custom user information

Posted on 2010-11-23
Medium Priority
Last Modified: 2012-05-10

I set up my site using a SQlMembershipProvider and Customized the CreateUserWizard to collect additional user information such as LastName, FirstName, etc.

I created a table to store the additional info instead of implementing profiles because I didn't wat to be tied to that structure.

Now I'm having trouble retrieving the additional user information to display on page in labels or text boxes, after the user is logged in.

I'm trying a 3 Tiered Architecture with business objects for the first time and I'm probably doing this wrong or making it difficult but I really trying to learn it. I'm pretty new to programming.

Please check out my attachment and give me some advice....
 Under GetOfficerInfo function, I get an error with Return reader --Name 'reader' is not declared.
Thanks MyCode.pdf
Question by:tis9700
  • 8
  • 6

Expert Comment

ID: 34199021
The problem is that the variable 'reader' is not available to the return statement.   Create an empty reader at a higher level in the code tree and reference it in the If statement.
LVL 16

Expert Comment

ID: 34199070
since reader is declared within the scope of the using statement it is not available for return.  what you should actually do is declare your officerInfo object higher up and return that since that is what the return type of the sub is
LVL 16

Expert Comment

ID: 34199085
i think this should do it
Public Shared Function GetOfficerInfo(ByVal uId As String) As OfficerInfo
        Dim errorstr As String = String.Empty
        Dim offNo As New OfficerInfo
        'get a reference to the currenly logged on user
        Dim currentUser As MembershipUser = Membership.GetUser("UserId")
        'determine the currently logged on user's UserId value
        Dim currentUserId As Guid = CType(currentUser.ProviderUserKey, Guid)
        Using conn As New SqlConnection _
        (ConfigurationManager.ConnectionStrings _
                Using cmd As New SqlCommand("GetUserProfile", conn)
                    cmd.CommandType = CommandType.StoredProcedure
                    cmd.Parameters.AddWithValue("@userId", currentUserId)
                    Dim reader As SqlDataReader = cmd.ExecuteReader(CommandBehavior.SingleRow)
                    If reader.Read Then
                        'offNo.UserId = rd("UserId")
                        offNo.OfficerNo = reader("OfficerNo")
                        offNo.FirstName = reader("FirstName")
                        offNo.LastName = reader("LastName")
                    End If
                End Using
            Catch ex As Exception
                errorstr += "" & ex.Message
                Return Nothing
                CType(conn, IDisposable).Dispose()
            End Try
            Return offNo 'have a error here Name ‘reader’ is not declared.
        End Using
    End Function

Open in new window

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!


Author Comment

ID: 34200041
Thanks for responding.


I made the chages you suggested. By the way, was conn.Open(); a typo or because you mainly use C#?

Anyway, after implemeinting your suggested changes, I  created a function in a Business Logic Layer..

Public Class OfficerBl
     Public Shared FunctiongetOfficer(ByVal uId as String) as OfficerInfo
           Return ActivityDll.GetOfficerInfo(uId)
    End Function
End Class

Then I try to display the results in three textboxes after the user logs in.....
The textboxes are actually located within a Master page....
Master Page code-behind

Public Sub LoadInfo()
      Dim displayOfficer as New OfficerInfo

      txtBadge.text = displayOfficer .OfficerNo
      txtFirstName.text = displayOfficer .FirstName
      txtLastName.text = displayOfficer .LastName
End Sub
Then in the Page_Load event...
If  Not Page.IsPostBack Then
End If

While I have no error on compling, no values are returned.

In my data access layer, I have (Byval uId as string) , should I set that equal to currentUserId? Or something? Could that be the issue?

LVL 16

Expert Comment

ID: 34200076

In your load i dont see you calling the FunctionGetOfficer and setting that to displayOfficer
LVL 16

Expert Comment

ID: 34200141
youll need to add something like this to the load
 Dim displayOfficer As New OfficerInfo
  displayOfficer = GetOfficerInfo("Test")<--replace test with the current id you want
LVL 16

Expert Comment

ID: 34200148
actually since in the latest code its
displayOfficer = FunctiongetOfficer("UID")

Author Comment

ID: 34200357

I added ...

displayOfficer = OfficerBl.getOfficer("uId")

And I at least get an error when I log in...within my ActivityDll
Null Reference Exception
Object reference not set to an instance of an object

Line 137: Dim currentUserId as Guid = CType(currentuser.ProviderUserKey, Guid)

So I wonder...
Am I not getting the User from  membership.getuser()?

Maybe I should have
Dim currentUser as Membership = Membership.GetUser("UserId")
Dim currentUserId as Guid = CType(currentuser.ProviderUserKey, Guid)
someplace other than the data access layer . Perhaps in my code behind?


cmd.Parameters.AddWithValue("@userId", uId)

Man, I am getting confused!
LVL 16

Expert Comment

ID: 34200419
displayOfficer = OfficerBl.getOfficer("uId")

"uid" needs to be replace with the actual user id you want to pass
and this
Dim currentUser as Membership = Membership.GetUser("UserId")
UserId needs to be the user id you are looking for

and to check that you are getting the right user
Dim currentUser as Membership = Membership.GetUser("UserId")
Dim currentUserId as Guid = CType(currentuser.ProviderUserKey, Guid)<-- put breakpoint and see if user is correct

Author Comment

ID: 34200576

Put a breakpoint on that line

and currentUserId is returning empty
LVL 16

Expert Comment

ID: 34200667
what does current user have when it hits the breakpoint?  currentUserId will be empty until you step passed the breakpoint
you will need to have the "UserID" be the user id you are grabbing
Dim currentUser as Membership = Membership.GetUser(Put user id here)

Author Comment

ID: 34200924
Hey burakiewicz,

I have to cut off for the night. Family Thanksgiving stuff.

I'll be back in the morning. Thanks for all you help today. Hope I'm not wearing you out.


Author Comment

ID: 34207670
Hey burakiewicz,

I got it working!

I moved the currentUser and currentUserId to my Presentation Layer on the Page_Load

Used HttpContext.Current.User.Identity.Name to get the currentUser and passed it to the currentUserId to get the userId

set currentUserId = currentUser.ProviderUserKey.ToString

Then passed currentUserId to getOfficer object for the OfficerBl..

I attached my revised code. Would you look at it and tell me what you think? Should I be checking the object to make sure it is not nothing? Or anything else that is best practice?

Thanks and Happy Thanksgiving!
LVL 16

Accepted Solution

burakiewicz earned 2000 total points
ID: 34231209
one thing in the DAL is that you are just catching the exception and not really handling it so if there is a connection error or anything it could be hidden, so i would throw the error or handle it.  Then i would also check that display officer is something before assigning it to the textboxes

Author Comment

ID: 34231404
Thanks buraiewicz,

I appreciate the help and advice you've given me.  I'll start researching how to handle exceptions.

Featured Post

Hire Technology Freelancers with Gigs

Work with freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely, and get projects done right.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Parsing a CSV file is a task that we are confronted with regularly, and although there are a vast number of means to do this, as a newbie, the field can be confusing and the tools can seem complex. A simple solution to parsing a customized CSV fi…
This article shows how to deploy dynamic backgrounds to computers depending on the aspect ratio of display
This Micro Tutorial will teach you how to add a cinematic look to any film or video out there. There are very few simple steps that you will follow to do so. This will be demonstrated using Adobe Premiere Pro CS6.
This video shows how to quickly and easily deploy an email signature for all users in Office 365 and prevent it from being added to replies and forwards. (the resulting signature is applied on the server level in Exchange Online) The email signat…

572 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question