Solved

T-SQL: Stored Procedure - variable assignment

Posted on 2010-11-24
3
456 Views
Last Modified: 2012-05-10
Techies--
Why does @TestCaseStatement in the code snippet fail to set to any value when variables are empty? I am trying to output to a table the values of variables whether they contain strings, integers or are just unset.

Also,  when I get this to work, I want to import this logic into a program that has multiple transactions -- how do I manage
the GOTO routine so as to avoid the write to the error/debug log under ProcessDEBUG: from being treated as part of an existing transaction? Finally, what happens on a return in a GOTO when called while processing a transaction?




DECLARE @dbgFlag bit
DECLARE @TestCaseStatement nvarchar(max)

SET @dbgFlag = 'True'

IF(@valTest = 'GO')
 BEGIN

-- ##DEBUG
   IF (@dbgFlg = 'True')
    BEGIN
     -- // this works because @StrikeTypeName is set to a value like 'Field'
     -- SET @TestCaseStatement = 'UPDATE s1: StrikeTypeName incoming: ' + 
     --   @StrikeTypeName + ' conditioned      lowercase: ' + @StrikeTypeName + 
     -- ' PatClassTypeID: ' + convert(varchar(10),@PatClassTypeID) 
     -- // This did NOT work, because the incoming values are not set to anything.
     -- SET @TestCaseStatement = 'UPDATE s2: ret_myDesignID incoming: ' + 
     -- convert(varchar(10),@ret_myDesignID) + ' BOPatternNum incoming: ' + 
     -- @BOPatternNum + ' BOPatternID: ' + convert(varchar(10),@BOPatternID)
     
     -- // This worked because I forced a value of '103'.
     SET @TestCaseStatement = 'UPDATE s2: ret_myDesignID incoming: ' + convert(varchar(10),103)

     PRINT @TestCaseStatement
     GOTO ProcessDEBUG

    END

 END

ProcessDEBUG:

INSERT INTo SHG_ErrorLog 
 (EntryDate,
  AppName,
  ErrorMsg
 )
VALUES
 (getdate(),
  'DASH',
  @TestCaseStatement
 )

return

Open in new window

0
Comment
Question by:ditallop
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
3 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 34206302
that is because 'string' + NULL returns NULL ...

so, you need to handle NULL value in your case of building the SQL.

     SET @TestCaseStatement = 'UPDATE s2  SET ret_myDesignID = ' + CASE WHEN @ret_myDesignID IS NULL THEN 'NULL' ELSE CAST(@ret_myDesignID as varchar(10)) END + ' ' 

Open in new window

and in case the field is varchar:
     SET @TestCaseStatement = 'UPDATE s2  SET ret_myDesignID = ' + CASE WHEN @ret_myDesignID IS NULL THEN 'NULL' ELSE '''' + CAST(@ret_myDesignID as varchar(10)) + '''' END + ' ' 

Open in new window

0
 

Author Comment

by:ditallop
ID: 34206454
Thanks! BTW, on the second half of the question -- what happens under a goto with a return when processing a transaction--and is it possible to isolate the insert to the debug log outside of the transaction assumption that the insert to the debug logger is part of a specific transaction?  what i want to do is be able to use this goto from whatever transaction i happen to be on --
0
 
LVL 143

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 34206503
you have to ensure that your procedure does COMMIT/ROLLBACK need to be balanced.
so, if you have a BEGIN TRANSACTION, and RETURN without a COMMIT/ROLLBACK, you will have the result that if the calling code does not commit on it's turn, the transaction is rolled back.

so, for the debug, you can rollback explicitly (if a transaction has been started, check @@trancount value), and begin + commit a transaction for the debug stuff apart.
0

Featured Post

Enroll in June's Course of the Month

June’s Course of the Month is now available! Experts Exchange’s Premium Members, Team Accounts, and Qualified Experts have access to a complimentary course each month as part of their membership—an extra way to sharpen your skills and increase training.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

When writing XML code a very difficult part is when we like to remove all the elements or attributes from the XML that have no data. I would like to share a set of recursive MSSQL stored procedures that I have made to remove those elements from …
In this article I will describe the Copy Database Wizard method as one possible migration process and I will add the extra tasks needed for an upgrade when and where is applied so it will cover all.
This is my first video review of Microsoft Bookings, I will be doing a part two with a bit more information, but wanted to get this out to you folks.
Do you want to know how to make a graph with Microsoft Access? First, create a query with the data for the chart. Then make a blank form and add a chart control. This video also shows how to change what data is displayed on the graph as well as form…

726 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question