Solved

preg_match_all returns false for first match

Posted on 2010-11-28
6
362 Views
Last Modified: 2012-05-10
I am writing a calculator engine, and need to get the numbers and operators from the expression (a string). To do this I am using preg_match_all, with PREG_OFFSET_CAPTURE, that returns an array with all of the numbers and another with the operators. The operators part works fine, but the first matched number in the array is false instead of the number. Here is the function I am using:

$exp='13+4x2';
preg_match_all('/[0-9.\-\[]+/',$exp,$exp_nums,PREG_OFFSET_CAPTURE);

Open in new window


this returns:

array(1) {
  [0]=>
  array(3) {
    [0]=>
    array(2) {
      [0]=>
      bool(false) //improper value
      [1]=>
      int(1)
    }
    [1]=>
    array(2) {
      [0]=>
      string(1) "4"
      [1]=>
      int(4)
    }
    [2]=>
    array(2) {
      [0]=>
      string(1) "2"
      [1]=>
      int(6)
    }
  }
}

Open in new window


Does anyone know how to fix this
0
Comment
Question by:cloud-9
  • 4
  • 2
6 Comments
 
LVL 35

Accepted Solution

by:
Terry Woods earned 500 total points
ID: 34227650
How about this: (results below)

$exp='13+4x2';
preg_match_all('/[0-9.]+/','#'.$exp,$exp_nums,PREG_OFFSET_CAPTURE);
print_r($exp_nums);
Array

(

    [0] => Array

        (

            [0] => Array

                (

                    [0] => 13

                    [1] => 1

                )



            [1] => Array

                (

                    [0] => 4

                    [1] => 4

                )



            [2] => Array

                (

                    [0] => 2

                    [1] => 6

                )



        )



)

Open in new window

0
 
LVL 35

Expert Comment

by:Terry Woods
ID: 34227655
Your code gives me this result actually, which seems different from what you're getting:
Array

(

    [0] => Array

        (

            [0] => Array

                (

                    [0] => 13

                    [1] => 0

                )



            [1] => Array

                (

                    [0] => 4

                    [1] => 3

                )



            [2] => Array

                (

                    [0] => 2

                    [1] => 5

                )



        )



)

Open in new window

0
 
LVL 35

Expert Comment

by:Terry Woods
ID: 34227662
I'm not sure why you're trying to match - and [ characters in your pattern:
/[0-9.\-\[]+/

 but the backslashes need to have an extra escape character if you're going to try to do it:
/[0-9.\\-\\[]+/

However, with the code:
$exp='13+4x2-5-17';
preg_match_all('/[0-9.\\-\\[]+/',$exp,$exp_nums,PREG_OFFSET_CAPTURE);
print_r($exp_nums);

The result is probably not what you want:


Array

(

    [0] => Array

        (

            [0] => Array

                (

                    [0] => 13

                    [1] => 0

                )



            [1] => Array

                (

                    [0] => 4

                    [1] => 3

                )



            [2] => Array

                (

                    [0] => 2-5-17

                    [1] => 5

                )



        )



)

Open in new window

0
IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 
LVL 35

Expert Comment

by:Terry Woods
ID: 34227663
(My first suggestion solves that problem)
0
 
LVL 3

Assisted Solution

by:cloud-9
cloud-9 earned 0 total points
ID: 34235119
The - and ] characters denote a negative sign (a subtraction operator is _) and a fraction symbol such as on a scientific calculator (ex 2[5 means two fifths). "2-5-17" would  produce a syntax error on my calculator. But all of this is beside the point.

I discovered my error: I am using gmp_init to convert all of the numbers in the array. I forgot I was using a different array structure previously, and I was trying to convert an array into a gmp number. Apparently the failure of the first gmp_init broke the loop and the other values were not processed. The array I was var_dumping came after the failed gmp_init. So there was no problem with preg_match_all in the first place. Sorry for inconvenience.
0
 
LVL 3

Author Closing Comment

by:cloud-9
ID: 34272890
I am still giving points for the prompt response.
0

Featured Post

What is SQL Server and how does it work?

The purpose of this paper is to provide you background on SQL Server. It’s your self-study guide for learning fundamentals. It includes both the history of SQL and its technical basics. Concepts and definitions will form the solid foundation of your future DBA expertise.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
Error viewing ASP page 12 99
url rewrites not working in codeigniter 2 13
Adding through query php 9 12
two tables one button 11 20
Envision that you are chipping away at another e-business site with a team of pundit developers and designers. Everything seems, by all accounts, to be going easily.
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
This video teaches users how to migrate an existing Wordpress website to a new domain.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now