Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 528
  • Last Modified:

the smallest positive number in a array

Hallo, i dont know how to find the smallest positive number in a array

here is my code i can someone help me please

THANKS
#include <stdio.h>
#include <conio.h>
int main(void)
{
short getalen[]={16,23,-7,10,85,-18,16,8};
short i;
short sp;
     
     
      for (i=0;getalen[i]>=0;i++)
      {
       if (getalen[i] < sp)
       sp=getalen[i];
          
      }
      
      printf("\nthe smallest positive number in a array is %hd",sp); 
          getchar();
}

Open in new window

0
kensy11
Asked:
kensy11
  • 4
  • 3
  • 2
  • +2
1 Solution
 
Infinity08Commented:
>>       for (i=0;getalen[ i]>=0;i++)

You want to loop over all values in the array, so your loop condition should not be 'getalen[ i]>=0', but rather it should check i against the size of the array.

Then inside the loop, you check whether the value is positive or not. If it's negative, just skip it, and go to the next.
0
 
HainKurtSr. System AnalystCommented:
set your sp to first element or 0 first

short sp;
sp = 0;
0
 
HainKurtSr. System AnalystCommented:
also use size of array in your loop

short s;
s= sizeof(getlana);
for (i=0;i<s;i++) {...}
0
Get expert help—faster!

Need expert help—fast? Use the Help Bell for personalized assistance getting answers to your important questions.

 
kraivenCommented:
You're looping over the wrong thing, I think. As this works I would expect your lop to break out after reading 16 and 23 returning a value of 16 as your answer - is that what you see?

I think you want to loop over the entire array using the array size (i.e. number of items) and then test for
getalen[i] >= 0 

Open in new window

as well as testing for the smallest number within your loop.

To get the number of array items use the sizeof operator
 [b]sizeof(getalen)/sizeof(int)[/b]

Open in new window


Hope that helps.
0
 
kensy11Author Commented:
thank you all
my code looks like this now

one question about the sizeof how does it work ? can i for example use it  here: for (i=0;i < 8;i++)  so instead of saying i < 8  can i  use the sizeof ?



#include <stdio.h>
#include <conio.h>
int main(void)
{
short getalen[]={16,23,-7,10,85,-18,16,8};
short i;
short sp=0;
     
     
      for (i=0;i < 8;i++)
      {
       if (getalen[i] >= 0)
          sp= getalen[i];
      }
      
      printf("\nthe smallest positive number in a array is %hd",sp); 
          getchar();
}

Open in new window

0
 
kraivenCommented:
OK kensy11. If you know the size of your array then your in luck. however, the code you give will just return the last item of the array. Correct as it happens in this case but not in general.
0
 
masheikCommented:
sizeof(getalen)/sizeof(getalen[0])
0
 
masheikCommented:
The above code finds the total array size
sizeof(getlana) =
variable size * num of elements
= here 8*2
Sizeof(getlana[0]) = size of the first element of the array = 2
 
0
 
Infinity08Commented:
>>       for (i=0;i < 8;i++)
>>       {
>>        if (getalen[ i] >= 0)
>>           sp= getalen[ i];
>>       }

That's looking better. Now you're iterating over all values in the array, and are only processing those values that are positive.

All you need to add now, is one more check to see if the current value is smaller than the current smallest positive number (sp).

Note that in order for this to work, you'll have to initialize sp to a value that is larger than any possible value in the array.
0
 
Infinity08Commented:
There is no need for sorting the array. That is just needlessly over-complicating things. You are doing good with your own code, kensy11. You're almost there, so stick with it :)


I also don't understand why we apparently need 6 (!!) experts for this kind of question. That becomes very counter productive, and is not a very professional way of dealing with questions. I would love to see if everyone checks what has already been posted (and thinking twice whether it's really necessary to add yet another suggestion) before making a contribution. It would make things go so much smoother.
0
 
kraivenCommented:
Infinity08: To be fair, when I first posted there were no other posts; I expect this has been the case for the others as well.
0
 
Infinity08Commented:
kraiven : it is normal to have several posts within seconds/minutes at the start of a question. That only accounts for 3 of the 6 experts in this question though ;)
My previous post wasn't directed at people specifically - it's just a general observation of what I see happening in the C zone lately (ie. not just this question).
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

The 14th Annual Expert Award Winners

The results are in! Meet the top members of our 2017 Expert Awards. Congratulations to all who qualified!

  • 4
  • 3
  • 2
  • +2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now